Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Ban extra elses #366

Merged
merged 5 commits into from
Apr 20, 2022
Merged

build: Ban extra elses #366

merged 5 commits into from
Apr 20, 2022

Conversation

AndrewSisley
Copy link
Contributor

Closes #364

Adds a linter rule prohibiting else clauses from following if statements that always escape, for example:

if foo == 2 {
  return bar()
} else {
  return fooBar()
}

must become:

if foo == 2 {
  return bar()
}
return fooBar()

Also reworks the 3 current violations of this rule in our codebase

@AndrewSisley AndrewSisley added ci/build This is issue is about the build or CI system, and the administration of it. code quality Related to improving code quality labels Apr 19, 2022
@AndrewSisley AndrewSisley added this to the DefraDB v0.3 milestone Apr 19, 2022
@AndrewSisley AndrewSisley self-assigned this Apr 19, 2022
@source-devs
Copy link

Benchmark Results

Summary

  • 113 Benchmarks successfully compared.
  • 4 Benchmarks were ✅ Better.
  • 109 Benchmarks were ❌ Worse .
  • 0 Benchmarks were ✨ Unchanged.
✅ See Better Results...
time/opdelta
_Collection_UserSimple_Read_Sync_1000_1000-440.4ms ± 0%39.3ms ± 0%−2.75%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-4735µs ± 0%698µs ± 0%−5.02%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4770µs ± 0%738µs ± 0%−4.15%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-41.24ms ± 0%1.22ms ± 0%−1.57%(p=1.000 n=1+1)
 
❌ See Worse Results...
time/opdelta
_Collection_UserSimple_CreateMany_Sync_0_100-4230ms ± 0%292ms ± 0%+26.92%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_10-49.77ms ± 0%12.65ms ± 0%+29.56%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_100-499.3ms ± 0%116.1ms ± 0%+16.93%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_1000-41.02s ± 0%1.19s ± 0%+16.34%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-446.0ms ± 0%50.6ms ± 0%+9.97%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_1000-4449ms ± 0%466ms ± 0%+3.81%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-44.63s ± 0%4.77s ± 0%+3.04%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4352µs ± 0%364µs ± 0%+3.41%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_100_100-43.95ms ± 0%4.00ms ± 0%+1.28%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4370µs ± 0%401µs ± 0%+8.30%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-43.94ms ± 0%4.07ms ± 0%+3.45%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_10_10-4254µs ± 0%329µs ± 0%+29.26%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-41.86ms ± 0%1.86ms ± 0%+0.23%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-424.6ms ± 0%25.3ms ± 0%+2.94%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4257µs ± 0%289µs ± 0%+12.47%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-41.82ms ± 0%1.94ms ± 0%+6.24%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-41.14ms ± 0%1.41ms ± 0%+23.29%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_1000-49.69ms ± 0%10.23ms ± 0%+5.61%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4417µs ± 0%492µs ± 0%+18.10%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-41.27ms ± 0%1.56ms ± 0%+22.83%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-410.1ms ± 0%10.4ms ± 0%+2.70%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4381µs ± 0%480µs ± 0%+25.89%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4432µs ± 0%518µs ± 0%+19.86%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4433µs ± 0%447µs ± 0%+3.20%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4662µs ± 0%672µs ± 0%+1.53%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4288µs ± 0%301µs ± 0%+4.28%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4287µs ± 0%340µs ± 0%+18.40%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4286µs ± 0%286µs ± 0%+0.13%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4443µs ± 0%572µs ± 0%+28.96%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-41.53ms ± 0%1.70ms ± 0%+11.29%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-412.5ms ± 0%13.0ms ± 0%+3.79%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-413.9µs ± 0%15.4µs ± 0%+10.69%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-415.6µs ± 0%17.2µs ± 0%+10.07%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-415.8µs ± 0%19.6µs ± 0%+24.09%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-419.4µs ± 0%25.2µs ± 0%+29.97%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4135µs ± 0%150µs ± 0%+11.58%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4135µs ± 0%168µs ± 0%+24.56%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4142µs ± 0%203µs ± 0%+42.83%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4157µs ± 0%226µs ± 0%+44.66%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4195µs ± 0%285µs ± 0%+46.04%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-414.7µs ± 0%17.6µs ± 0%+19.19%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-415.2µs ± 0%20.5µs ± 0%+34.51%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-415.5µs ± 0%28.2µs ± 0%+82.03%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-418.4µs ± 0%21.8µs ± 0%+18.55%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-422.8µs ± 0%31.1µs ± 0%+36.14%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4135µs ± 0%161µs ± 0%+18.82%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4145µs ± 0%161µs ± 0%+11.05%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4149µs ± 0%173µs ± 0%+15.63%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4162µs ± 0%173µs ± 0%+6.81%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4212µs ± 0%234µs ± 0%+10.59%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-450.7µs ± 0%58.8µs ± 0%+16.09%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-449.9µs ± 0%56.6µs ± 0%+13.47%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-451.2µs ± 0%58.0µs ± 0%+13.28%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-458.5µs ± 0%64.8µs ± 0%+10.81%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-468.5µs ± 0%72.0µs ± 0%+5.13%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4387µs ± 0%438µs ± 0%+13.43%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4355µs ± 0%465µs ± 0%+31.07%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4380µs ± 0%420µs ± 0%+10.55%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4407µs ± 0%445µs ± 0%+9.20%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4504µs ± 0%529µs ± 0%+5.05%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-445.9µs ± 0%54.0µs ± 0%+17.58%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-445.2µs ± 0%59.6µs ± 0%+31.94%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-448.9µs ± 0%59.9µs ± 0%+22.61%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-456.7µs ± 0%63.3µs ± 0%+11.48%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-469.5µs ± 0%75.3µs ± 0%+8.29%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4364µs ± 0%494µs ± 0%+35.80%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4357µs ± 0%453µs ± 0%+26.92%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4368µs ± 0%501µs ± 0%+36.11%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4405µs ± 0%500µs ± 0%+23.44%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4519µs ± 0%561µs ± 0%+8.07%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4125µs ± 0%154µs ± 0%+23.17%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4125µs ± 0%147µs ± 0%+17.21%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4125µs ± 0%171µs ± 0%+37.10%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4130µs ± 0%173µs ± 0%+32.75%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4148µs ± 0%196µs ± 0%+32.80%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-41.20ms ± 0%1.34ms ± 0%+11.49%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-41.27ms ± 0%1.51ms ± 0%+19.05%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-41.27ms ± 0%1.33ms ± 0%+4.68%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-41.33ms ± 0%1.44ms ± 0%+8.14%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-41.38ms ± 0%1.67ms ± 0%+20.79%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4119µs ± 0%145µs ± 0%+22.02%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4119µs ± 0%145µs ± 0%+21.47%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4122µs ± 0%125µs ± 0%+2.41%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4125µs ± 0%136µs ± 0%+8.63%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4136µs ± 0%159µs ± 0%+17.38%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-41.17ms ± 0%1.22ms ± 0%+4.71%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-41.19ms ± 0%1.37ms ± 0%+14.92%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-41.21ms ± 0%1.25ms ± 0%+3.23%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-41.26ms ± 0%1.41ms ± 0%+12.04%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-41.39ms ± 0%1.69ms ± 0%+21.60%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-48.57µs ± 0%9.15µs ± 0%+6.67%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-48.88µs ± 0%10.83µs ± 0%+21.86%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-49.34µs ± 0%11.88µs ± 0%+27.17%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-410.8µs ± 0%13.3µs ± 0%+23.63%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-414.4µs ± 0%17.2µs ± 0%+19.73%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-486.6µs ± 0%105.0µs ± 0%+21.19%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-490.0µs ± 0%103.2µs ± 0%+14.61%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-4102µs ± 0%111µs ± 0%+9.07%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4117µs ± 0%136µs ± 0%+16.05%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4141µs ± 0%172µs ± 0%+21.68%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4124µs ± 0%126µs ± 0%+2.10%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4123µs ± 0%131µs ± 0%+7.05%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4127µs ± 0%133µs ± 0%+4.08%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4121µs ± 0%127µs ± 0%+4.86%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4127µs ± 0%139µs ± 0%+9.39%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-41.22ms ± 0%1.30ms ± 0%+6.22%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-41.22ms ± 0%1.28ms ± 0%+4.96%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-41.23ms ± 0%1.27ms ± 0%+2.51%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-41.27ms ± 0%1.31ms ± 0%+3.12%(p=1.000 n=1+1)
 
✨ See Unchanged Results...
time/opdelta
 
🐋 See Full Results...
develop.txtcurrent.txt
time/opdelta
pkg:github.com/sourcenetwork/defradb/bench/collection goos:linux goarch:amd64
_Collection_UserSimple_CreateMany_Sync_0_10-412.2ms ± 0%11.4ms ± 0%−6.08%(p=1.000 n=1+1)
_Collection_UserSimple_CreateMany_Sync_0_100-4230ms ± 0%292ms ± 0%+26.92%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_10-49.77ms ± 0%12.65ms ± 0%+29.56%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_100-499.3ms ± 0%116.1ms ± 0%+16.93%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_1000-41.02s ± 0%1.19s ± 0%+16.34%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-446.0ms ± 0%50.6ms ± 0%+9.97%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_1000-4449ms ± 0%466ms ± 0%+3.81%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-44.63s ± 0%4.77s ± 0%+3.04%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4352µs ± 0%364µs ± 0%+3.41%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_100_100-43.95ms ± 0%4.00ms ± 0%+1.28%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_1000-440.4ms ± 0%39.3ms ± 0%−2.75%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4370µs ± 0%401µs ± 0%+8.30%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-43.94ms ± 0%4.07ms ± 0%+3.45%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_10_10-4254µs ± 0%329µs ± 0%+29.26%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-41.86ms ± 0%1.86ms ± 0%+0.23%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-424.6ms ± 0%25.3ms ± 0%+2.94%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4257µs ± 0%289µs ± 0%+12.47%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-41.82ms ± 0%1.94ms ± 0%+6.24%(p=1.000 n=1+1)
pkg:github.com/sourcenetwork/defradb/bench/query/simple goos:linux goarch:amd64
_Query_UserSimple_Query_Sync_10-4349µs ± 0%371µs ± 0%+6.31%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-41.14ms ± 0%1.41ms ± 0%+23.29%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_1000-49.69ms ± 0%10.23ms ± 0%+5.61%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4417µs ± 0%492µs ± 0%+18.10%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-41.27ms ± 0%1.56ms ± 0%+22.83%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-410.1ms ± 0%10.4ms ± 0%+2.70%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4381µs ± 0%480µs ± 0%+25.89%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4432µs ± 0%518µs ± 0%+19.86%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4433µs ± 0%447µs ± 0%+3.20%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-4735µs ± 0%698µs ± 0%−5.02%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4770µs ± 0%738µs ± 0%−4.15%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4662µs ± 0%672µs ± 0%+1.53%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4288µs ± 0%301µs ± 0%+4.28%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4287µs ± 0%340µs ± 0%+18.40%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4286µs ± 0%286µs ± 0%+0.13%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4443µs ± 0%572µs ± 0%+28.96%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-41.53ms ± 0%1.70ms ± 0%+11.29%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-412.5ms ± 0%13.0ms ± 0%+3.79%(p=1.000 n=1+1)
pkg:github.com/sourcenetwork/defradb/bench/storage goos:linux goarch:amd64
_Storage_Simple_Read_Sync_1_10/ValueSize:0064-412.6µs ± 0%16.1µs ± 0%+27.20%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-413.9µs ± 0%15.4µs ± 0%+10.69%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-415.6µs ± 0%17.2µs ± 0%+10.07%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-415.8µs ± 0%19.6µs ± 0%+24.09%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-419.4µs ± 0%25.2µs ± 0%+29.97%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4135µs ± 0%150µs ± 0%+11.58%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4135µs ± 0%168µs ± 0%+24.56%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4142µs ± 0%203µs ± 0%+42.83%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4157µs ± 0%226µs ± 0%+44.66%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4195µs ± 0%285µs ± 0%+46.04%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-414.7µs ± 0%17.6µs ± 0%+19.19%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-415.2µs ± 0%20.5µs ± 0%+34.51%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-415.5µs ± 0%28.2µs ± 0%+82.03%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-418.4µs ± 0%21.8µs ± 0%+18.55%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-422.8µs ± 0%31.1µs ± 0%+36.14%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4135µs ± 0%161µs ± 0%+18.82%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4145µs ± 0%161µs ± 0%+11.05%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4149µs ± 0%173µs ± 0%+15.63%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4162µs ± 0%173µs ± 0%+6.81%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4212µs ± 0%234µs ± 0%+10.59%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-450.7µs ± 0%58.8µs ± 0%+16.09%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-449.9µs ± 0%56.6µs ± 0%+13.47%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-451.2µs ± 0%58.0µs ± 0%+13.28%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-458.5µs ± 0%64.8µs ± 0%+10.81%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-468.5µs ± 0%72.0µs ± 0%+5.13%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4387µs ± 0%438µs ± 0%+13.43%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4355µs ± 0%465µs ± 0%+31.07%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4380µs ± 0%420µs ± 0%+10.55%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4407µs ± 0%445µs ± 0%+9.20%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4504µs ± 0%529µs ± 0%+5.05%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-445.9µs ± 0%54.0µs ± 0%+17.58%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-445.2µs ± 0%59.6µs ± 0%+31.94%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-448.9µs ± 0%59.9µs ± 0%+22.61%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-456.7µs ± 0%63.3µs ± 0%+11.48%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-469.5µs ± 0%75.3µs ± 0%+8.29%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4364µs ± 0%494µs ± 0%+35.80%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4357µs ± 0%453µs ± 0%+26.92%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4368µs ± 0%501µs ± 0%+36.11%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4405µs ± 0%500µs ± 0%+23.44%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4519µs ± 0%561µs ± 0%+8.07%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4125µs ± 0%154µs ± 0%+23.17%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4125µs ± 0%147µs ± 0%+17.21%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4125µs ± 0%171µs ± 0%+37.10%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4130µs ± 0%173µs ± 0%+32.75%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4148µs ± 0%196µs ± 0%+32.80%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-41.20ms ± 0%1.34ms ± 0%+11.49%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-41.27ms ± 0%1.51ms ± 0%+19.05%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-41.27ms ± 0%1.33ms ± 0%+4.68%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-41.33ms ± 0%1.44ms ± 0%+8.14%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-41.38ms ± 0%1.67ms ± 0%+20.79%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4119µs ± 0%145µs ± 0%+22.02%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4119µs ± 0%145µs ± 0%+21.47%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4122µs ± 0%125µs ± 0%+2.41%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4125µs ± 0%136µs ± 0%+8.63%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4136µs ± 0%159µs ± 0%+17.38%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-41.17ms ± 0%1.22ms ± 0%+4.71%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-41.19ms ± 0%1.37ms ± 0%+14.92%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-41.21ms ± 0%1.25ms ± 0%+3.23%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-41.26ms ± 0%1.41ms ± 0%+12.04%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-41.39ms ± 0%1.69ms ± 0%+21.60%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-48.57µs ± 0%9.15µs ± 0%+6.67%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-48.88µs ± 0%10.83µs ± 0%+21.86%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-49.34µs ± 0%11.88µs ± 0%+27.17%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-410.8µs ± 0%13.3µs ± 0%+23.63%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-414.4µs ± 0%17.2µs ± 0%+19.73%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-486.6µs ± 0%105.0µs ± 0%+21.19%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-490.0µs ± 0%103.2µs ± 0%+14.61%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-4102µs ± 0%111µs ± 0%+9.07%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4117µs ± 0%136µs ± 0%+16.05%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4141µs ± 0%172µs ± 0%+21.68%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4124µs ± 0%126µs ± 0%+2.10%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4123µs ± 0%131µs ± 0%+7.05%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4127µs ± 0%133µs ± 0%+4.08%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4121µs ± 0%127µs ± 0%+4.86%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4127µs ± 0%139µs ± 0%+9.39%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-41.24ms ± 0%1.22ms ± 0%−1.57%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-41.22ms ± 0%1.30ms ± 0%+6.22%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-41.22ms ± 0%1.28ms ± 0%+4.96%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-41.23ms ± 0%1.27ms ± 0%+2.51%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-41.27ms ± 0%1.31ms ± 0%+3.12%(p=1.000 n=1+1)
 

@codecov
Copy link

codecov bot commented Apr 19, 2022 •
edited
Loading

Codecov Report

Merging #366 (ae2fcb0) into develop (deb2ffd) will decrease coverage by 0.00%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #366      +/-   ##
===========================================
- Coverage    64.99%   64.98%   -0.01%     
===========================================
  Files           80       80              
  Lines         9185     9183       -2     
===========================================
- Hits          5970     5968       -2     
+ Misses        2603     2602       -1     
- Partials       612      613       +1
Impacted Files Coverage Δ
query/graphql/schema/descriptions.go 85.61% <50.00%> (-0.11%) ⬇️
query/graphql/schema/generate.go 80.58% <100.00%> (-0.03%) ⬇️

@shahzadlone
Copy link
Member

conventional commit title will be like tools don't think we have a build label.

shahzadlone
shahzadlone reviewed Apr 20, 2022
View reviewed changes
Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@source-devs
Copy link

Benchmark Results

Summary

  • 113 Benchmarks successfully compared.
  • 97 Benchmarks were ✅ Better.
  • 16 Benchmarks were ❌ Worse .
  • 0 Benchmarks were ✨ Unchanged.
✅ See Better Results...
time/opdelta
_Collection_UserSimple_CreateMany_Sync_0_100-4230ms ± 0%223ms ± 0%−3.17%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_100-499.3ms ± 0%98.2ms ± 0%−1.16%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_1000-41.02s ± 0%1.00s ± 0%−2.65%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-446.0ms ± 0%45.1ms ± 0%−2.00%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_1000-4449ms ± 0%448ms ± 0%−0.19%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-44.63s ± 0%4.57s ± 0%−1.23%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4352µs ± 0%339µs ± 0%−3.61%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_100_100-43.95ms ± 0%3.49ms ± 0%−11.52%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_1000-440.4ms ± 0%38.1ms ± 0%−5.71%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4370µs ± 0%335µs ± 0%−9.55%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-43.94ms ± 0%3.85ms ± 0%−2.24%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_10_10-4254µs ± 0%247µs ± 0%−2.74%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-41.86ms ± 0%1.75ms ± 0%−5.48%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-424.6ms ± 0%23.5ms ± 0%−4.53%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4257µs ± 0%256µs ± 0%−0.52%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-41.14ms ± 0%1.13ms ± 0%−1.04%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_1000-49.69ms ± 0%9.32ms ± 0%−3.83%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4417µs ± 0%408µs ± 0%−2.00%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-41.27ms ± 0%1.25ms ± 0%−0.94%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-410.1ms ± 0%9.7ms ± 0%−4.08%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4381µs ± 0%369µs ± 0%−3.22%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4432µs ± 0%427µs ± 0%−1.25%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4433µs ± 0%423µs ± 0%−2.23%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-4735µs ± 0%635µs ± 0%−13.58%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4770µs ± 0%620µs ± 0%−19.51%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4662µs ± 0%633µs ± 0%−4.38%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4288µs ± 0%273µs ± 0%−5.42%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4287µs ± 0%273µs ± 0%−4.85%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4286µs ± 0%271µs ± 0%−4.94%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4443µs ± 0%409µs ± 0%−7.81%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-41.53ms ± 0%1.36ms ± 0%−10.92%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-412.5ms ± 0%12.4ms ± 0%−0.99%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-413.9µs ± 0%13.2µs ± 0%−5.08%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-415.6µs ± 0%13.7µs ± 0%−12.45%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-415.8µs ± 0%15.2µs ± 0%−3.89%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-419.4µs ± 0%19.2µs ± 0%−0.87%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4135µs ± 0%133µs ± 0%−1.96%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4142µs ± 0%137µs ± 0%−3.54%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4157µs ± 0%156µs ± 0%−0.31%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-414.7µs ± 0%14.4µs ± 0%−2.64%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-415.2µs ± 0%14.7µs ± 0%−3.52%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-415.5µs ± 0%15.1µs ± 0%−2.96%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-418.4µs ± 0%17.0µs ± 0%−7.72%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-422.8µs ± 0%20.9µs ± 0%−8.44%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4135µs ± 0%130µs ± 0%−3.78%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4145µs ± 0%139µs ± 0%−4.01%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4149µs ± 0%147µs ± 0%−1.40%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4162µs ± 0%159µs ± 0%−2.11%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4212µs ± 0%202µs ± 0%−4.61%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-450.7µs ± 0%44.0µs ± 0%−13.14%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-449.9µs ± 0%44.5µs ± 0%−10.74%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-451.2µs ± 0%48.5µs ± 0%−5.28%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-458.5µs ± 0%53.5µs ± 0%−8.54%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-468.5µs ± 0%66.8µs ± 0%−2.49%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4387µs ± 0%345µs ± 0%−10.71%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4355µs ± 0%350µs ± 0%−1.25%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4380µs ± 0%374µs ± 0%−1.57%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4504µs ± 0%492µs ± 0%−2.38%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-445.9µs ± 0%43.7µs ± 0%−4.80%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-445.2µs ± 0%44.7µs ± 0%−1.08%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-448.9µs ± 0%47.5µs ± 0%−2.73%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-456.7µs ± 0%53.9µs ± 0%−5.02%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-469.5µs ± 0%68.5µs ± 0%−1.51%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4364µs ± 0%349µs ± 0%−3.96%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4357µs ± 0%342µs ± 0%−4.02%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4368µs ± 0%359µs ± 0%−2.27%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4405µs ± 0%404µs ± 0%−0.33%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4125µs ± 0%115µs ± 0%−7.72%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4125µs ± 0%120µs ± 0%−4.31%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4125µs ± 0%124µs ± 0%−0.28%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4130µs ± 0%129µs ± 0%−1.21%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4148µs ± 0%141µs ± 0%−4.47%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-41.27ms ± 0%1.21ms ± 0%−4.44%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-41.27ms ± 0%1.23ms ± 0%−3.86%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-41.33ms ± 0%1.26ms ± 0%−5.79%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4119µs ± 0%113µs ± 0%−4.78%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4119µs ± 0%116µs ± 0%−3.14%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4122µs ± 0%117µs ± 0%−4.39%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4125µs ± 0%121µs ± 0%−3.65%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4136µs ± 0%135µs ± 0%−0.67%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-41.17ms ± 0%1.16ms ± 0%−0.50%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-41.19ms ± 0%1.18ms ± 0%−1.44%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-41.21ms ± 0%1.21ms ± 0%−0.25%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-41.26ms ± 0%1.21ms ± 0%−4.24%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-41.39ms ± 0%1.34ms ± 0%−3.40%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-48.88µs ± 0%8.85µs ± 0%−0.34%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-49.34µs ± 0%9.32µs ± 0%−0.26%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-4102µs ± 0%102µs ± 0%−0.38%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4117µs ± 0%117µs ± 0%−0.18%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4124µs ± 0%121µs ± 0%−2.38%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4123µs ± 0%121µs ± 0%−0.88%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4127µs ± 0%118µs ± 0%−7.15%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4121µs ± 0%120µs ± 0%−0.99%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4127µs ± 0%127µs ± 0%−0.36%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-41.24ms ± 0%1.19ms ± 0%−3.94%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-41.22ms ± 0%1.21ms ± 0%−1.53%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-41.27ms ± 0%1.19ms ± 0%−6.48%(p=1.000 n=1+1)
 
❌ See Worse Results...
time/opdelta
_Collection_UserSimple_Create_Sync_0_10-49.77ms ± 0%10.31ms ± 0%+5.57%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-41.82ms ± 0%1.83ms ± 0%+0.41%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4135µs ± 0%136µs ± 0%+1.36%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4195µs ± 0%196µs ± 0%+0.28%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4407µs ± 0%412µs ± 0%+1.23%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4519µs ± 0%523µs ± 0%+0.65%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-41.20ms ± 0%1.22ms ± 0%+1.20%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-41.38ms ± 0%1.45ms ± 0%+4.78%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-48.57µs ± 0%8.58µs ± 0%+0.09%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-410.8µs ± 0%11.3µs ± 0%+5.16%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-414.4µs ± 0%15.4µs ± 0%+7.27%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-486.6µs ± 0%93.8µs ± 0%+8.26%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-490.0µs ± 0%95.6µs ± 0%+6.17%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4141µs ± 0%172µs ± 0%+22.07%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-41.22ms ± 0%1.24ms ± 0%+1.40%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-41.23ms ± 0%1.27ms ± 0%+2.55%(p=1.000 n=1+1)
 
✨ See Unchanged Results...
time/opdelta
 
🐋 See Full Results...
develop.txtcurrent.txt
time/opdelta
pkg:github.com/sourcenetwork/defradb/bench/collection goos:linux goarch:amd64
_Collection_UserSimple_CreateMany_Sync_0_10-412.2ms ± 0%11.1ms ± 0%−8.98%(p=1.000 n=1+1)
_Collection_UserSimple_CreateMany_Sync_0_100-4230ms ± 0%223ms ± 0%−3.17%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_10-49.77ms ± 0%10.31ms ± 0%+5.57%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_100-499.3ms ± 0%98.2ms ± 0%−1.16%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_1000-41.02s ± 0%1.00s ± 0%−2.65%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-446.0ms ± 0%45.1ms ± 0%−2.00%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_1000-4449ms ± 0%448ms ± 0%−0.19%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-44.63s ± 0%4.57s ± 0%−1.23%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4352µs ± 0%339µs ± 0%−3.61%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_100_100-43.95ms ± 0%3.49ms ± 0%−11.52%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_1000-440.4ms ± 0%38.1ms ± 0%−5.71%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4370µs ± 0%335µs ± 0%−9.55%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-43.94ms ± 0%3.85ms ± 0%−2.24%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_10_10-4254µs ± 0%247µs ± 0%−2.74%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-41.86ms ± 0%1.75ms ± 0%−5.48%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-424.6ms ± 0%23.5ms ± 0%−4.53%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4257µs ± 0%256µs ± 0%−0.52%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-41.82ms ± 0%1.83ms ± 0%+0.41%(p=1.000 n=1+1)
pkg:github.com/sourcenetwork/defradb/bench/query/simple goos:linux goarch:amd64
_Query_UserSimple_Query_Sync_10-4349µs ± 0%331µs ± 0%−5.24%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-41.14ms ± 0%1.13ms ± 0%−1.04%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_1000-49.69ms ± 0%9.32ms ± 0%−3.83%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4417µs ± 0%408µs ± 0%−2.00%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-41.27ms ± 0%1.25ms ± 0%−0.94%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-410.1ms ± 0%9.7ms ± 0%−4.08%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4381µs ± 0%369µs ± 0%−3.22%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4432µs ± 0%427µs ± 0%−1.25%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4433µs ± 0%423µs ± 0%−2.23%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-4735µs ± 0%635µs ± 0%−13.58%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4770µs ± 0%620µs ± 0%−19.51%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4662µs ± 0%633µs ± 0%−4.38%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4288µs ± 0%273µs ± 0%−5.42%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4287µs ± 0%273µs ± 0%−4.85%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4286µs ± 0%271µs ± 0%−4.94%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4443µs ± 0%409µs ± 0%−7.81%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-41.53ms ± 0%1.36ms ± 0%−10.92%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-412.5ms ± 0%12.4ms ± 0%−0.99%(p=1.000 n=1+1)
pkg:github.com/sourcenetwork/defradb/bench/storage goos:linux goarch:amd64
_Storage_Simple_Read_Sync_1_10/ValueSize:0064-412.6µs ± 0%12.5µs ± 0%−1.02%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-413.9µs ± 0%13.2µs ± 0%−5.08%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-415.6µs ± 0%13.7µs ± 0%−12.45%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-415.8µs ± 0%15.2µs ± 0%−3.89%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-419.4µs ± 0%19.2µs ± 0%−0.87%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4135µs ± 0%136µs ± 0%+1.36%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4135µs ± 0%133µs ± 0%−1.96%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4142µs ± 0%137µs ± 0%−3.54%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4157µs ± 0%156µs ± 0%−0.31%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4195µs ± 0%196µs ± 0%+0.28%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-414.7µs ± 0%14.4µs ± 0%−2.64%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-415.2µs ± 0%14.7µs ± 0%−3.52%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-415.5µs ± 0%15.1µs ± 0%−2.96%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-418.4µs ± 0%17.0µs ± 0%−7.72%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-422.8µs ± 0%20.9µs ± 0%−8.44%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4135µs ± 0%130µs ± 0%−3.78%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4145µs ± 0%139µs ± 0%−4.01%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4149µs ± 0%147µs ± 0%−1.40%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4162µs ± 0%159µs ± 0%−2.11%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4212µs ± 0%202µs ± 0%−4.61%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-450.7µs ± 0%44.0µs ± 0%−13.14%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-449.9µs ± 0%44.5µs ± 0%−10.74%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-451.2µs ± 0%48.5µs ± 0%−5.28%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-458.5µs ± 0%53.5µs ± 0%−8.54%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-468.5µs ± 0%66.8µs ± 0%−2.49%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4387µs ± 0%345µs ± 0%−10.71%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4355µs ± 0%350µs ± 0%−1.25%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4380µs ± 0%374µs ± 0%−1.57%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4407µs ± 0%412µs ± 0%+1.23%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4504µs ± 0%492µs ± 0%−2.38%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-445.9µs ± 0%43.7µs ± 0%−4.80%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-445.2µs ± 0%44.7µs ± 0%−1.08%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-448.9µs ± 0%47.5µs ± 0%−2.73%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-456.7µs ± 0%53.9µs ± 0%−5.02%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-469.5µs ± 0%68.5µs ± 0%−1.51%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4364µs ± 0%349µs ± 0%−3.96%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4357µs ± 0%342µs ± 0%−4.02%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4368µs ± 0%359µs ± 0%−2.27%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4405µs ± 0%404µs ± 0%−0.33%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4519µs ± 0%523µs ± 0%+0.65%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4125µs ± 0%115µs ± 0%−7.72%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4125µs ± 0%120µs ± 0%−4.31%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4125µs ± 0%124µs ± 0%−0.28%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4130µs ± 0%129µs ± 0%−1.21%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4148µs ± 0%141µs ± 0%−4.47%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-41.20ms ± 0%1.22ms ± 0%+1.20%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-41.27ms ± 0%1.21ms ± 0%−4.44%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-41.27ms ± 0%1.23ms ± 0%−3.86%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-41.33ms ± 0%1.26ms ± 0%−5.79%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-41.38ms ± 0%1.45ms ± 0%+4.78%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4119µs ± 0%113µs ± 0%−4.78%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4119µs ± 0%116µs ± 0%−3.14%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4122µs ± 0%117µs ± 0%−4.39%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4125µs ± 0%121µs ± 0%−3.65%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4136µs ± 0%135µs ± 0%−0.67%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-41.17ms ± 0%1.16ms ± 0%−0.50%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-41.19ms ± 0%1.18ms ± 0%−1.44%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-41.21ms ± 0%1.21ms ± 0%−0.25%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-41.26ms ± 0%1.21ms ± 0%−4.24%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-41.39ms ± 0%1.34ms ± 0%−3.40%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-48.57µs ± 0%8.58µs ± 0%+0.09%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-48.88µs ± 0%8.85µs ± 0%−0.34%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-49.34µs ± 0%9.32µs ± 0%−0.26%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-410.8µs ± 0%11.3µs ± 0%+5.16%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-414.4µs ± 0%15.4µs ± 0%+7.27%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-486.6µs ± 0%93.8µs ± 0%+8.26%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-490.0µs ± 0%95.6µs ± 0%+6.17%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-4102µs ± 0%102µs ± 0%−0.38%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4117µs ± 0%117µs ± 0%−0.18%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4141µs ± 0%172µs ± 0%+22.07%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4124µs ± 0%121µs ± 0%−2.38%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4123µs ± 0%121µs ± 0%−0.88%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4127µs ± 0%118µs ± 0%−7.15%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4121µs ± 0%120µs ± 0%−0.99%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4127µs ± 0%127µs ± 0%−0.36%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-41.24ms ± 0%1.19ms ± 0%−3.94%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-41.22ms ± 0%1.21ms ± 0%−1.53%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-41.22ms ± 0%1.24ms ± 0%+1.40%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-41.23ms ± 0%1.27ms ± 0%+2.55%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-41.27ms ± 0%1.19ms ± 0%−6.48%(p=1.000 n=1+1)
 

@AndrewSisley AndrewSisley merged commit 726d0d3 into develop Apr 20, 2022
@AndrewSisley AndrewSisley deleted the sisley/build/I364-else-ban branch April 20, 2022 03:18
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@AndrewSisley
build: Ban extra elses (sourcenetwork#366)
d951809 
* Add superfluous-else rule to revive linter

* Remove default revive linter rules

Do not want to enable these now

* Remove extra else from CreateDescriptions

If also inverted as it clarifies that the error is secondary to the continue

* Remove extra else from generate code

* Enable revive linter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzadlone shahzadlone shahzadlone approved these changes

@orpheuslummis orpheuslummis Awaiting requested review from orpheuslummis

@jsimnz jsimnz Awaiting requested review from jsimnz

@fredcarle fredcarle Awaiting requested review from fredcarle

Assignees

@AndrewSisley AndrewSisley

Labels
ci/build This is issue is about the build or CI system, and the administration of it. code quality Related to improving code quality
Projects
None yet
Milestone
DefraDB v0.3
Development

Successfully merging this pull request may close these issues.

Ban 'extra' else conditions
3 participants
@AndrewSisley @source-devs @shahzadlone