Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: Add the gofmt linter rule. #405

Merged
merged 2 commits into from
May 5, 2022
Merged

tools: Add the gofmt linter rule. #405

merged 2 commits into from
May 5, 2022

Conversation

shahzadlone
Copy link
Member

RELATED ISSUE(S):

Resolves #404

DESCRIPTION:

Adds the linter gofmt to ensure we have gofmt ran on all the go files (as sometimes if an IDE or text editor's gofmt is tripping up or disabled).

@shahzadlone shahzadlone added this to the DefraDB v0.3 milestone May 5, 2022
@shahzadlone shahzadlone self-assigned this May 5, 2022
@shahzadlone shahzadlone added the code quality Related to improving code quality label May 5, 2022
@source-devs
Copy link

Benchmark Results

Summary

  • 113 Benchmarks successfully compared.
  • 34 Benchmarks were ✅ Better.
  • 79 Benchmarks were ❌ Worse .
  • 0 Benchmarks were ✨ Unchanged.
✅ See Better Results...
time/opdelta
_Collection_UserSimple_CreateMany_Sync_0_100-4265ms ± 0%261ms ± 0%−1.19%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_10-412.6ms ± 0%11.8ms ± 0%−6.41%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_100-4126ms ± 0%112ms ± 0%−10.72%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-449.2ms ± 0%47.5ms ± 0%−3.65%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_1000-4475ms ± 0%458ms ± 0%−3.71%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-44.84s ± 0%4.67s ± 0%−3.56%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_100_100-44.54ms ± 0%4.09ms ± 0%−9.83%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_1000-440.9ms ± 0%38.8ms ± 0%−5.08%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4390µs ± 0%361µs ± 0%−7.48%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-44.03ms ± 0%3.95ms ± 0%−2.06%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-41.85ms ± 0%1.85ms ± 0%−0.24%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-424.4ms ± 0%24.4ms ± 0%−0.26%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4259µs ± 0%252µs ± 0%−2.88%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-41.91ms ± 0%1.84ms ± 0%−3.74%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4470µs ± 0%448µs ± 0%−4.59%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4531µs ± 0%502µs ± 0%−5.44%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4478µs ± 0%442µs ± 0%−7.70%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4711µs ± 0%679µs ± 0%−4.54%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4321µs ± 0%304µs ± 0%−5.39%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4342µs ± 0%312µs ± 0%−8.77%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4182µs ± 0%175µs ± 0%−3.49%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-417.1µs ± 0%16.9µs ± 0%−1.38%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-417.4µs ± 0%16.1µs ± 0%−7.55%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-419.0µs ± 0%17.2µs ± 0%−9.72%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4161µs ± 0%153µs ± 0%−5.00%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4186µs ± 0%175µs ± 0%−5.83%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4220µs ± 0%191µs ± 0%−12.99%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4248µs ± 0%222µs ± 0%−10.32%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4168µs ± 0%163µs ± 0%−2.75%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-41.41ms ± 0%1.35ms ± 0%−4.73%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4119µs ± 0%119µs ± 0%−0.09%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-41.44ms ± 0%1.26ms ± 0%−12.50%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-41.40ms ± 0%1.35ms ± 0%−3.75%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-41.35ms ± 0%1.33ms ± 0%−1.11%(p=1.000 n=1+1)
 
❌ See Worse Results...
time/opdelta
_Collection_UserSimple_Create_Sync_0_1000-41.15s ± 0%1.15s ± 0%+0.12%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4394µs ± 0%423µs ± 0%+7.47%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_10_10-4289µs ± 0%308µs ± 0%+6.27%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-41.25ms ± 0%1.47ms ± 0%+18.03%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_1000-49.75ms ± 0%9.80ms ± 0%+0.51%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4482µs ± 0%483µs ± 0%+0.06%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-41.31ms ± 0%1.41ms ± 0%+7.27%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-410.2ms ± 0%10.3ms ± 0%+0.73%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-4710µs ± 0%759µs ± 0%+7.02%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4656µs ± 0%659µs ± 0%+0.45%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4277µs ± 0%292µs ± 0%+5.58%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4484µs ± 0%582µs ± 0%+20.23%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-41.47ms ± 0%1.84ms ± 0%+25.58%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-412.3ms ± 0%14.0ms ± 0%+13.11%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-414.9µs ± 0%16.9µs ± 0%+13.54%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-414.0µs ± 0%18.1µs ± 0%+29.56%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-417.6µs ± 0%19.0µs ± 0%+8.06%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-420.2µs ± 0%24.3µs ± 0%+20.42%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4148µs ± 0%158µs ± 0%+6.70%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4136µs ± 0%174µs ± 0%+28.09%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4148µs ± 0%175µs ± 0%+18.29%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4211µs ± 0%222µs ± 0%+5.41%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-415.7µs ± 0%16.9µs ± 0%+7.45%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-424.0µs ± 0%25.6µs ± 0%+6.65%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4170µs ± 0%172µs ± 0%+1.23%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-448.3µs ± 0%61.6µs ± 0%+27.54%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-454.9µs ± 0%56.5µs ± 0%+2.96%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-456.8µs ± 0%73.9µs ± 0%+30.08%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-463.9µs ± 0%69.7µs ± 0%+9.15%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-476.9µs ± 0%80.5µs ± 0%+4.71%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4364µs ± 0%515µs ± 0%+41.57%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4392µs ± 0%472µs ± 0%+20.24%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4389µs ± 0%448µs ± 0%+15.14%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4428µs ± 0%482µs ± 0%+12.64%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4526µs ± 0%578µs ± 0%+10.01%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-444.4µs ± 0%55.2µs ± 0%+24.37%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-449.4µs ± 0%65.7µs ± 0%+33.07%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-449.4µs ± 0%64.5µs ± 0%+30.57%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-456.2µs ± 0%75.1µs ± 0%+33.73%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-471.0µs ± 0%105.3µs ± 0%+48.26%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4354µs ± 0%477µs ± 0%+34.98%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4383µs ± 0%442µs ± 0%+15.45%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4422µs ± 0%461µs ± 0%+9.11%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4450µs ± 0%500µs ± 0%+11.15%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4579µs ± 0%600µs ± 0%+3.65%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4117µs ± 0%154µs ± 0%+32.05%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4123µs ± 0%161µs ± 0%+31.26%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4127µs ± 0%144µs ± 0%+13.40%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4138µs ± 0%146µs ± 0%+5.33%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-41.35ms ± 0%1.44ms ± 0%+7.13%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-41.45ms ± 0%1.58ms ± 0%+9.17%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-41.32ms ± 0%1.44ms ± 0%+9.03%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-41.41ms ± 0%1.77ms ± 0%+25.01%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4117µs ± 0%137µs ± 0%+16.27%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4128µs ± 0%146µs ± 0%+13.42%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4124µs ± 0%146µs ± 0%+17.48%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4136µs ± 0%150µs ± 0%+10.13%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-41.30ms ± 0%1.31ms ± 0%+0.65%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-41.22ms ± 0%1.29ms ± 0%+5.34%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-41.21ms ± 0%1.36ms ± 0%+12.14%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-41.28ms ± 0%1.41ms ± 0%+10.18%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-41.45ms ± 0%1.59ms ± 0%+9.89%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-48.66µs ± 0%9.47µs ± 0%+9.38%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-48.68µs ± 0%10.78µs ± 0%+24.25%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-410.1µs ± 0%11.3µs ± 0%+11.73%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-412.5µs ± 0%13.3µs ± 0%+6.44%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-415.8µs ± 0%18.3µs ± 0%+16.46%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-494.6µs ± 0%108.4µs ± 0%+14.60%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-498.8µs ± 0%118.4µs ± 0%+19.83%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-4105µs ± 0%145µs ± 0%+37.88%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4126µs ± 0%161µs ± 0%+28.34%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4165µs ± 0%216µs ± 0%+31.07%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4129µs ± 0%140µs ± 0%+9.04%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4129µs ± 0%136µs ± 0%+5.22%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4130µs ± 0%145µs ± 0%+11.43%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4132µs ± 0%140µs ± 0%+5.53%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4139µs ± 0%145µs ± 0%+4.72%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-41.23ms ± 0%1.32ms ± 0%+7.41%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-41.25ms ± 0%1.36ms ± 0%+8.30%(p=1.000 n=1+1)
 
✨ See Unchanged Results...
time/opdelta
 
🐋 See Full Results...
develop.txtcurrent.txt
time/opdelta
pkg:github.com/sourcenetwork/defradb/bench/collection goos:linux goarch:amd64
_Collection_UserSimple_CreateMany_Sync_0_10-411.2ms ± 0%10.9ms ± 0%−2.55%(p=1.000 n=1+1)
_Collection_UserSimple_CreateMany_Sync_0_100-4265ms ± 0%261ms ± 0%−1.19%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_10-412.6ms ± 0%11.8ms ± 0%−6.41%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_100-4126ms ± 0%112ms ± 0%−10.72%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_1000-41.15s ± 0%1.15s ± 0%+0.12%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-449.2ms ± 0%47.5ms ± 0%−3.65%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_1000-4475ms ± 0%458ms ± 0%−3.71%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-44.84s ± 0%4.67s ± 0%−3.56%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4394µs ± 0%423µs ± 0%+7.47%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_100_100-44.54ms ± 0%4.09ms ± 0%−9.83%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_1000-440.9ms ± 0%38.8ms ± 0%−5.08%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4390µs ± 0%361µs ± 0%−7.48%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-44.03ms ± 0%3.95ms ± 0%−2.06%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_10_10-4289µs ± 0%308µs ± 0%+6.27%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-41.85ms ± 0%1.85ms ± 0%−0.24%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-424.4ms ± 0%24.4ms ± 0%−0.26%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4259µs ± 0%252µs ± 0%−2.88%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-41.91ms ± 0%1.84ms ± 0%−3.74%(p=1.000 n=1+1)
pkg:github.com/sourcenetwork/defradb/bench/query/simple goos:linux goarch:amd64
_Query_UserSimple_Query_Sync_10-4370µs ± 0%348µs ± 0%−6.06%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-41.25ms ± 0%1.47ms ± 0%+18.03%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_1000-49.75ms ± 0%9.80ms ± 0%+0.51%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4482µs ± 0%483µs ± 0%+0.06%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-41.31ms ± 0%1.41ms ± 0%+7.27%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-410.2ms ± 0%10.3ms ± 0%+0.73%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4470µs ± 0%448µs ± 0%−4.59%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4531µs ± 0%502µs ± 0%−5.44%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4478µs ± 0%442µs ± 0%−7.70%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-4710µs ± 0%759µs ± 0%+7.02%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4711µs ± 0%679µs ± 0%−4.54%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4656µs ± 0%659µs ± 0%+0.45%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4321µs ± 0%304µs ± 0%−5.39%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4342µs ± 0%312µs ± 0%−8.77%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4277µs ± 0%292µs ± 0%+5.58%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4484µs ± 0%582µs ± 0%+20.23%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-41.47ms ± 0%1.84ms ± 0%+25.58%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-412.3ms ± 0%14.0ms ± 0%+13.11%(p=1.000 n=1+1)
pkg:github.com/sourcenetwork/defradb/bench/storage goos:linux goarch:amd64
_Storage_Simple_Read_Sync_1_10/ValueSize:0064-414.1µs ± 0%18.9µs ± 0%+34.24%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-414.9µs ± 0%16.9µs ± 0%+13.54%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-414.0µs ± 0%18.1µs ± 0%+29.56%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-417.6µs ± 0%19.0µs ± 0%+8.06%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-420.2µs ± 0%24.3µs ± 0%+20.42%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4148µs ± 0%158µs ± 0%+6.70%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4136µs ± 0%174µs ± 0%+28.09%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4148µs ± 0%175µs ± 0%+18.29%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4182µs ± 0%175µs ± 0%−3.49%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4211µs ± 0%222µs ± 0%+5.41%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-417.1µs ± 0%16.9µs ± 0%−1.38%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-417.4µs ± 0%16.1µs ± 0%−7.55%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-415.7µs ± 0%16.9µs ± 0%+7.45%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-419.0µs ± 0%17.2µs ± 0%−9.72%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-424.0µs ± 0%25.6µs ± 0%+6.65%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4161µs ± 0%153µs ± 0%−5.00%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4170µs ± 0%172µs ± 0%+1.23%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4186µs ± 0%175µs ± 0%−5.83%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4220µs ± 0%191µs ± 0%−12.99%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4248µs ± 0%222µs ± 0%−10.32%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-448.3µs ± 0%61.6µs ± 0%+27.54%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-454.9µs ± 0%56.5µs ± 0%+2.96%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-456.8µs ± 0%73.9µs ± 0%+30.08%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-463.9µs ± 0%69.7µs ± 0%+9.15%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-476.9µs ± 0%80.5µs ± 0%+4.71%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4364µs ± 0%515µs ± 0%+41.57%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4392µs ± 0%472µs ± 0%+20.24%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4389µs ± 0%448µs ± 0%+15.14%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4428µs ± 0%482µs ± 0%+12.64%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4526µs ± 0%578µs ± 0%+10.01%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-444.4µs ± 0%55.2µs ± 0%+24.37%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-449.4µs ± 0%65.7µs ± 0%+33.07%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-449.4µs ± 0%64.5µs ± 0%+30.57%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-456.2µs ± 0%75.1µs ± 0%+33.73%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-471.0µs ± 0%105.3µs ± 0%+48.26%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4354µs ± 0%477µs ± 0%+34.98%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4383µs ± 0%442µs ± 0%+15.45%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4422µs ± 0%461µs ± 0%+9.11%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4450µs ± 0%500µs ± 0%+11.15%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4579µs ± 0%600µs ± 0%+3.65%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4117µs ± 0%154µs ± 0%+32.05%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4123µs ± 0%161µs ± 0%+31.26%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4127µs ± 0%144µs ± 0%+13.40%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4138µs ± 0%146µs ± 0%+5.33%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4168µs ± 0%163µs ± 0%−2.75%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-41.35ms ± 0%1.44ms ± 0%+7.13%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-41.45ms ± 0%1.58ms ± 0%+9.17%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-41.41ms ± 0%1.35ms ± 0%−4.73%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-41.32ms ± 0%1.44ms ± 0%+9.03%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-41.41ms ± 0%1.77ms ± 0%+25.01%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4119µs ± 0%119µs ± 0%−0.09%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4117µs ± 0%137µs ± 0%+16.27%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4128µs ± 0%146µs ± 0%+13.42%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4124µs ± 0%146µs ± 0%+17.48%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4136µs ± 0%150µs ± 0%+10.13%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-41.30ms ± 0%1.31ms ± 0%+0.65%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-41.22ms ± 0%1.29ms ± 0%+5.34%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-41.21ms ± 0%1.36ms ± 0%+12.14%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-41.28ms ± 0%1.41ms ± 0%+10.18%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-41.45ms ± 0%1.59ms ± 0%+9.89%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-48.66µs ± 0%9.47µs ± 0%+9.38%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-48.68µs ± 0%10.78µs ± 0%+24.25%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-410.1µs ± 0%11.3µs ± 0%+11.73%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-412.5µs ± 0%13.3µs ± 0%+6.44%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-415.8µs ± 0%18.3µs ± 0%+16.46%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-494.6µs ± 0%108.4µs ± 0%+14.60%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-498.8µs ± 0%118.4µs ± 0%+19.83%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-4105µs ± 0%145µs ± 0%+37.88%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4126µs ± 0%161µs ± 0%+28.34%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4165µs ± 0%216µs ± 0%+31.07%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4129µs ± 0%140µs ± 0%+9.04%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4129µs ± 0%136µs ± 0%+5.22%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4130µs ± 0%145µs ± 0%+11.43%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4132µs ± 0%140µs ± 0%+5.53%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4139µs ± 0%145µs ± 0%+4.72%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-41.23ms ± 0%1.32ms ± 0%+7.41%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-41.25ms ± 0%1.36ms ± 0%+8.30%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-41.44ms ± 0%1.26ms ± 0%−12.50%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-41.40ms ± 0%1.35ms ± 0%−3.75%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-41.35ms ± 0%1.33ms ± 0%−1.11%(p=1.000 n=1+1)
 

orpheuslummis
orpheuslummis approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@orpheuslummis orpheuslummis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzadlone shahzadlone force-pushed the lone/tools/enable-check-for-gofmt branch from 05ee164 to 38f79f0 Compare May 5, 2022 23:36
@shahzadlone shahzadlone added the action/no-benchmark Skips the action that runs the benchmark. label May 5, 2022
@shahzadlone shahzadlone merged commit 6bbf7cf into develop May 5, 2022
@shahzadlone shahzadlone deleted the lone/tools/enable-check-for-gofmt branch May 5, 2022 23:42
@shahzadlone shahzadlone restored the lone/tools/enable-check-for-gofmt branch May 5, 2022 23:44
shahzadlone added a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@shahzadlone
tools: Add the gofmt linter rule. (sourcenetwork#405)
0dc85d5 
- RELATED ISSUE(S):
Resolves sourcenetwork#404

- DESCRIPTION:
Adds the linter gofmt rule to ensure have gofmt ran on all the go files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orpheuslummis orpheuslummis orpheuslummis approved these changes

@fredcarle fredcarle fredcarle approved these changes

@AndrewSisley AndrewSisley AndrewSisley approved these changes

@jsimnz jsimnz Awaiting requested review from jsimnz

Assignees

@shahzadlone shahzadlone

Labels
action/no-benchmark Skips the action that runs the benchmark. code quality Related to improving code quality
Projects
None yet
Milestone
DefraDB v0.3
Development

Successfully merging this pull request may close these issues.

Lint: Enable the gofmt linter
5 participants
@shahzadlone @source-devs @orpheuslummis @fredcarle @AndrewSisley