refactor: Remove all errors.Wrap and update them with fmt.Errorf.
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsimnz
requested changes
Nov 16, 2021
jsimnz
changed the title
errors.Wrap and update them with fmt.Errorf.errors.Wrap and update them with fmt.Errorf.
jsimnz
approved these changes
Nov 16, 2021
jsimnz
deleted the
lone/refactor/issue-36-convert-all-old-error-wraps
branch
jsimnz
restored the
lone/refactor/issue-36-convert-all-old-error-wraps
branch
shahzadlone
deleted the
lone/refactor/issue-36-convert-all-old-error-wraps
branch
Closed
shahzadlone
added a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…sourcenetwork#41) * Remove all `errors.Wrap` and update them with `fmt.Errorf`. * Fix the missing error wrap in the formatting. * Fixing the `pkg/errors` to `errors` * Fix the errors.Errorf to fmt.Errorf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes all
errors.Wraps tofmt.Errorfs.TODO:
In the next PR (Separate Issue) incorporate the error linter to watch that we always wrap our errors, and compare errors properly through out the code base.