Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: Disable auto-fixing linter issues by default #429

Merged
merged 1 commit into from
May 11, 2022
Merged

tools: Disable auto-fixing linter issues by default #429

merged 1 commit into from
May 11, 2022

Conversation

shahzadlone
Copy link
Member

@shahzadlone shahzadlone commented May 9, 2022 •
edited
Loading

RELATED ISSUES(S):

Resolves #428

DESCRIPTION:

  • Changes make lint to be a read-only lint operation.
  • Adds a make lint:fix rule to do auto-fixing using linters.

@shahzadlone shahzadlone added the code quality Related to improving code quality label May 9, 2022
@shahzadlone shahzadlone added this to the DefraDB v0.3 milestone May 9, 2022
@shahzadlone shahzadlone self-assigned this May 9, 2022
@source-devs

This comment was marked as off-topic.

Sign in to view
@shahzadlone shahzadlone added the action/no-benchmark Skips the action that runs the benchmark. label May 9, 2022
AndrewSisley
AndrewSisley approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cheers - consider checking with the others though first as I dont know if anyone else will have seen the last comments between us in convo in the other ticket

@orpheuslummis
Copy link
Contributor

itd be nice to have it in vscode in addition to gofmt on save.

@shahzadlone
Copy link
Member Author

itd be nice to have it in vscode in addition to gofmt on save.

Not sure I follow. Are you suggesting to have editors run gofmt on save? In that case totally agree I have that already in my vim configs and think others do too. However could be a personal preference as some people might like a different flow for writing code? In any case our linter check will ensure that the code is properly gofmted =)

@shahzadlone shahzadlone merged commit 896602a into develop May 11, 2022
@shahzadlone shahzadlone deleted the lone/tools/turn-off-linter-auto-fix branch May 11, 2022 08:48
shahzadlone added a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@shahzadlone
tools: Disable auto-fixing linter issues by default (sourcenetwork#429)
a587f57 
* RELATED ISSUES(S):
Resolves sourcenetwork#428 

* DESCRIPTION:
- Changes `make lint` to be a read-only lint operation.
- Adds a `make lint:fix` rule to do auto-fixing using linters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewSisley AndrewSisley AndrewSisley approved these changes

@orpheuslummis orpheuslummis orpheuslummis approved these changes

@jsimnz jsimnz Awaiting requested review from jsimnz

@fredcarle fredcarle Awaiting requested review from fredcarle

Assignees

@shahzadlone shahzadlone

Labels
action/no-benchmark Skips the action that runs the benchmark. code quality Related to improving code quality
Projects
None yet
Milestone
DefraDB v0.3
Development

Successfully merging this pull request may close these issues.

Turn linters autofixing (write) off by default
4 participants
@shahzadlone @source-devs @orpheuslummis @AndrewSisley