Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update go-ipfs-blockstore and ipfs-lite #436

Merged
merged 1 commit into from
May 12, 2022
Merged

chore: Update go-ipfs-blockstore and ipfs-lite #436

merged 1 commit into from
May 12, 2022

Conversation

orpheuslummis
Copy link
Contributor

@orpheuslummis orpheuslummis commented May 12, 2022 •
edited
Loading

Part of #317

Bringing a few dependencies from the IPFS up-to-date and fixing little unexpected breaking changes along the way.

@orpheuslummis orpheuslummis added action/no-benchmark Skips the action that runs the benchmark. dependencies Related to dependencies labels May 12, 2022
@orpheuslummis orpheuslummis added this to the DefraDB v0.3 milestone May 12, 2022
@orpheuslummis orpheuslummis self-assigned this May 12, 2022
@orpheuslummis orpheuslummis changed the title chore: update go-ipfs-blockstore and ipfs-lite chore: Update go-ipfs-blockstore and ipfs-lite May 12, 2022
@codecov
Copy link

codecov bot commented May 12, 2022 •
edited
Loading

Codecov Report

Merging #436 (1fadc6a) into develop (896602a) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #436   +/-   ##
========================================
  Coverage    65.66%   65.66%           
========================================
  Files           80       80           
  Lines         9481     9481           
========================================
  Hits          6226     6226           
  Misses        2624     2624           
  Partials       631      631
Impacted Files Coverage Δ
datastore/blockstore.go 45.65% <33.33%> (ø)
db/collection_delete.go 61.67% <100.00%> (ø)

@orpheuslummis orpheuslummis mentioned this pull request May 12, 2022
Closed
7 tasks
AndrewSisley
AndrewSisley approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers for sorting these out :)

shahzadlone
shahzadlone approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅️

@orpheuslummis orpheuslummis merged commit dbbe282 into develop May 12, 2022
@orpheuslummis orpheuslummis deleted the orpheus/chore/update-dependencies-go-ipfs branch May 12, 2022 12:31
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@orpheuslummis
chore: Update go-ipfs-blockstore and ipfs-lite (sourcenetwork#436)
f4049f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewSisley AndrewSisley AndrewSisley approved these changes

@shahzadlone shahzadlone shahzadlone approved these changes

@jsimnz jsimnz Awaiting requested review from jsimnz

@fredcarle fredcarle Awaiting requested review from fredcarle

Assignees

@orpheuslummis orpheuslummis

Labels
action/no-benchmark Skips the action that runs the benchmark. dependencies Related to dependencies
Projects
None yet
Milestone
DefraDB v0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@orpheuslummis @shahzadlone @AndrewSisley