Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle limit and offsets in sub-group selects #440

Merged
merged 1 commit into from
May 16, 2022
Merged

fix: Handle limit and offsets in sub-group selects #440

merged 1 commit into from
May 16, 2022

Conversation

AndrewSisley
Copy link
Contributor

Resolves #435

Corrects the behaviour of limits and offsets on a sub-group. Previously the limit would kick in across groups, preventing records scanned later from appearing both in the top level and sub group select.

Bug is likely present in v0.2.*

Only the last commit 'Handle limit and offset in sub groups' is new to this PR, branch is based off of #426

@AndrewSisley AndrewSisley added bug Something isn't working area/query Related to the query component labels May 12, 2022
@AndrewSisley AndrewSisley added this to the DefraDB v0.3 milestone May 12, 2022
@AndrewSisley AndrewSisley self-assigned this May 12, 2022
@source-devs
Copy link

Benchmark Results

Summary

  • 113 Benchmarks successfully compared.
  • 76 Benchmarks were ✅ Better.
  • 37 Benchmarks were ❌ Worse .
  • 0 Benchmarks were ✨ Unchanged.
✅ See Better Results...
time/opdelta
_Collection_UserSimple_CreateMany_Sync_0_100-4350ms ± 0%256ms ± 0%−26.84%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_10-413.8ms ± 0%12.4ms ± 0%−10.14%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_100-4138ms ± 0%120ms ± 0%−12.88%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_1000-41.25s ± 0%1.21s ± 0%−2.69%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-452.7ms ± 0%48.7ms ± 0%−7.64%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-44.75s ± 0%4.67s ± 0%−1.68%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4455µs ± 0%352µs ± 0%−22.60%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_100_100-44.09ms ± 0%3.99ms ± 0%−2.43%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_1000-441.3ms ± 0%39.4ms ± 0%−4.59%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4380µs ± 0%367µs ± 0%−3.48%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_10_10-4337µs ± 0%288µs ± 0%−14.54%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-41.85ms ± 0%1.83ms ± 0%−0.77%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4271µs ± 0%268µs ± 0%−1.00%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-41.59ms ± 0%1.42ms ± 0%−10.79%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_1000-412.4ms ± 0%9.8ms ± 0%−21.22%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4552µs ± 0%499µs ± 0%−9.52%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4522µs ± 0%463µs ± 0%−11.33%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4504µs ± 0%481µs ± 0%−4.49%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4468µs ± 0%467µs ± 0%−0.10%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4839µs ± 0%800µs ± 0%−4.61%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4419µs ± 0%325µs ± 0%−22.48%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4367µs ± 0%302µs ± 0%−17.81%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4571µs ± 0%502µs ± 0%−12.13%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-41.61ms ± 0%1.53ms ± 0%−5.10%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-413.3ms ± 0%12.6ms ± 0%−5.07%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-416.8µs ± 0%14.4µs ± 0%−13.96%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-420.8µs ± 0%18.5µs ± 0%−11.18%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4185µs ± 0%146µs ± 0%−20.87%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4166µs ± 0%156µs ± 0%−5.89%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4178µs ± 0%164µs ± 0%−7.78%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4189µs ± 0%164µs ± 0%−13.21%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4290µs ± 0%202µs ± 0%−30.19%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-420.5µs ± 0%15.7µs ± 0%−23.47%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-419.1µs ± 0%17.7µs ± 0%−7.35%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-424.5µs ± 0%22.9µs ± 0%−6.59%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-427.9µs ± 0%22.8µs ± 0%−18.41%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4172µs ± 0%160µs ± 0%−7.12%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4203µs ± 0%174µs ± 0%−14.46%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4238µs ± 0%191µs ± 0%−19.79%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4283µs ± 0%220µs ± 0%−22.24%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-474.6µs ± 0%54.0µs ± 0%−27.63%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-477.6µs ± 0%55.5µs ± 0%−28.52%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-490.3µs ± 0%54.0µs ± 0%−40.22%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-4106µs ± 0%59µs ± 0%−44.85%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-4101µs ± 0%66µs ± 0%−34.84%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4473µs ± 0%390µs ± 0%−17.61%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4517µs ± 0%439µs ± 0%−15.12%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4604µs ± 0%590µs ± 0%−2.30%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4810µs ± 0%574µs ± 0%−29.14%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-460.7µs ± 0%55.9µs ± 0%−7.83%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-486.0µs ± 0%71.2µs ± 0%−17.24%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-483.5µs ± 0%73.4µs ± 0%−12.13%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4590µs ± 0%349µs ± 0%−40.87%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4576µs ± 0%360µs ± 0%−37.50%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4581µs ± 0%396µs ± 0%−31.75%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4556µs ± 0%480µs ± 0%−13.61%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4154µs ± 0%124µs ± 0%−19.87%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4161µs ± 0%137µs ± 0%−14.95%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4165µs ± 0%139µs ± 0%−15.29%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4175µs ± 0%148µs ± 0%−15.71%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4193µs ± 0%154µs ± 0%−20.61%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-41.58ms ± 0%1.22ms ± 0%−22.65%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-41.96ms ± 0%1.29ms ± 0%−33.88%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-42.12ms ± 0%1.35ms ± 0%−36.42%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-41.78ms ± 0%1.60ms ± 0%−10.21%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-41.75ms ± 0%1.68ms ± 0%−4.05%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4149µs ± 0%144µs ± 0%−3.40%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4167µs ± 0%165µs ± 0%−1.11%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-41.48ms ± 0%1.45ms ± 0%−2.01%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-410.9µs ± 0%9.1µs ± 0%−16.14%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-415.2µs ± 0%12.9µs ± 0%−15.33%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-4142µs ± 0%131µs ± 0%−7.72%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4200µs ± 0%194µs ± 0%−2.96%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-41.38ms ± 0%1.36ms ± 0%−1.12%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-41.36ms ± 0%1.32ms ± 0%−2.49%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-41.58ms ± 0%1.43ms ± 0%−9.18%(p=1.000 n=1+1)
 
❌ See Worse Results...
time/opdelta
_Collection_UserSimple_Create_Async_0_1000-4453ms ± 0%463ms ± 0%+2.16%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-44.01ms ± 0%4.05ms ± 0%+0.94%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-424.7ms ± 0%25.1ms ± 0%+1.78%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-41.94ms ± 0%1.96ms ± 0%+0.88%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-41.60ms ± 0%1.60ms ± 0%+0.49%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-410.4ms ± 0%10.7ms ± 0%+2.68%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-4810µs ± 0%817µs ± 0%+0.83%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4651µs ± 0%672µs ± 0%+3.16%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4283µs ± 0%287µs ± 0%+1.43%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-416.5µs ± 0%16.7µs ± 0%+0.82%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-422.7µs ± 0%24.8µs ± 0%+9.26%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-417.1µs ± 0%17.2µs ± 0%+0.51%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4175µs ± 0%181µs ± 0%+3.52%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4555µs ± 0%574µs ± 0%+3.34%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-454.2µs ± 0%56.1µs ± 0%+3.55%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-464.2µs ± 0%65.7µs ± 0%+2.39%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4436µs ± 0%444µs ± 0%+1.91%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4127µs ± 0%128µs ± 0%+0.34%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4150µs ± 0%156µs ± 0%+3.55%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4152µs ± 0%160µs ± 0%+5.15%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-41.33ms ± 0%1.51ms ± 0%+14.07%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-41.44ms ± 0%1.73ms ± 0%+20.58%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-41.45ms ± 0%1.68ms ± 0%+15.75%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-41.66ms ± 0%1.81ms ± 0%+9.17%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-411.3µs ± 0%11.4µs ± 0%+1.11%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-412.3µs ± 0%13.3µs ± 0%+8.38%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-419.4µs ± 0%19.7µs ± 0%+1.54%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-4103µs ± 0%111µs ± 0%+8.12%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-4109µs ± 0%109µs ± 0%+0.42%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4141µs ± 0%146µs ± 0%+3.48%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4134µs ± 0%145µs ± 0%+8.70%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4133µs ± 0%151µs ± 0%+13.04%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4134µs ± 0%139µs ± 0%+3.76%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4141µs ± 0%151µs ± 0%+6.99%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4134µs ± 0%165µs ± 0%+22.81%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-41.27ms ± 0%1.36ms ± 0%+7.10%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-41.37ms ± 0%1.42ms ± 0%+4.01%(p=1.000 n=1+1)
 
✨ See Unchanged Results...
time/opdelta
 
🐋 See Full Results...
develop.txtcurrent.txt
time/opdelta
pkg:github.com/sourcenetwork/defradb/bench/collection goos:linux goarch:amd64
_Collection_UserSimple_CreateMany_Sync_0_10-411.8ms ± 0%11.4ms ± 0%−2.75%(p=1.000 n=1+1)
_Collection_UserSimple_CreateMany_Sync_0_100-4350ms ± 0%256ms ± 0%−26.84%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_10-413.8ms ± 0%12.4ms ± 0%−10.14%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_100-4138ms ± 0%120ms ± 0%−12.88%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_1000-41.25s ± 0%1.21s ± 0%−2.69%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-452.7ms ± 0%48.7ms ± 0%−7.64%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_1000-4453ms ± 0%463ms ± 0%+2.16%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-44.75s ± 0%4.67s ± 0%−1.68%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4455µs ± 0%352µs ± 0%−22.60%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_100_100-44.09ms ± 0%3.99ms ± 0%−2.43%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_1000-441.3ms ± 0%39.4ms ± 0%−4.59%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4380µs ± 0%367µs ± 0%−3.48%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-44.01ms ± 0%4.05ms ± 0%+0.94%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_10_10-4337µs ± 0%288µs ± 0%−14.54%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-41.85ms ± 0%1.83ms ± 0%−0.77%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-424.7ms ± 0%25.1ms ± 0%+1.78%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4271µs ± 0%268µs ± 0%−1.00%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-41.94ms ± 0%1.96ms ± 0%+0.88%(p=1.000 n=1+1)
pkg:github.com/sourcenetwork/defradb/bench/query/simple goos:linux goarch:amd64
_Query_UserSimple_Query_Sync_10-4439µs ± 0%418µs ± 0%−4.85%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-41.59ms ± 0%1.42ms ± 0%−10.79%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_1000-412.4ms ± 0%9.8ms ± 0%−21.22%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4552µs ± 0%499µs ± 0%−9.52%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-41.60ms ± 0%1.60ms ± 0%+0.49%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-410.4ms ± 0%10.7ms ± 0%+2.68%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4522µs ± 0%463µs ± 0%−11.33%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4504µs ± 0%481µs ± 0%−4.49%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4468µs ± 0%467µs ± 0%−0.10%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-4810µs ± 0%817µs ± 0%+0.83%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4839µs ± 0%800µs ± 0%−4.61%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4651µs ± 0%672µs ± 0%+3.16%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4419µs ± 0%325µs ± 0%−22.48%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4367µs ± 0%302µs ± 0%−17.81%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4283µs ± 0%287µs ± 0%+1.43%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4571µs ± 0%502µs ± 0%−12.13%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-41.61ms ± 0%1.53ms ± 0%−5.10%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-413.3ms ± 0%12.6ms ± 0%−5.07%(p=1.000 n=1+1)
pkg:github.com/sourcenetwork/defradb/bench/storage goos:linux goarch:amd64
_Storage_Simple_Read_Sync_1_10/ValueSize:0064-417.6µs ± 0%14.2µs ± 0%−19.21%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-416.8µs ± 0%14.4µs ± 0%−13.96%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-416.5µs ± 0%16.7µs ± 0%+0.82%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-420.8µs ± 0%18.5µs ± 0%−11.18%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-422.7µs ± 0%24.8µs ± 0%+9.26%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4185µs ± 0%146µs ± 0%−20.87%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4166µs ± 0%156µs ± 0%−5.89%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4178µs ± 0%164µs ± 0%−7.78%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4189µs ± 0%164µs ± 0%−13.21%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4290µs ± 0%202µs ± 0%−30.19%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-420.5µs ± 0%15.7µs ± 0%−23.47%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-417.1µs ± 0%17.2µs ± 0%+0.51%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-419.1µs ± 0%17.7µs ± 0%−7.35%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-424.5µs ± 0%22.9µs ± 0%−6.59%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-427.9µs ± 0%22.8µs ± 0%−18.41%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4172µs ± 0%160µs ± 0%−7.12%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4175µs ± 0%181µs ± 0%+3.52%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4203µs ± 0%174µs ± 0%−14.46%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4238µs ± 0%191µs ± 0%−19.79%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4283µs ± 0%220µs ± 0%−22.24%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-474.6µs ± 0%54.0µs ± 0%−27.63%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-477.6µs ± 0%55.5µs ± 0%−28.52%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-490.3µs ± 0%54.0µs ± 0%−40.22%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-4106µs ± 0%59µs ± 0%−44.85%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-4101µs ± 0%66µs ± 0%−34.84%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4473µs ± 0%390µs ± 0%−17.61%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4517µs ± 0%439µs ± 0%−15.12%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4555µs ± 0%574µs ± 0%+3.34%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4604µs ± 0%590µs ± 0%−2.30%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4810µs ± 0%574µs ± 0%−29.14%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-460.7µs ± 0%55.9µs ± 0%−7.83%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-454.2µs ± 0%56.1µs ± 0%+3.55%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-464.2µs ± 0%65.7µs ± 0%+2.39%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-486.0µs ± 0%71.2µs ± 0%−17.24%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-483.5µs ± 0%73.4µs ± 0%−12.13%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4436µs ± 0%444µs ± 0%+1.91%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4590µs ± 0%349µs ± 0%−40.87%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4576µs ± 0%360µs ± 0%−37.50%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4581µs ± 0%396µs ± 0%−31.75%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4556µs ± 0%480µs ± 0%−13.61%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4154µs ± 0%124µs ± 0%−19.87%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4161µs ± 0%137µs ± 0%−14.95%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4165µs ± 0%139µs ± 0%−15.29%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4175µs ± 0%148µs ± 0%−15.71%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4193µs ± 0%154µs ± 0%−20.61%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-41.58ms ± 0%1.22ms ± 0%−22.65%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-41.96ms ± 0%1.29ms ± 0%−33.88%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-42.12ms ± 0%1.35ms ± 0%−36.42%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-41.78ms ± 0%1.60ms ± 0%−10.21%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-41.75ms ± 0%1.68ms ± 0%−4.05%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4127µs ± 0%128µs ± 0%+0.34%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4149µs ± 0%144µs ± 0%−3.40%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4150µs ± 0%156µs ± 0%+3.55%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4152µs ± 0%160µs ± 0%+5.15%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4167µs ± 0%165µs ± 0%−1.11%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-41.33ms ± 0%1.51ms ± 0%+14.07%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-41.44ms ± 0%1.73ms ± 0%+20.58%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-41.45ms ± 0%1.68ms ± 0%+15.75%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-41.48ms ± 0%1.45ms ± 0%−2.01%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-41.66ms ± 0%1.81ms ± 0%+9.17%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-410.9µs ± 0%9.1µs ± 0%−16.14%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-411.3µs ± 0%11.4µs ± 0%+1.11%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-412.3µs ± 0%13.3µs ± 0%+8.38%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-415.2µs ± 0%12.9µs ± 0%−15.33%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-419.4µs ± 0%19.7µs ± 0%+1.54%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-4103µs ± 0%111µs ± 0%+8.12%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-4109µs ± 0%109µs ± 0%+0.42%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-4142µs ± 0%131µs ± 0%−7.72%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4141µs ± 0%146µs ± 0%+3.48%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4200µs ± 0%194µs ± 0%−2.96%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4134µs ± 0%145µs ± 0%+8.70%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4133µs ± 0%151µs ± 0%+13.04%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4134µs ± 0%139µs ± 0%+3.76%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4141µs ± 0%151µs ± 0%+6.99%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4134µs ± 0%165µs ± 0%+22.81%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-41.27ms ± 0%1.36ms ± 0%+7.10%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-41.37ms ± 0%1.42ms ± 0%+4.01%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-41.38ms ± 0%1.36ms ± 0%−1.12%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-41.36ms ± 0%1.32ms ± 0%−2.49%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-41.58ms ± 0%1.43ms ± 0%−9.18%(p=1.000 n=1+1)
 

fredcarle
fredcarle approved these changes May 12, 2022
View reviewed changes
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! With the caveat that I'm not well versed in this part of the code base.

@source-devs
Copy link

Benchmark Results

Summary

  • 113 Benchmarks successfully compared.
  • 113 Benchmarks were ✅ Better.
  • 0 Benchmarks were ❌ Worse .
  • 0 Benchmarks were ✨ Unchanged.
✅ See Better Results...
time/opdelta
_Collection_UserSimple_CreateMany_Sync_0_100-4383ms ± 0%241ms ± 0%−36.91%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_10-414.7ms ± 0%10.1ms ± 0%−31.31%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_100-4162ms ± 0%96ms ± 0%−41.13%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_1000-41.48s ± 0%0.97s ± 0%−34.48%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-464.8ms ± 0%44.3ms ± 0%−31.68%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_1000-4502ms ± 0%435ms ± 0%−13.38%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-45.04s ± 0%4.42s ± 0%−12.25%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4483µs ± 0%331µs ± 0%−31.49%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_100_100-45.14ms ± 0%3.51ms ± 0%−31.61%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_1000-447.8ms ± 0%37.8ms ± 0%−20.88%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4481µs ± 0%358µs ± 0%−25.62%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-45.53ms ± 0%3.75ms ± 0%−32.23%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_10_10-4446µs ± 0%249µs ± 0%−44.17%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-42.63ms ± 0%1.79ms ± 0%−32.15%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-431.9ms ± 0%23.7ms ± 0%−25.51%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4330µs ± 0%253µs ± 0%−23.38%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-42.16ms ± 0%1.84ms ± 0%−14.89%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-41.74ms ± 0%1.12ms ± 0%−35.45%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_1000-413.7ms ± 0%9.2ms ± 0%−32.56%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4772µs ± 0%407µs ± 0%−47.30%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-42.05ms ± 0%1.21ms ± 0%−40.91%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-413.7ms ± 0%10.2ms ± 0%−25.38%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4560µs ± 0%387µs ± 0%−30.87%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4614µs ± 0%441µs ± 0%−28.09%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4488µs ± 0%424µs ± 0%−13.08%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-4820µs ± 0%617µs ± 0%−24.68%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4861µs ± 0%657µs ± 0%−23.73%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4806µs ± 0%627µs ± 0%−22.25%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4424µs ± 0%305µs ± 0%−27.91%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4397µs ± 0%294µs ± 0%−25.76%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4327µs ± 0%268µs ± 0%−18.14%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4618µs ± 0%405µs ± 0%−34.36%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-42.06ms ± 0%1.43ms ± 0%−30.40%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-414.4ms ± 0%12.1ms ± 0%−16.23%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-419.0µs ± 0%13.7µs ± 0%−28.10%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-420.5µs ± 0%13.6µs ± 0%−33.87%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-422.6µs ± 0%15.0µs ± 0%−33.58%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-428.7µs ± 0%19.0µs ± 0%−33.67%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4204µs ± 0%123µs ± 0%−39.79%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4194µs ± 0%133µs ± 0%−31.32%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4270µs ± 0%136µs ± 0%−49.38%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4271µs ± 0%157µs ± 0%−42.20%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4254µs ± 0%194µs ± 0%−23.68%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-419.2µs ± 0%14.5µs ± 0%−24.44%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-420.1µs ± 0%14.8µs ± 0%−26.67%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-420.7µs ± 0%15.3µs ± 0%−26.15%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-424.0µs ± 0%17.4µs ± 0%−27.28%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-432.9µs ± 0%20.8µs ± 0%−36.65%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4182µs ± 0%136µs ± 0%−25.04%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4210µs ± 0%139µs ± 0%−33.45%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4202µs ± 0%146µs ± 0%−27.62%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4199µs ± 0%166µs ± 0%−16.31%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4263µs ± 0%197µs ± 0%−25.06%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-474.7µs ± 0%45.5µs ± 0%−39.15%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-482.0µs ± 0%44.7µs ± 0%−45.49%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-473.0µs ± 0%47.2µs ± 0%−35.35%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-483.4µs ± 0%52.5µs ± 0%−37.09%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-489.0µs ± 0%64.9µs ± 0%−27.11%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4579µs ± 0%376µs ± 0%−35.12%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4513µs ± 0%359µs ± 0%−30.04%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4702µs ± 0%365µs ± 0%−48.01%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4826µs ± 0%448µs ± 0%−45.81%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4816µs ± 0%505µs ± 0%−38.12%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-474.6µs ± 0%49.1µs ± 0%−34.23%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-468.7µs ± 0%47.1µs ± 0%−31.50%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-477.0µs ± 0%49.7µs ± 0%−35.53%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-483.0µs ± 0%54.8µs ± 0%−33.95%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-4112µs ± 0%67µs ± 0%−40.04%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4493µs ± 0%340µs ± 0%−31.11%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4444µs ± 0%351µs ± 0%−20.88%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4416µs ± 0%355µs ± 0%−14.54%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4573µs ± 0%408µs ± 0%−28.72%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4767µs ± 0%496µs ± 0%−35.32%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4165µs ± 0%113µs ± 0%−31.08%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4160µs ± 0%114µs ± 0%−28.49%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4180µs ± 0%116µs ± 0%−35.72%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4194µs ± 0%120µs ± 0%−38.12%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4173µs ± 0%135µs ± 0%−21.88%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-41.44ms ± 0%1.14ms ± 0%−21.11%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-41.63ms ± 0%1.23ms ± 0%−24.55%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-41.75ms ± 0%1.20ms ± 0%−31.55%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-41.78ms ± 0%1.26ms ± 0%−28.95%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-42.32ms ± 0%1.36ms ± 0%−41.28%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4150µs ± 0%111µs ± 0%−25.85%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4146µs ± 0%113µs ± 0%−22.34%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4165µs ± 0%113µs ± 0%−31.54%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4151µs ± 0%120µs ± 0%−20.50%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4178µs ± 0%142µs ± 0%−20.34%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-41.57ms ± 0%1.13ms ± 0%−28.14%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-41.71ms ± 0%1.14ms ± 0%−33.31%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-41.67ms ± 0%1.17ms ± 0%−30.16%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-41.89ms ± 0%1.16ms ± 0%−38.86%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-41.85ms ± 0%1.32ms ± 0%−28.90%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-411.9µs ± 0%8.1µs ± 0%−32.45%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-411.8µs ± 0%8.3µs ± 0%−29.47%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-413.7µs ± 0%9.6µs ± 0%−29.69%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-414.7µs ± 0%11.5µs ± 0%−21.34%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-418.1µs ± 0%17.7µs ± 0%−2.40%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-4149µs ± 0%81µs ± 0%−45.54%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-4168µs ± 0%92µs ± 0%−45.22%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-4183µs ± 0%94µs ± 0%−48.44%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4231µs ± 0%108µs ± 0%−53.21%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4293µs ± 0%149µs ± 0%−49.14%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4166µs ± 0%123µs ± 0%−26.19%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4182µs ± 0%125µs ± 0%−31.47%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4158µs ± 0%123µs ± 0%−22.27%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4160µs ± 0%121µs ± 0%−23.96%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4158µs ± 0%129µs ± 0%−18.03%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-41.42ms ± 0%1.22ms ± 0%−14.38%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-41.29ms ± 0%1.19ms ± 0%−7.80%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-41.35ms ± 0%1.21ms ± 0%−10.12%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-41.47ms ± 0%1.25ms ± 0%−15.31%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-41.51ms ± 0%1.31ms ± 0%−13.54%(p=1.000 n=1+1)
 
❌ See Worse Results...
time/opdelta
 
✨ See Unchanged Results...
time/opdelta
 
🐋 See Full Results...
develop.txtcurrent.txt
time/opdelta
pkg:github.com/sourcenetwork/defradb/bench/collection goos:linux goarch:amd64
_Collection_UserSimple_CreateMany_Sync_0_10-413.7ms ± 0%10.7ms ± 0%−21.78%(p=1.000 n=1+1)
_Collection_UserSimple_CreateMany_Sync_0_100-4383ms ± 0%241ms ± 0%−36.91%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_10-414.7ms ± 0%10.1ms ± 0%−31.31%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_100-4162ms ± 0%96ms ± 0%−41.13%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_1000-41.48s ± 0%0.97s ± 0%−34.48%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-464.8ms ± 0%44.3ms ± 0%−31.68%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_1000-4502ms ± 0%435ms ± 0%−13.38%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-45.04s ± 0%4.42s ± 0%−12.25%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4483µs ± 0%331µs ± 0%−31.49%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_100_100-45.14ms ± 0%3.51ms ± 0%−31.61%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_1000-447.8ms ± 0%37.8ms ± 0%−20.88%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4481µs ± 0%358µs ± 0%−25.62%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-45.53ms ± 0%3.75ms ± 0%−32.23%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_10_10-4446µs ± 0%249µs ± 0%−44.17%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-42.63ms ± 0%1.79ms ± 0%−32.15%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-431.9ms ± 0%23.7ms ± 0%−25.51%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4330µs ± 0%253µs ± 0%−23.38%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-42.16ms ± 0%1.84ms ± 0%−14.89%(p=1.000 n=1+1)
pkg:github.com/sourcenetwork/defradb/bench/query/simple goos:linux goarch:amd64
_Query_UserSimple_Query_Sync_10-4640µs ± 0%338µs ± 0%−47.23%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-41.74ms ± 0%1.12ms ± 0%−35.45%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_1000-413.7ms ± 0%9.2ms ± 0%−32.56%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4772µs ± 0%407µs ± 0%−47.30%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-42.05ms ± 0%1.21ms ± 0%−40.91%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-413.7ms ± 0%10.2ms ± 0%−25.38%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4560µs ± 0%387µs ± 0%−30.87%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4614µs ± 0%441µs ± 0%−28.09%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4488µs ± 0%424µs ± 0%−13.08%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-4820µs ± 0%617µs ± 0%−24.68%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4861µs ± 0%657µs ± 0%−23.73%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4806µs ± 0%627µs ± 0%−22.25%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4424µs ± 0%305µs ± 0%−27.91%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4397µs ± 0%294µs ± 0%−25.76%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4327µs ± 0%268µs ± 0%−18.14%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4618µs ± 0%405µs ± 0%−34.36%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-42.06ms ± 0%1.43ms ± 0%−30.40%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-414.4ms ± 0%12.1ms ± 0%−16.23%(p=1.000 n=1+1)
pkg:github.com/sourcenetwork/defradb/bench/storage goos:linux goarch:amd64
_Storage_Simple_Read_Sync_1_10/ValueSize:0064-416.1µs ± 0%13.0µs ± 0%−19.21%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-419.0µs ± 0%13.7µs ± 0%−28.10%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-420.5µs ± 0%13.6µs ± 0%−33.87%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-422.6µs ± 0%15.0µs ± 0%−33.58%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-428.7µs ± 0%19.0µs ± 0%−33.67%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4204µs ± 0%123µs ± 0%−39.79%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4194µs ± 0%133µs ± 0%−31.32%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4270µs ± 0%136µs ± 0%−49.38%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4271µs ± 0%157µs ± 0%−42.20%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4254µs ± 0%194µs ± 0%−23.68%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-419.2µs ± 0%14.5µs ± 0%−24.44%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-420.1µs ± 0%14.8µs ± 0%−26.67%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-420.7µs ± 0%15.3µs ± 0%−26.15%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-424.0µs ± 0%17.4µs ± 0%−27.28%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-432.9µs ± 0%20.8µs ± 0%−36.65%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4182µs ± 0%136µs ± 0%−25.04%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4210µs ± 0%139µs ± 0%−33.45%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4202µs ± 0%146µs ± 0%−27.62%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4199µs ± 0%166µs ± 0%−16.31%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4263µs ± 0%197µs ± 0%−25.06%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-474.7µs ± 0%45.5µs ± 0%−39.15%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-482.0µs ± 0%44.7µs ± 0%−45.49%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-473.0µs ± 0%47.2µs ± 0%−35.35%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-483.4µs ± 0%52.5µs ± 0%−37.09%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-489.0µs ± 0%64.9µs ± 0%−27.11%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4579µs ± 0%376µs ± 0%−35.12%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4513µs ± 0%359µs ± 0%−30.04%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4702µs ± 0%365µs ± 0%−48.01%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4826µs ± 0%448µs ± 0%−45.81%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4816µs ± 0%505µs ± 0%−38.12%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-474.6µs ± 0%49.1µs ± 0%−34.23%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-468.7µs ± 0%47.1µs ± 0%−31.50%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-477.0µs ± 0%49.7µs ± 0%−35.53%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-483.0µs ± 0%54.8µs ± 0%−33.95%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-4112µs ± 0%67µs ± 0%−40.04%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4493µs ± 0%340µs ± 0%−31.11%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4444µs ± 0%351µs ± 0%−20.88%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4416µs ± 0%355µs ± 0%−14.54%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4573µs ± 0%408µs ± 0%−28.72%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4767µs ± 0%496µs ± 0%−35.32%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4165µs ± 0%113µs ± 0%−31.08%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4160µs ± 0%114µs ± 0%−28.49%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4180µs ± 0%116µs ± 0%−35.72%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4194µs ± 0%120µs ± 0%−38.12%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4173µs ± 0%135µs ± 0%−21.88%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-41.44ms ± 0%1.14ms ± 0%−21.11%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-41.63ms ± 0%1.23ms ± 0%−24.55%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-41.75ms ± 0%1.20ms ± 0%−31.55%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-41.78ms ± 0%1.26ms ± 0%−28.95%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-42.32ms ± 0%1.36ms ± 0%−41.28%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4150µs ± 0%111µs ± 0%−25.85%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4146µs ± 0%113µs ± 0%−22.34%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4165µs ± 0%113µs ± 0%−31.54%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4151µs ± 0%120µs ± 0%−20.50%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4178µs ± 0%142µs ± 0%−20.34%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-41.57ms ± 0%1.13ms ± 0%−28.14%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-41.71ms ± 0%1.14ms ± 0%−33.31%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-41.67ms ± 0%1.17ms ± 0%−30.16%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-41.89ms ± 0%1.16ms ± 0%−38.86%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-41.85ms ± 0%1.32ms ± 0%−28.90%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-411.9µs ± 0%8.1µs ± 0%−32.45%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-411.8µs ± 0%8.3µs ± 0%−29.47%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-413.7µs ± 0%9.6µs ± 0%−29.69%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-414.7µs ± 0%11.5µs ± 0%−21.34%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-418.1µs ± 0%17.7µs ± 0%−2.40%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-4149µs ± 0%81µs ± 0%−45.54%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-4168µs ± 0%92µs ± 0%−45.22%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-4183µs ± 0%94µs ± 0%−48.44%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4231µs ± 0%108µs ± 0%−53.21%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4293µs ± 0%149µs ± 0%−49.14%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4166µs ± 0%123µs ± 0%−26.19%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4182µs ± 0%125µs ± 0%−31.47%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4158µs ± 0%123µs ± 0%−22.27%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4160µs ± 0%121µs ± 0%−23.96%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4158µs ± 0%129µs ± 0%−18.03%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-41.42ms ± 0%1.22ms ± 0%−14.38%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-41.29ms ± 0%1.19ms ± 0%−7.80%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-41.35ms ± 0%1.21ms ± 0%−10.12%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-41.47ms ± 0%1.25ms ± 0%−15.31%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-41.51ms ± 0%1.31ms ± 0%−13.54%(p=1.000 n=1+1)
 

@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #440 (71ef701) into develop (d36ffc8) will increase coverage by 0.05%.
The diff coverage is 90.47%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #440      +/-   ##
===========================================
+ Coverage    64.87%   64.93%   +0.05%     
===========================================
  Files           86       86              
  Lines         9977     9998      +21     
===========================================
+ Hits          6473     6492      +19     
- Misses        2866     2867       +1     
- Partials       638      639       +1
Impacted Files Coverage Δ
query/graphql/planner/group.go 79.06% <88.23%> (+2.25%) ⬆️
query/graphql/planner/planner.go 71.42% <100.00%> (+0.40%) ⬆️

@AndrewSisley AndrewSisley merged commit 5e3a3b8 into develop May 16, 2022
@AndrewSisley AndrewSisley deleted the sisley/fix/I435-group-limit branch May 16, 2022 16:49
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@AndrewSisley
fix: Handle limit and offset in sub groups (sourcenetwork#440)
7f6906f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredcarle fredcarle fredcarle approved these changes

@orpheuslummis orpheuslummis Awaiting requested review from orpheuslummis

@jsimnz jsimnz Awaiting requested review from jsimnz

@shahzadlone shahzadlone Awaiting requested review from shahzadlone

Assignees

@AndrewSisley AndrewSisley

Labels
area/query Related to the query component bug Something isn't working
Projects
None yet
Milestone
DefraDB v0.3
Development

Successfully merging this pull request may close these issues.

Limit on _group does not behave correctly
3 participants
@AndrewSisley @source-devs @fredcarle