Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests located in a top-level folder #445

Closed
orpheuslummis opened this issue May 16, 2022 · 0 comments · Fixed by #446
Closed

Integration tests located in a top-level folder #445

orpheuslummis opened this issue May 16, 2022 · 0 comments · Fixed by #446
Assignees
Labels
area/testing Related to any test or testing suite refactor This issue specific to or requires *notable* refactoring of existing codebases and components
Milestone

Comments

@orpheuslummis
Copy link
Contributor

I suggest we gather all defradb's integration tests under the testing top-level folder. This way, bench and db integration tests can be there, p2ptestground once it's ready, and later on further tests such as for protocol integration, etc.

This way we

  • avoid ending up with multiple top-level tests which would occlude the defradb packages
  • do not have 'external' tooling (testground, stress testing tool, security testing tool, etc) inside a sub-folder of a package like net
  • avoid having multiple integration tests sub-folders inside packages like db or net which 'compete' with source code sub-folders

The current way seems to be to have each integration test inside the folder of its most related package, and otherwise have the more general tests top-level. p2ptestground would be in node or net.

What is your preference, if any?

Answers from core team on Discord:

  • Andy: I would be very much in favour of this, is odd/incorrect that the query-integration tests are in db and they should be moved
  • Fred: Also in favour of this proposition.
  • Shahzad: 100% in favor of this
@orpheuslummis orpheuslummis added the action/no-benchmark Skips the action that runs the benchmark. label May 16, 2022
@orpheuslummis orpheuslummis added this to the DefraDB v0.3 milestone May 16, 2022
@orpheuslummis orpheuslummis self-assigned this May 16, 2022
@jsimnz jsimnz added area/testing Related to any test or testing suite refactor This issue specific to or requires *notable* refactoring of existing codebases and components labels May 16, 2022
@orpheuslummis orpheuslummis removed the action/no-benchmark Skips the action that runs the benchmark. label May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Related to any test or testing suite refactor This issue specific to or requires *notable* refactoring of existing codebases and components
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants