-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update dependencies #450
chore: Update dependencies #450
Conversation
Any suggestion for a better PR title? |
Benchmark ResultsSummary
✅ See Better Results...
❌ See Worse Results...
✨ See Unchanged Results...
🐋 See Full Results...
|
The new CBOR update could actually be pretty interesting, as I've had to write some helper code to resolve that exact issue (somewhere in Defra or Connor :/) As for the GraphQL-go package. AFAIK that linked issue (graphql-go#495) is already included via our fork. |
Yeah gql-go is upto date, we just forgot to pull the tag in |
The linked issues are only highlighting interesting points that happened in the updated dependencies between previous and new versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, didnt realize that you weren't actually updating the graphql-go package, just highlighting the new additions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (shows some conflicts though).
b0d57e5
to
55d469b
Compare
Benchmark ResultsSummary
✅ See Better Results...
❌ See Worse Results...
✨ See Unchanged Results...
🐋 See Full Results...
|
cobra, viper, gRPC, CBOR, ...
RELEVANT ISSUE(S)
Resolves #449
DESCRIPTION
Updating all defradb's dependencies that are non-breaking. A subsequent PR will address remaining breaking dependencies, then we switch to semi-automated dependency updating with dependabot.
Noticable changes in the updates of these dependencies:
Build works on Go 1.18
CBOR
graphql-go
gRPC
viper
cobra
HOW HAS THIS BEEN TESTED?
Running all our test suites.
CHECKLIST:
ENVIRONMENT / OS THIS WAS TESTED ON?
Please specify which of the following was this tested on (remove or add your own):