feat: Add explaination of spans for scanNode.
#492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzadlone
added
the
action/no-benchmark
shahzadlone
requested review from
AndrewSisley,
jsimnz,
fredcarle and
orpheuslummis
and removed request for
AndrewSisley and
jsimnz
Codecov Report
@@ Coverage Diff @@
## develop #492 +/- ##
===========================================
+ Coverage 65.06% 65.09% +0.03%
===========================================
Files 87 87
Lines 10233 10242 +9
===========================================
+ Hits 6658 6667 +9
Misses 2927 2927
Partials 648 648
|
shahzadlone
added a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
- RELEVANT ISSUE(S) Resolves sourcenetwork#474 - DESCRIPTION Adds the explanation of the `spans` attribute inside the `scanNode`. Request: ``` query @Explain { users(dockeys: ["bae-52b9170d-b77a-5887-b877-cbdbb99b009f","bae-1378ab62-e064-5af4-9ea6-49941c8d8f94"]) { Name Age } } ``` Response: ``` { "explain": { "selectTopNode": { "selectNode": { "filter": nil, "scanNode": { "collectionID": "1", "collectionName": "users", "filter": nil, "spans": { { "start": "/1/bae-52b9170d-b77a-5887-b877-cbdbb99b009f", "end": "/1/bae-52b9170d-b77a-5887-b877-cbdbb99b009g" }, { "start": "/1/bae-1378ab62-e064-5af4-9ea6-49941c8d8f94", "end": "/1/bae-1378ab62-e064-5af4-9ea6-49941c8d8f95" } } } } } } } ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEVANT ISSUE(S)
Resolves #474
DESCRIPTION
Adds the explanation of the
spansattribute inside thescanNode.Request:
Response:
HOW HAS THIS BEEN TESTED?
Locally and Integration Tests were updated.
CHECKLIST:
ENVIRONMENT / OS THIS WAS TESTED ON?
Please specify which of the following was this tested on (remove or add your own):