-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Basic unit testing of node
package
#503
test: Basic unit testing of node
package
#503
Conversation
You're invited to suggest further unit tests. Some of it isn't tested because it is expected to change relatively soon, such as key management, and others because I've found them difficult to test and just wanted a quick PR... e.g. validity of |
Codecov Report
@@ Coverage Diff @@
## develop #503 +/- ##
============================================
- Coverage 65.09% 52.46% -12.63%
============================================
Files 87 97 +10
Lines 10242 13144 +2902
============================================
+ Hits 6667 6896 +229
- Misses 2927 5574 +2647
- Partials 648 674 +26
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last two items. LGTM
RELEVANT ISSUE(S)
Resolves #502
DESCRIPTION
Provide basic unit tests for the
node
package.HOW HAS THIS BEEN TESTED?
These are unit tests.
CHECKLIST:
ENVIRONMENT / OS THIS WAS TESTED ON?
Please specify which of the following was this tested on (remove or add your own):