-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support to explain countNode
attributes.
#504
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Left an optional suggestion on selectTN.source
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Straight forward, minor suggestion. LGTM
74f9147
to
6ebd9a5
Compare
Codecov Report
@@ Coverage Diff @@
## develop #504 +/- ##
===========================================
+ Coverage 54.10% 54.20% +0.10%
===========================================
Files 97 97
Lines 13099 13109 +10
===========================================
+ Hits 7087 7106 +19
+ Misses 5337 5328 -9
Partials 675 675
|
- RELEVANT ISSUE(S) Resolves sourcenetwork#478 - DESCRIPTION (1) Adds ability to explain attributes of `countNode`. (2) Fixes a bug which was omitting the aggregate nodes. Request: ``` query @Explain { author { name numberOfBooks: _count(books: {}) } } ``` Response: ``` { "explain": { "selectTopNode": { "countNode": { "filter": nil, "sourceProperty": "books", "selectNode": { "filter": nil, "typeIndexJoin": { "scanNode": { "collectionID": "3", "collectionName": "author", "filter": nil, "spans": []{ { "start": "/3", "end": "/4", } } } } } } } } } ```
RELEVANT ISSUE(S)
Resolves #478
DESCRIPTION
countNode
.Request:
Response:
HOW HAS THIS BEEN TESTED?
Integration tests.
CHECKLIST:
ENVIRONMENT / OS THIS WAS TESTED ON?
Please specify which of the following was this tested on (remove or add your own):