Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with the p2p system complaining about malformed DocKey while broadcasting. #508

Closed
jsimnz opened this issue Jun 7, 2022 · 1 comment · Fixed by #631
Closed

Issue with the p2p system complaining about malformed DocKey while broadcasting. #508

jsimnz opened this issue Jun 7, 2022 · 1 comment · Fixed by #631
Assignees
Labels
area/p2p Related to the p2p networking system bug Something isn't working
Milestone

Comments

@jsimnz
Copy link
Member

jsimnz commented Jun 7, 2022

Error message to follow.

@jsimnz jsimnz added bug Something isn't working area/p2p Related to the p2p networking system labels Jun 7, 2022
@jsimnz jsimnz added this to the DefraDB v0.3 milestone Jun 7, 2022
@jsimnz jsimnz self-assigned this Jun 28, 2022
@jsimnz
Copy link
Member Author

jsimnz commented Jun 30, 2022

Found the issue, because I decided to debug and fix it 4 mins before an investor call that I wanted to demo to, but remembered the p2p system is broken 😂.

Stems from this line:

dockey := parts[2]

For some reason (escaped my mind) why I didn't use the proper core.NewDocKey call (since that is what its therefore) and instead try to manually convert the MerkleCRDT ID /v/DocKey/FieldID manually.

However the structure change semi recently when me moved where the "priority" and "value" indicators were from the end of the key as a "Instance" on the ds.Key to as a prefix, which allowed us to more effeciently iterate through values.

But, due to the lack of testing in the P2P system, this change wasn't caught.

Anyways, its baiscally a 1 line fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/p2p Related to the p2p networking system bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant