Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Restructure and expand filter tests #512

Merged
merged 2 commits into from
Jun 10, 2022

Conversation

AndrewSisley
Copy link
Contributor

RELEVANT ISSUE(S)

Resolves #511

DESCRIPTION

Restructures and expands the integration tests to cover more of the possible filters.

There are two commits, one moves the existing without modifying, the second adds new tests.

CHECKLIST:

  • I have commented the code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the repo-held documentation.
  • I have made sure that the PR title adheres to the conventional commit style (subset of the ones we use can be found under: tools/configs/chglog/config.yml

ENVIRONMENT / OS THIS WAS TESTED ON?

Please specify which of the following was this tested on (remove or add your own):

  • Arch Linux
  • Debian Linux
  • MacOS
  • Windows

@AndrewSisley AndrewSisley added area/query Related to the query component area/testing Related to any test or testing suite action/no-benchmark Skips the action that runs the benchmark. labels Jun 9, 2022
@AndrewSisley AndrewSisley added this to the DefraDB v0.3 milestone Jun 9, 2022
@AndrewSisley AndrewSisley self-assigned this Jun 9, 2022
@AndrewSisley AndrewSisley mentioned this pull request Jun 9, 2022
26 tasks
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙂

@AndrewSisley AndrewSisley merged commit 64ea968 into develop Jun 10, 2022
@AndrewSisley AndrewSisley deleted the sisley/test/I511-expand-filter-tests branch June 10, 2022 15:21
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
* Restructure filter integration tests

In preparation for expansion

* Expand filter integration tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/no-benchmark Skips the action that runs the benchmark. area/query Related to the query component area/testing Related to any test or testing suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration test coverage of filter conditions is really poor
2 participants