Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add Dockerfile #517

Merged
merged 4 commits into from
Jun 17, 2022
Merged

chore: Add Dockerfile #517

merged 4 commits into from
Jun 17, 2022

Conversation

orpheuslummis
Copy link
Contributor

@orpheuslummis orpheuslummis commented Jun 10, 2022 •
edited
Loading

RELEVANT ISSUE(S)

Resolves #516

DESCRIPTION

Introducing a Dockerfile.

We use a multistage approach which doesn't include the build environment in the resulting container.

This depends on https://github.com/GoogleContainerTools/distroless which we may not want to do. What we gain from this is a very small container.

I'd prefer using the new and more general terminology Containerfile but Dockerfile is very established, and DefraDB already brings a lot of new stuff.

Question: Should it live at the top-level or in a sub-directory?

I think this should be tested a bit more manually.

HOW HAS THIS BEEN TESTED?

  • macOS: built & ran with DOCKER_BUILDKIT=1 on and off
  • podman
  • podman rootless
  • on actual cloud platform

CHECKLIST:

  • I have commented the code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the repo-held documentation.
  • I have made sure that the PR title adheres to the conventional commit style (subset of the ones we use can be found under: tools/configs/chglog/config.yml

ENVIRONMENT / OS THIS WAS TESTED ON?

Please specify which of the following was this tested on (remove or add your own):

  • Arch Linux
  • Debian Linux
  • MacOS
  • Windows

@orpheuslummis orpheuslummis added the ci/build This is issue is about the build or CI system, and the administration of it. label Jun 10, 2022
@orpheuslummis orpheuslummis added this to the DefraDB v0.3 milestone Jun 10, 2022
@orpheuslummis orpheuslummis self-assigned this Jun 10, 2022
@orpheuslummis orpheuslummis added the action/no-benchmark Skips the action that runs the benchmark. label Jun 10, 2022
@orpheuslummis
Copy link
Contributor Author

It is now a draft PR because before merging it'd be best to build and run it on a few different platforms and to receive feedback from more experienced Dockernauts.

@orpheuslummis orpheuslummis requested a review from a team June 10, 2022 23:12
@source-devs
Copy link

Benchmark Results

Summary

  • 113 Benchmarks successfully compared.
  • 113 Benchmarks were ✅ Better.
  • 0 Benchmarks were ❌ Worse .
  • 0 Benchmarks were ✨ Unchanged.
✅ See Better Results...
time/opdelta
_Collection_UserSimple_CreateMany_Sync_0_100-4295ms ± 0%214ms ± 0%−27.43%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_10-412.3ms ± 0%9.7ms ± 0%−21.31%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_100-4119ms ± 0%98ms ± 0%−17.56%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_1000-41.36s ± 0%0.96s ± 0%−29.19%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-455.1ms ± 0%43.3ms ± 0%−21.36%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_1000-4470ms ± 0%433ms ± 0%−7.78%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-44.81s ± 0%4.42s ± 0%−8.12%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4354µs ± 0%328µs ± 0%−7.14%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_100_100-44.12ms ± 0%3.49ms ± 0%−15.38%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_1000-441.3ms ± 0%38.2ms ± 0%−7.48%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4372µs ± 0%352µs ± 0%−5.40%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-43.97ms ± 0%3.62ms ± 0%−8.70%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_10_10-4297µs ± 0%239µs ± 0%−19.69%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-42.40ms ± 0%1.75ms ± 0%−27.19%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-424.3ms ± 0%22.9ms ± 0%−5.81%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4272µs ± 0%249µs ± 0%−8.62%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-42.06ms ± 0%1.79ms ± 0%−13.26%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-41.58ms ± 0%1.15ms ± 0%−26.95%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_1000-413.4ms ± 0%9.5ms ± 0%−29.07%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4581µs ± 0%408µs ± 0%−29.74%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-41.60ms ± 0%1.27ms ± 0%−20.51%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-411.6ms ± 0%9.9ms ± 0%−14.56%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4505µs ± 0%372µs ± 0%−26.37%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4646µs ± 0%418µs ± 0%−35.25%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4508µs ± 0%418µs ± 0%−17.79%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-41.01ms ± 0%0.61ms ± 0%−39.54%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4898µs ± 0%617µs ± 0%−31.36%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4719µs ± 0%621µs ± 0%−13.68%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4328µs ± 0%266µs ± 0%−18.93%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4368µs ± 0%268µs ± 0%−27.29%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4301µs ± 0%265µs ± 0%−11.98%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4537µs ± 0%397µs ± 0%−26.04%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-41.87ms ± 0%1.36ms ± 0%−27.36%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-416.9ms ± 0%12.0ms ± 0%−28.89%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-417.6µs ± 0%12.9µs ± 0%−26.66%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-418.9µs ± 0%13.6µs ± 0%−27.96%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-419.8µs ± 0%15.0µs ± 0%−24.36%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-425.5µs ± 0%19.1µs ± 0%−25.09%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4189µs ± 0%119µs ± 0%−37.05%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4206µs ± 0%129µs ± 0%−37.44%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4194µs ± 0%135µs ± 0%−30.35%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4234µs ± 0%152µs ± 0%−35.08%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4274µs ± 0%192µs ± 0%−30.08%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-419.4µs ± 0%14.2µs ± 0%−26.70%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-422.4µs ± 0%14.6µs ± 0%−35.08%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-426.6µs ± 0%14.7µs ± 0%−44.52%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-426.7µs ± 0%16.4µs ± 0%−38.81%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-437.0µs ± 0%20.1µs ± 0%−45.72%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4224µs ± 0%138µs ± 0%−38.66%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4213µs ± 0%135µs ± 0%−36.79%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4180µs ± 0%146µs ± 0%−18.82%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4229µs ± 0%159µs ± 0%−30.55%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4280µs ± 0%197µs ± 0%−29.89%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-459.7µs ± 0%42.3µs ± 0%−29.27%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-459.6µs ± 0%42.3µs ± 0%−29.01%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-461.2µs ± 0%44.1µs ± 0%−28.00%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-472.4µs ± 0%48.8µs ± 0%−32.70%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-484.7µs ± 0%63.1µs ± 0%−25.45%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4555µs ± 0%318µs ± 0%−42.72%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4634µs ± 0%325µs ± 0%−48.79%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4535µs ± 0%352µs ± 0%−34.15%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4705µs ± 0%372µs ± 0%−47.26%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4696µs ± 0%458µs ± 0%−34.14%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-452.7µs ± 0%43.4µs ± 0%−17.61%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-455.1µs ± 0%44.4µs ± 0%−19.29%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-453.3µs ± 0%44.5µs ± 0%−16.53%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-472.3µs ± 0%48.3µs ± 0%−33.20%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-480.7µs ± 0%61.2µs ± 0%−24.14%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4428µs ± 0%314µs ± 0%−26.65%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4390µs ± 0%325µs ± 0%−16.60%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4426µs ± 0%341µs ± 0%−19.78%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4451µs ± 0%370µs ± 0%−17.87%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4502µs ± 0%488µs ± 0%−2.81%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4136µs ± 0%113µs ± 0%−17.04%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4123µs ± 0%116µs ± 0%−5.73%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4133µs ± 0%117µs ± 0%−11.65%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4160µs ± 0%120µs ± 0%−25.25%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4181µs ± 0%133µs ± 0%−26.66%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-41.49ms ± 0%1.12ms ± 0%−24.61%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-41.54ms ± 0%1.14ms ± 0%−26.09%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-41.60ms ± 0%1.14ms ± 0%−28.49%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-41.55ms ± 0%1.20ms ± 0%−22.67%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-41.81ms ± 0%1.33ms ± 0%−26.49%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4143µs ± 0%107µs ± 0%−24.96%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4141µs ± 0%111µs ± 0%−21.77%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4136µs ± 0%110µs ± 0%−19.48%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4153µs ± 0%116µs ± 0%−24.25%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4162µs ± 0%129µs ± 0%−20.55%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-41.33ms ± 0%1.10ms ± 0%−17.38%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-41.51ms ± 0%1.11ms ± 0%−26.64%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-41.30ms ± 0%1.12ms ± 0%−13.96%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-41.33ms ± 0%1.16ms ± 0%−13.27%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-41.55ms ± 0%1.24ms ± 0%−20.04%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-49.16µs ± 0%7.96µs ± 0%−13.06%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-411.6µs ± 0%8.3µs ± 0%−28.74%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-410.8µs ± 0%9.1µs ± 0%−15.53%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-415.7µs ± 0%10.6µs ± 0%−32.66%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-417.9µs ± 0%14.4µs ± 0%−19.49%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-4102µs ± 0%83µs ± 0%−18.92%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-4116µs ± 0%85µs ± 0%−26.78%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-4122µs ± 0%91µs ± 0%−25.47%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4140µs ± 0%111µs ± 0%−20.94%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4194µs ± 0%148µs ± 0%−23.94%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4136µs ± 0%116µs ± 0%−14.21%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4133µs ± 0%120µs ± 0%−9.90%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4142µs ± 0%119µs ± 0%−16.10%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4138µs ± 0%120µs ± 0%−13.25%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4139µs ± 0%127µs ± 0%−8.69%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-41.35ms ± 0%1.20ms ± 0%−11.35%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-41.24ms ± 0%1.23ms ± 0%−0.69%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-41.31ms ± 0%1.19ms ± 0%−9.12%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-41.30ms ± 0%1.22ms ± 0%−6.08%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-41.38ms ± 0%1.22ms ± 0%−11.76%(p=1.000 n=1+1)
 
❌ See Worse Results...
time/opdelta
 
✨ See Unchanged Results...
time/opdelta
 
🐋 See Full Results...
develop.txtcurrent.txt
time/opdelta
pkg:collection goos:linux goarch:amd64
_Collection_UserSimple_CreateMany_Sync_0_10-411.5ms ± 0%10.7ms ± 0%−6.78%(p=1.000 n=1+1)
_Collection_UserSimple_CreateMany_Sync_0_100-4295ms ± 0%214ms ± 0%−27.43%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_10-412.3ms ± 0%9.7ms ± 0%−21.31%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_100-4119ms ± 0%98ms ± 0%−17.56%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_1000-41.36s ± 0%0.96s ± 0%−29.19%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-455.1ms ± 0%43.3ms ± 0%−21.36%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_1000-4470ms ± 0%433ms ± 0%−7.78%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-44.81s ± 0%4.42s ± 0%−8.12%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4354µs ± 0%328µs ± 0%−7.14%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_100_100-44.12ms ± 0%3.49ms ± 0%−15.38%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_1000-441.3ms ± 0%38.2ms ± 0%−7.48%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4372µs ± 0%352µs ± 0%−5.40%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-43.97ms ± 0%3.62ms ± 0%−8.70%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_10_10-4297µs ± 0%239µs ± 0%−19.69%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-42.40ms ± 0%1.75ms ± 0%−27.19%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-424.3ms ± 0%22.9ms ± 0%−5.81%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4272µs ± 0%249µs ± 0%−8.62%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-42.06ms ± 0%1.79ms ± 0%−13.26%(p=1.000 n=1+1)
pkg:query/simple goos:linux goarch:amd64
_Query_UserSimple_Query_Sync_10-4427µs ± 0%333µs ± 0%−22.07%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-41.58ms ± 0%1.15ms ± 0%−26.95%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_1000-413.4ms ± 0%9.5ms ± 0%−29.07%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4581µs ± 0%408µs ± 0%−29.74%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-41.60ms ± 0%1.27ms ± 0%−20.51%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-411.6ms ± 0%9.9ms ± 0%−14.56%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4505µs ± 0%372µs ± 0%−26.37%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4646µs ± 0%418µs ± 0%−35.25%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4508µs ± 0%418µs ± 0%−17.79%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-41.01ms ± 0%0.61ms ± 0%−39.54%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4898µs ± 0%617µs ± 0%−31.36%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4719µs ± 0%621µs ± 0%−13.68%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4328µs ± 0%266µs ± 0%−18.93%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4368µs ± 0%268µs ± 0%−27.29%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4301µs ± 0%265µs ± 0%−11.98%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4537µs ± 0%397µs ± 0%−26.04%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-41.87ms ± 0%1.36ms ± 0%−27.36%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-416.9ms ± 0%12.0ms ± 0%−28.89%(p=1.000 n=1+1)
pkg:storage goos:linux goarch:amd64
_Storage_Simple_Read_Sync_1_10/ValueSize:0064-417.6µs ± 0%12.2µs ± 0%−30.53%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-417.6µs ± 0%12.9µs ± 0%−26.66%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-418.9µs ± 0%13.6µs ± 0%−27.96%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-419.8µs ± 0%15.0µs ± 0%−24.36%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-425.5µs ± 0%19.1µs ± 0%−25.09%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4189µs ± 0%119µs ± 0%−37.05%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4206µs ± 0%129µs ± 0%−37.44%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4194µs ± 0%135µs ± 0%−30.35%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4234µs ± 0%152µs ± 0%−35.08%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4274µs ± 0%192µs ± 0%−30.08%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-419.4µs ± 0%14.2µs ± 0%−26.70%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-422.4µs ± 0%14.6µs ± 0%−35.08%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-426.6µs ± 0%14.7µs ± 0%−44.52%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-426.7µs ± 0%16.4µs ± 0%−38.81%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-437.0µs ± 0%20.1µs ± 0%−45.72%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4224µs ± 0%138µs ± 0%−38.66%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4213µs ± 0%135µs ± 0%−36.79%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4180µs ± 0%146µs ± 0%−18.82%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4229µs ± 0%159µs ± 0%−30.55%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4280µs ± 0%197µs ± 0%−29.89%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-459.7µs ± 0%42.3µs ± 0%−29.27%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-459.6µs ± 0%42.3µs ± 0%−29.01%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-461.2µs ± 0%44.1µs ± 0%−28.00%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-472.4µs ± 0%48.8µs ± 0%−32.70%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-484.7µs ± 0%63.1µs ± 0%−25.45%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4555µs ± 0%318µs ± 0%−42.72%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4634µs ± 0%325µs ± 0%−48.79%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4535µs ± 0%352µs ± 0%−34.15%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4705µs ± 0%372µs ± 0%−47.26%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4696µs ± 0%458µs ± 0%−34.14%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-452.7µs ± 0%43.4µs ± 0%−17.61%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-455.1µs ± 0%44.4µs ± 0%−19.29%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-453.3µs ± 0%44.5µs ± 0%−16.53%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-472.3µs ± 0%48.3µs ± 0%−33.20%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-480.7µs ± 0%61.2µs ± 0%−24.14%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4428µs ± 0%314µs ± 0%−26.65%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4390µs ± 0%325µs ± 0%−16.60%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4426µs ± 0%341µs ± 0%−19.78%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4451µs ± 0%370µs ± 0%−17.87%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4502µs ± 0%488µs ± 0%−2.81%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4136µs ± 0%113µs ± 0%−17.04%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4123µs ± 0%116µs ± 0%−5.73%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4133µs ± 0%117µs ± 0%−11.65%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4160µs ± 0%120µs ± 0%−25.25%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4181µs ± 0%133µs ± 0%−26.66%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-41.49ms ± 0%1.12ms ± 0%−24.61%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-41.54ms ± 0%1.14ms ± 0%−26.09%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-41.60ms ± 0%1.14ms ± 0%−28.49%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-41.55ms ± 0%1.20ms ± 0%−22.67%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-41.81ms ± 0%1.33ms ± 0%−26.49%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4143µs ± 0%107µs ± 0%−24.96%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4141µs ± 0%111µs ± 0%−21.77%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4136µs ± 0%110µs ± 0%−19.48%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4153µs ± 0%116µs ± 0%−24.25%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4162µs ± 0%129µs ± 0%−20.55%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-41.33ms ± 0%1.10ms ± 0%−17.38%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-41.51ms ± 0%1.11ms ± 0%−26.64%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-41.30ms ± 0%1.12ms ± 0%−13.96%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-41.33ms ± 0%1.16ms ± 0%−13.27%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-41.55ms ± 0%1.24ms ± 0%−20.04%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-49.16µs ± 0%7.96µs ± 0%−13.06%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-411.6µs ± 0%8.3µs ± 0%−28.74%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-410.8µs ± 0%9.1µs ± 0%−15.53%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-415.7µs ± 0%10.6µs ± 0%−32.66%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-417.9µs ± 0%14.4µs ± 0%−19.49%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-4102µs ± 0%83µs ± 0%−18.92%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-4116µs ± 0%85µs ± 0%−26.78%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-4122µs ± 0%91µs ± 0%−25.47%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4140µs ± 0%111µs ± 0%−20.94%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4194µs ± 0%148µs ± 0%−23.94%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4136µs ± 0%116µs ± 0%−14.21%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4133µs ± 0%120µs ± 0%−9.90%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4142µs ± 0%119µs ± 0%−16.10%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4138µs ± 0%120µs ± 0%−13.25%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4139µs ± 0%127µs ± 0%−8.69%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-41.35ms ± 0%1.20ms ± 0%−11.35%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-41.24ms ± 0%1.23ms ± 0%−0.69%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-41.31ms ± 0%1.19ms ± 0%−9.12%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-41.30ms ± 0%1.22ms ± 0%−6.08%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-41.38ms ± 0%1.22ms ± 0%−11.76%(p=1.000 n=1+1)
 

@AndrewSisley
Copy link
Contributor

I feel unqualified to properly review this, but will note that I have looked at it.

shahzadlone
shahzadlone requested changes Jun 14, 2022
View reviewed changes
Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to write a Dockerfile =)

Made some suggestions, but my own dockerfile writing ability is a bit hazy at the moment.

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Lodek
Lodek reviewed Jun 14, 2022
View reviewed changes
Dockerfile
RUN make build

# Run stage
FROM gcr.io/distroless/base-debian11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: I've read about the distroless approach but never used it. Awesome to see it 🥳

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second that :)

@orpheuslummis orpheuslummis marked this pull request as ready for review June 14, 2022 21:50
fredcarle
fredcarle approved these changes Jun 16, 2022
View reviewed changes
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

That's a good starting point for our Dockerfile.

shahzadlone
shahzadlone approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for getting our first step of Docker in the door 😄.

@orpheuslummis orpheuslummis merged commit fc0c563 into develop Jun 17, 2022
@orpheuslummis orpheuslummis deleted the orpheus/chore/dockerfile branch June 17, 2022 11:11
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@orpheuslummis
chore: Add Dockerfile (sourcenetwork#517)
17e99ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lodek Lodek Lodek left review comments

@shahzadlone shahzadlone shahzadlone approved these changes

@fredcarle fredcarle fredcarle approved these changes

Assignees

@orpheuslummis orpheuslummis

Labels
action/no-benchmark Skips the action that runs the benchmark. ci/build This is issue is about the build or CI system, and the administration of it.
Projects
None yet
Milestone
DefraDB v0.3
Development

Successfully merging this pull request may close these issues.

Provide a Dockerfile
6 participants
@orpheuslummis @source-devs @AndrewSisley @fredcarle @Lodek @shahzadlone