chore: Enable linters exportloopref, nolintlint, whitespace

[orpheuslummis]

Relevant issue(s)

Resolves #536
Part of #487

Description

Adds simple linters: exportloopref, nolintlint, whitespace.

Removes from the list-of-linters-to-consider:

• megacheck as it is deprecated
• gci which is not needed because we enforce gofmt

A potentially controversial decision here is enabling the stylistic whitespace. https://github.com/ultraware/whitespace
This is a draft PR, your feedback is welcome.

I was curious about the list of linters Shahzad had built and this PR results from that.

Tasks

• I made sure the code is well commented, particularly hard-to-understand areas.
• I made sure the repository-held documentation is changed accordingly.
• I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
• I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

Test suite ran locally and on CI.

Specify the platform(s) on which this was tested:

• MacOS

[orpheuslummis]

• update [EPIC] Nice to have linters #487 before this is closed

[shahzadlone]

Appreciate this PR 😃! Thanks for taking the time to also remove the gci and megacheck, made some minor suggestions.

[codecov]

Codecov Report

Merging #535 (83dc4b2) into develop (bb08df0) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #535      +/-   ##
===========================================
- Coverage    54.42%   54.34%   -0.08%     
===========================================
  Files           97       97              
  Lines        13174    13149      -25     
===========================================
- Hits          7170     7146      -24     
+ Misses        5325     5324       -1     
  Partials       679      679              

Impacted Files	Coverage Δ
api/http/handler.go	100.00% <ø> (ø)
client/dockey.go	51.16% <ø> (ø)
datastore/badger/v3/datastore.go	33.92% <ø> (ø)
datastore/wrappedStore.go	62.77% <ø> (-0.27%)	⬇️
db/collection_delete.go	60.27% <ø> (-1.41%)	⬇️
db/collection_update.go	42.98% <ø> (-0.13%)	⬇️
db/fetcher/dag.go	56.79% <ø> (-0.53%)	⬇️
db/fetcher/fetcher.go	61.03% <ø> (ø)
db/fetcher/versioned.go	49.21% <ø> (-0.27%)	⬇️
net/dialer.go	3.12% <ø> (ø)
... and 17 more

[AndrewSisley]

I'm happy with this, but from memory someone in the team likes more whitespace than I do (including at top of functions maybe) - Only Shahzad is added to this PR atm, make sure the rest of the team is happy too.

[orpheuslummis]

I'm happy with this, but from memory someone in the team likes more whitespace than I do (including at top of functions maybe) - Only Shahzad is added to this PR atm, make sure the rest of the team is happy too.

I did request PR review from the database-team group. I'm assuming this sends email to everyone, and if my expectation is wrong I'd like to know :)

[AndrewSisley]

I did request PR review from the database-team group. I'm assuming this sends email to everyone, and if my expectation is wrong I'd like to know :)

Ah! I only see Shahzads name in the list of reviewers lol

[orpheuslummis]

For the record, Andy and I discussed and we figured out that when we request review from database-team, all members of database-team subsequently receive all notifications on a PR.

[fredcarle]

For the record, Andy and I discussed and we figured out that when we request review from database-team, all members of database-team subsequently receive all notifications on a PR.

Is that a bad thing?

[fredcarle]

I like almost everything about this. The rest I don't care. So overall that's a win in my book.

[orpheuslummis]

For the record, Andy and I discussed and we figured out that when we request review from database-team, all members of database-team subsequently receive all notifications on a PR.

Is that a bad thing?

IMO is a good thing

[shahzadlone]

LGTM. Thanks for doing all the requested changes!