Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Resolve failing HTTP API tests via cleanup #557

Merged
merged 1 commit into from
Jun 23, 2022
Merged

fix: Resolve failing HTTP API tests via cleanup #557

merged 1 commit into from
Jun 23, 2022

Conversation

orpheuslummis
Copy link
Contributor

@orpheuslummis orpheuslummis commented Jun 23, 2022 •
edited
Loading

Relevant issue(s)

Resolves #555

Description

Various tests of the HTTP API were failing because they were assuming env was defined (to value dev), which is the case in the normal execution order as some previous tests set the global to that value, but not in a random execution order of tests.

This PR simply, whenever it is required, sets the env value and cleans it up afterwards.

I suggest that a future PR should improve on the global env pattern, e.g. after the config PR merges...

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

Int. tests.

Specify the platform(s) on which this was tested:

  • MacOS

@orpheuslummis orpheuslummis added area/api Related to the external API component area/testing Related to any test or testing suite labels Jun 23, 2022
@orpheuslummis orpheuslummis added this to the DefraDB v0.3 milestone Jun 23, 2022
@orpheuslummis orpheuslummis requested a review from a team June 23, 2022 03:58
@orpheuslummis orpheuslummis self-assigned this Jun 23, 2022
@source-devs
Copy link

Benchmark Results

Summary

  • 113 Benchmarks successfully compared.
  • 104 Benchmarks were ✅ Better.
  • 9 Benchmarks were ❌ Worse .
  • 0 Benchmarks were ✨ Unchanged.
✅ See Better Results...
time/opdelta
_Collection_UserSimple_CreateMany_Sync_0_100-4264ms ± 0%249ms ± 0%−5.68%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_10-411.1ms ± 0%10.5ms ± 0%−5.38%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_100-4147ms ± 0%131ms ± 0%−10.78%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_1000-41.36s ± 0%1.12s ± 0%−17.99%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-449.8ms ± 0%44.9ms ± 0%−9.85%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_1000-4466ms ± 0%438ms ± 0%−5.86%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-45.08s ± 0%4.55s ± 0%−10.48%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4369µs ± 0%351µs ± 0%−4.99%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_100_100-44.16ms ± 0%3.58ms ± 0%−13.95%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_1000-443.4ms ± 0%38.7ms ± 0%−10.99%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4415µs ± 0%347µs ± 0%−16.35%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-44.18ms ± 0%3.84ms ± 0%−8.23%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-41.89ms ± 0%1.88ms ± 0%−0.74%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-425.7ms ± 0%23.6ms ± 0%−8.21%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4276µs ± 0%266µs ± 0%−3.59%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-41.98ms ± 0%1.88ms ± 0%−5.05%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-41.30ms ± 0%1.22ms ± 0%−6.28%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_1000-410.0ms ± 0%9.6ms ± 0%−3.85%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4478µs ± 0%433µs ± 0%−9.36%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-410.9ms ± 0%10.3ms ± 0%−5.46%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4421µs ± 0%388µs ± 0%−7.91%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4498µs ± 0%456µs ± 0%−8.45%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4460µs ± 0%444µs ± 0%−3.38%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-4725µs ± 0%680µs ± 0%−6.12%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4723µs ± 0%659µs ± 0%−8.75%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4666µs ± 0%643µs ± 0%−3.51%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4339µs ± 0%276µs ± 0%−18.55%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4324µs ± 0%277µs ± 0%−14.68%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4286µs ± 0%272µs ± 0%−4.92%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4524µs ± 0%407µs ± 0%−22.44%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-41.74ms ± 0%1.38ms ± 0%−20.92%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-413.3ms ± 0%12.8ms ± 0%−3.56%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-416.2µs ± 0%12.9µs ± 0%−19.95%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-418.8µs ± 0%14.9µs ± 0%−20.72%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-423.4µs ± 0%20.0µs ± 0%−14.49%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-425.7µs ± 0%19.9µs ± 0%−22.48%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4151µs ± 0%125µs ± 0%−16.92%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4196µs ± 0%131µs ± 0%−33.32%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4168µs ± 0%139µs ± 0%−17.50%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4189µs ± 0%155µs ± 0%−17.87%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4209µs ± 0%197µs ± 0%−6.03%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-415.6µs ± 0%14.5µs ± 0%−7.07%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-416.9µs ± 0%14.8µs ± 0%−12.03%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-418.4µs ± 0%15.2µs ± 0%−17.60%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-420.7µs ± 0%16.9µs ± 0%−18.19%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-425.5µs ± 0%20.8µs ± 0%−18.37%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4162µs ± 0%135µs ± 0%−17.00%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4157µs ± 0%152µs ± 0%−3.59%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4178µs ± 0%167µs ± 0%−6.37%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4247µs ± 0%218µs ± 0%−11.66%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-459.6µs ± 0%46.8µs ± 0%−21.52%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-466.4µs ± 0%53.2µs ± 0%−19.85%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-461.1µs ± 0%49.8µs ± 0%−18.51%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-463.6µs ± 0%54.1µs ± 0%−14.86%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-471.7µs ± 0%64.5µs ± 0%−10.01%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4450µs ± 0%352µs ± 0%−21.78%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4404µs ± 0%360µs ± 0%−11.01%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4441µs ± 0%388µs ± 0%−11.92%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4469µs ± 0%407µs ± 0%−13.21%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4558µs ± 0%480µs ± 0%−14.05%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-463.5µs ± 0%46.8µs ± 0%−26.25%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-465.5µs ± 0%55.9µs ± 0%−14.76%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-469.8µs ± 0%51.5µs ± 0%−26.20%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-469.7µs ± 0%52.8µs ± 0%−24.30%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-492.7µs ± 0%66.2µs ± 0%−28.64%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4496µs ± 0%360µs ± 0%−27.27%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4469µs ± 0%370µs ± 0%−21.11%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4507µs ± 0%377µs ± 0%−25.76%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4516µs ± 0%428µs ± 0%−17.12%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4688µs ± 0%502µs ± 0%−27.06%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4145µs ± 0%122µs ± 0%−16.27%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4147µs ± 0%129µs ± 0%−12.52%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4153µs ± 0%123µs ± 0%−19.75%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4150µs ± 0%124µs ± 0%−17.27%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4176µs ± 0%147µs ± 0%−16.67%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-41.41ms ± 0%1.24ms ± 0%−11.46%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-41.41ms ± 0%1.25ms ± 0%−11.36%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-41.35ms ± 0%1.28ms ± 0%−4.81%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4123µs ± 0%116µs ± 0%−5.29%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4139µs ± 0%126µs ± 0%−9.51%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4137µs ± 0%127µs ± 0%−7.08%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-41.34ms ± 0%1.26ms ± 0%−5.92%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-41.38ms ± 0%1.26ms ± 0%−8.52%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-41.35ms ± 0%1.28ms ± 0%−5.25%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-41.73ms ± 0%1.46ms ± 0%−15.94%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-412.3µs ± 0%9.5µs ± 0%−22.24%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-412.7µs ± 0%9.2µs ± 0%−27.77%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-411.6µs ± 0%11.6µs ± 0%−0.03%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-420.9µs ± 0%16.6µs ± 0%−20.43%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-4115µs ± 0%84µs ± 0%−26.59%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-4125µs ± 0%104µs ± 0%−17.07%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-4129µs ± 0%103µs ± 0%−20.40%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4155µs ± 0%130µs ± 0%−16.05%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4213µs ± 0%154µs ± 0%−27.54%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4147µs ± 0%121µs ± 0%−18.17%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4139µs ± 0%130µs ± 0%−6.44%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4144µs ± 0%125µs ± 0%−13.15%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4151µs ± 0%131µs ± 0%−13.50%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4146µs ± 0%128µs ± 0%−12.10%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-41.24ms ± 0%1.22ms ± 0%−1.78%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-41.26ms ± 0%1.17ms ± 0%−7.01%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-41.43ms ± 0%1.23ms ± 0%−14.31%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-41.43ms ± 0%1.30ms ± 0%−8.97%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-41.46ms ± 0%1.30ms ± 0%−10.61%(p=1.000 n=1+1)
 
❌ See Worse Results...
time/opdelta
_Collection_UserSimple_Read_Async_10_10-4264µs ± 0%268µs ± 0%+1.47%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-41.34ms ± 0%1.46ms ± 0%+8.97%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4172µs ± 0%181µs ± 0%+5.67%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-41.38ms ± 0%1.48ms ± 0%+7.06%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-41.56ms ± 0%1.58ms ± 0%+1.56%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4115µs ± 0%121µs ± 0%+5.26%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4144µs ± 0%145µs ± 0%+0.79%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-41.26ms ± 0%1.34ms ± 0%+6.37%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-414.2µs ± 0%14.2µs ± 0%+0.10%(p=1.000 n=1+1)
 
✨ See Unchanged Results...
time/opdelta
 
🐋 See Full Results...
develop.txtcurrent.txt
time/opdelta
pkg:collection goos:linux goarch:amd64
_Collection_UserSimple_CreateMany_Sync_0_10-411.6ms ± 0%11.1ms ± 0%−4.66%(p=1.000 n=1+1)
_Collection_UserSimple_CreateMany_Sync_0_100-4264ms ± 0%249ms ± 0%−5.68%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_10-411.1ms ± 0%10.5ms ± 0%−5.38%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_100-4147ms ± 0%131ms ± 0%−10.78%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_1000-41.36s ± 0%1.12s ± 0%−17.99%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-449.8ms ± 0%44.9ms ± 0%−9.85%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_1000-4466ms ± 0%438ms ± 0%−5.86%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-45.08s ± 0%4.55s ± 0%−10.48%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4369µs ± 0%351µs ± 0%−4.99%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_100_100-44.16ms ± 0%3.58ms ± 0%−13.95%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_1000-443.4ms ± 0%38.7ms ± 0%−10.99%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4415µs ± 0%347µs ± 0%−16.35%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-44.18ms ± 0%3.84ms ± 0%−8.23%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_10_10-4264µs ± 0%268µs ± 0%+1.47%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-41.89ms ± 0%1.88ms ± 0%−0.74%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-425.7ms ± 0%23.6ms ± 0%−8.21%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4276µs ± 0%266µs ± 0%−3.59%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-41.98ms ± 0%1.88ms ± 0%−5.05%(p=1.000 n=1+1)
pkg:query/simple goos:linux goarch:amd64
_Query_UserSimple_Query_Sync_10-4370µs ± 0%356µs ± 0%−3.63%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-41.30ms ± 0%1.22ms ± 0%−6.28%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_1000-410.0ms ± 0%9.6ms ± 0%−3.85%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4478µs ± 0%433µs ± 0%−9.36%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-41.34ms ± 0%1.46ms ± 0%+8.97%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-410.9ms ± 0%10.3ms ± 0%−5.46%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4421µs ± 0%388µs ± 0%−7.91%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4498µs ± 0%456µs ± 0%−8.45%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4460µs ± 0%444µs ± 0%−3.38%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-4725µs ± 0%680µs ± 0%−6.12%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4723µs ± 0%659µs ± 0%−8.75%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4666µs ± 0%643µs ± 0%−3.51%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4339µs ± 0%276µs ± 0%−18.55%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4324µs ± 0%277µs ± 0%−14.68%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4286µs ± 0%272µs ± 0%−4.92%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4524µs ± 0%407µs ± 0%−22.44%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-41.74ms ± 0%1.38ms ± 0%−20.92%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-413.3ms ± 0%12.8ms ± 0%−3.56%(p=1.000 n=1+1)
pkg:storage goos:linux goarch:amd64
_Storage_Simple_Read_Sync_1_10/ValueSize:0064-414.5µs ± 0%13.7µs ± 0%−5.65%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-416.2µs ± 0%12.9µs ± 0%−19.95%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-418.8µs ± 0%14.9µs ± 0%−20.72%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-423.4µs ± 0%20.0µs ± 0%−14.49%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-425.7µs ± 0%19.9µs ± 0%−22.48%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4151µs ± 0%125µs ± 0%−16.92%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4196µs ± 0%131µs ± 0%−33.32%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4168µs ± 0%139µs ± 0%−17.50%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4189µs ± 0%155µs ± 0%−17.87%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4209µs ± 0%197µs ± 0%−6.03%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-415.6µs ± 0%14.5µs ± 0%−7.07%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-416.9µs ± 0%14.8µs ± 0%−12.03%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-418.4µs ± 0%15.2µs ± 0%−17.60%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-420.7µs ± 0%16.9µs ± 0%−18.19%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-425.5µs ± 0%20.8µs ± 0%−18.37%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4162µs ± 0%135µs ± 0%−17.00%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4157µs ± 0%152µs ± 0%−3.59%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4172µs ± 0%181µs ± 0%+5.67%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4178µs ± 0%167µs ± 0%−6.37%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4247µs ± 0%218µs ± 0%−11.66%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-459.6µs ± 0%46.8µs ± 0%−21.52%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-466.4µs ± 0%53.2µs ± 0%−19.85%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-461.1µs ± 0%49.8µs ± 0%−18.51%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-463.6µs ± 0%54.1µs ± 0%−14.86%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-471.7µs ± 0%64.5µs ± 0%−10.01%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4450µs ± 0%352µs ± 0%−21.78%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4404µs ± 0%360µs ± 0%−11.01%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4441µs ± 0%388µs ± 0%−11.92%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4469µs ± 0%407µs ± 0%−13.21%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4558µs ± 0%480µs ± 0%−14.05%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-463.5µs ± 0%46.8µs ± 0%−26.25%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-465.5µs ± 0%55.9µs ± 0%−14.76%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-469.8µs ± 0%51.5µs ± 0%−26.20%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-469.7µs ± 0%52.8µs ± 0%−24.30%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-492.7µs ± 0%66.2µs ± 0%−28.64%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4496µs ± 0%360µs ± 0%−27.27%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4469µs ± 0%370µs ± 0%−21.11%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4507µs ± 0%377µs ± 0%−25.76%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4516µs ± 0%428µs ± 0%−17.12%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4688µs ± 0%502µs ± 0%−27.06%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4145µs ± 0%122µs ± 0%−16.27%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4147µs ± 0%129µs ± 0%−12.52%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4153µs ± 0%123µs ± 0%−19.75%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4150µs ± 0%124µs ± 0%−17.27%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4176µs ± 0%147µs ± 0%−16.67%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-41.41ms ± 0%1.24ms ± 0%−11.46%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-41.41ms ± 0%1.25ms ± 0%−11.36%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-41.35ms ± 0%1.28ms ± 0%−4.81%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-41.38ms ± 0%1.48ms ± 0%+7.06%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-41.56ms ± 0%1.58ms ± 0%+1.56%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4115µs ± 0%121µs ± 0%+5.26%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4123µs ± 0%116µs ± 0%−5.29%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4139µs ± 0%126µs ± 0%−9.51%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4137µs ± 0%127µs ± 0%−7.08%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4144µs ± 0%145µs ± 0%+0.79%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-41.26ms ± 0%1.34ms ± 0%+6.37%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-41.34ms ± 0%1.26ms ± 0%−5.92%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-41.38ms ± 0%1.26ms ± 0%−8.52%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-41.35ms ± 0%1.28ms ± 0%−5.25%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-41.73ms ± 0%1.46ms ± 0%−15.94%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-412.3µs ± 0%9.5µs ± 0%−22.24%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-412.7µs ± 0%9.2µs ± 0%−27.77%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-411.6µs ± 0%11.6µs ± 0%−0.03%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-414.2µs ± 0%14.2µs ± 0%+0.10%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-420.9µs ± 0%16.6µs ± 0%−20.43%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-4115µs ± 0%84µs ± 0%−26.59%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-4125µs ± 0%104µs ± 0%−17.07%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-4129µs ± 0%103µs ± 0%−20.40%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4155µs ± 0%130µs ± 0%−16.05%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4213µs ± 0%154µs ± 0%−27.54%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4147µs ± 0%121µs ± 0%−18.17%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4139µs ± 0%130µs ± 0%−6.44%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4144µs ± 0%125µs ± 0%−13.15%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4151µs ± 0%131µs ± 0%−13.50%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4146µs ± 0%128µs ± 0%−12.10%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-41.24ms ± 0%1.22ms ± 0%−1.78%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-41.26ms ± 0%1.17ms ± 0%−7.01%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-41.43ms ± 0%1.23ms ± 0%−14.31%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-41.43ms ± 0%1.30ms ± 0%−8.97%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-41.46ms ± 0%1.30ms ± 0%−10.61%(p=1.000 n=1+1)
 

shahzadlone
shahzadlone approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

AndrewSisley
AndrewSisley approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - thanks Orpheus!

fredcarle
fredcarle approved these changes Jun 23, 2022
View reviewed changes
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@orpheuslummis orpheuslummis merged commit 1807085 into develop Jun 23, 2022
@orpheuslummis orpheuslummis deleted the orpheus/fix/env-cleanup-handlerfuncs branch June 23, 2022 15:32
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@orpheuslummis
fix: Resolve failing HTTP API tests via cleanup (sourcenetwork#557)
e40fd02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewSisley AndrewSisley AndrewSisley approved these changes

@shahzadlone shahzadlone shahzadlone approved these changes

@fredcarle fredcarle fredcarle approved these changes

Assignees

@orpheuslummis orpheuslummis

Labels
area/api Related to the external API component area/testing Related to any test or testing suite
Projects
None yet
Milestone
DefraDB v0.3
Development

Successfully merging this pull request may close these issues.

Failing tests of handlerfuncs_test.go when randomizing execution order of tests
5 participants
@orpheuslummis @source-devs @fredcarle @shahzadlone @AndrewSisley