Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Change $eq to _eq in the failing test. #576

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

shahzadlone
Copy link
Member

Relevant issue(s)

Resolves #575

Description

Fix the broken test on develop.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

make test

Specify the platform(s) on which this was tested:

  • Manjaro Linux on WSL2

@shahzadlone shahzadlone added the action/no-benchmark Skips the action that runs the benchmark. label Jun 30, 2022
@shahzadlone shahzadlone added this to the DefraDB v0.3 milestone Jun 30, 2022
@shahzadlone shahzadlone requested a review from a team June 30, 2022 12:19
@shahzadlone shahzadlone self-assigned this Jun 30, 2022
@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #576 (528ecb7) into develop (b16bf3a) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #576      +/-   ##
===========================================
+ Coverage    56.88%   56.98%   +0.10%     
===========================================
  Files          121      121              
  Lines        14221    14243      +22     
===========================================
+ Hits          8089     8116      +27     
+ Misses        5418     5413       -5     
  Partials       714      714              
Impacted Files Coverage Δ
query/graphql/planner/sum.go 81.69% <100.00%> (+6.89%) ⬆️

@shahzadlone shahzadlone merged commit bab8bd3 into develop Jun 30, 2022
@shahzadlone shahzadlone deleted the shahzad/fix/broken-eq-in-test branch June 30, 2022 12:29
shahzadlone added a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/no-benchmark Skips the action that runs the benchmark.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Develop had a failing test that wasn't caught in PR CI checks
1 participant