Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Change sortNode to orderNode. #591

Merged
merged 9 commits into from
Jul 6, 2022

Conversation

shahzadlone
Copy link
Member

@shahzadlone shahzadlone commented Jul 5, 2022

Relevant issue(s)

Resolves #590

Description

Changes sortNode to orderNode, and some file names and other instances for consistency.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

make test & CI

Specify the platform(s) on which this was tested:

  • Manjaro WSL2

@shahzadlone shahzadlone added the action/no-benchmark Skips the action that runs the benchmark. label Jul 5, 2022
@shahzadlone shahzadlone added this to the DefraDB v0.3 milestone Jul 5, 2022
@shahzadlone shahzadlone self-assigned this Jul 5, 2022
@shahzadlone shahzadlone changed the title wip: Change sortNode to orderNode. wip: Change sortNode to orderNode. Jul 5, 2022
@shahzadlone shahzadlone changed the title wip: Change sortNode to orderNode. refactor: Change sortNode to orderNode. Jul 5, 2022
@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #591 (a4be02f) into develop (0f54d22) will not change coverage.
The diff coverage is 87.50%.

❗ Current head a4be02f differs from pull request most recent head 2cc94b1. Consider uploading reports for the commit 2cc94b1 to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #591   +/-   ##
========================================
  Coverage    56.17%   56.17%           
========================================
  Files          121      121           
  Lines        14276    14276           
========================================
  Hits          8020     8020           
  Misses        5557     5557           
  Partials       699      699           
Impacted Files Coverage Δ
db/container/container.go 84.61% <ø> (ø)
query/graphql/planner/explain.go 63.79% <ø> (ø)
query/graphql/planner/order.go 83.50% <80.95%> (ø)
query/graphql/parser/filter.go 62.06% <88.88%> (ø)
query/graphql/parser/query.go 80.18% <100.00%> (ø)
query/graphql/planner/planner.go 73.58% <100.00%> (ø)
query/graphql/planner/select.go 75.00% <100.00%> (ø)

Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a small non-blocking suggestion.

query/graphql/planner/select.go Outdated Show resolved Hide resolved
@shahzadlone shahzadlone merged commit 2c920a1 into develop Jul 6, 2022
@shahzadlone shahzadlone deleted the lone/refactor/sort-to-order branch July 6, 2022 23:49
shahzadlone added a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
- Relevant issue: Resolves sourcenetwork#590

- Description:
Changes `sortNode` to `orderNode`, and some file names and other instances for consistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/no-benchmark Skips the action that runs the benchmark.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change sort terminology to order terminology.
2 participants