test: Add tests for default properties #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
area/testing
fredcarle
approved these changes
Jul 8, 2022
|
|
||
| func TestQuerySimpleWithSomeDefaultValues(t *testing.T) { | ||
| test := testUtils.QueryTestCase{ | ||
| Description: "...", |
There was a problem hiding this comment.
question: did you omit the description on purpose?
There was a problem hiding this comment.
Nope I did not :)
- desc
| // A document with nil fields should be returned. | ||
| func TestQuerySimpleWithDefaultValue(t *testing.T) { | ||
| test := testUtils.QueryTestCase{ | ||
| Description: "...", |
There was a problem hiding this comment.
question: same as above.
Comment on lines
+172
to
+177
| Docs: map[int][]string{ | ||
| 0: { | ||
| `{ }`, | ||
| }, | ||
| }, | ||
| Results: []map[string]interface{}{}, |
There was a problem hiding this comment.
though: The way I interpret this is that you add an empty object to the database which from the expected result tells me that an empty object will be discarded. Am I thinking about this right? Otherwise I would expect this to be the result:
{
"Name": nil,
"Email": nil,
"Age": nil,
"HeightM": nil,
"Verified": nil,
}
There was a problem hiding this comment.
Correct - there is a comment linked to an issue regarding this at the top of the test function.
AndrewSisley
force-pushed
the
sisley/test/I412-default-prop-tests
branch
2 times, most recently
from
5ccf755
to
8bec1ac
Compare
It is not true when a doc has been read, but when the whole span is complete
Need two string fields for an upcoming test case
AndrewSisley
force-pushed
the
sisley/test/I412-default-prop-tests
branch
from
8bec1ac
to
aad0efc
Compare
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
* Rename variable It is not true when a doc has been read, but when the whole span is complete * Add email field to simple test schema Need two string fields for an upcoming test case * Add tests for default properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #412
Description
Adds tests for default properties. Had to change a few test cids when adding a new field to a test schema, as that affects them. Includes a failing/documentation test linked to an issue (also noted in issue).