Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update gitignore to include cmd folders #617

Merged
merged 1 commit into from
Jul 11, 2022
Merged

chore: Update gitignore to include cmd folders #617

merged 1 commit into from
Jul 11, 2022

Conversation

jsimnz
Copy link
Member

@jsimnz jsimnz commented Jul 10, 2022 •
edited
Loading

Relevant issue(s)

Resolves #616

Description

Simply updates .gitignore to include binaries generated manually within the cmd/<binary> folder.

(replace) Include a summary of the changes. List the issue(s) it solves in the section above, and
create one if none exists. Include relevant motivation and context. Detail new dependencies required for this change.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

Manually

Specify the platform(s) on which this was tested:

  • (modify the list accordingly)
  • Debian Linux

@jsimnz jsimnz added meta/dev These issues related to the meta elements of the code base like dev flow, repo logistics, and PM action/no-benchmark Skips the action that runs the benchmark. labels Jul 10, 2022
shahzadlone
shahzadlone approved these changes Jul 10, 2022
View reviewed changes
Copy link
Member

@shahzadlone shahzadlone left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Would just make the first letter of updated capital in the commit title.

@jsimnz jsimnz changed the title chore: updated gitignore to include cmd folders chore: Updated gitignore to include cmd folders Jul 11, 2022
@jsimnz
Copy link
Member Author

jsimnz commented Jul 11, 2022

LGTM, Would just make the first letter of updated capital in the commit title.

Updated "updated" to "Updated" 🤣

@shahzadlone
Copy link
Member

LGTM, Would just make the first letter of updated capital in the commit title.

Updated "updated" to "Updated" 🤣

For more brownie points, update Updated to Update.

@jsimnz jsimnz changed the title chore: Updated gitignore to include cmd folders chore: Update gitignore to include cmd folders Jul 11, 2022
@jsimnz jsimnz merged commit e2091fc into develop Jul 11, 2022
@jsimnz jsimnz deleted the jsimnz/chore/I616-cmd-gitignore branch July 11, 2022 13:24
@orpheuslummis
Copy link
Contributor

thanks! forgot about that in the PR that introduced cmd...

shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@jsimnz
chore: Update gitignore to include cmd folders (sourcenetwork#617)
2c724e1 
update gitignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzadlone shahzadlone shahzadlone approved these changes

Assignees

@jsimnz jsimnz

Labels
action/no-benchmark Skips the action that runs the benchmark. meta/dev These issues related to the meta elements of the code base like dev flow, repo logistics, and PM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new cmd folder is missing from the gitignore list
3 participants
@jsimnz @shahzadlone @orpheuslummis