fix: Avoid populating order.ordering with empties.
#618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzadlone
added
bug
shahzadlone
force-pushed
the
lone/fix/ordering-populated-by-empties
branch
from
85feaec
to
64c5dc2
Compare
AndrewSisley
approved these changes
Jul 11, 2022
We don't do mistakes, just happy accidents haha. Was a fun learning opportunity to watch out for those for myself aswell. |
Hunch was corrent, as mentioned in the standup it was indeed a `make` where it would populate the array with empties and then again append on top of them.)
suggestion on another PR.
shahzadlone
force-pushed
the
lone/fix/ordering-populated-by-empties
branch
from
64c5dc2
to
e7eb47a
Compare
shahzadlone
added a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
- Resolves: sourcenetwork#589 - Description: Hunch mentioned in last week's meeting was correct, it was indeed a `make` where it would populate the array with empties and then append being called on top of it. Also removed the function `IsEmpty()`, we used to check for empty elements previously which was introduced in sourcenetwork#481.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #589
Description
Hunch mentioned in last week's meeting was correct, it was indeed a
makewhere it would populate the array with empties and then append being called on top of it.Also removed the function
IsEmpty(), we used to check for empty elements previously which was introduced in #481.Tasks
How has this been tested?
make testand CI checks.Specify the platform(s) on which this was tested: