Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Increase system's open file limit in integration tests #627

Merged
merged 1 commit into from
Jul 13, 2022
Merged

fix: Increase system's open file limit in integration tests #627

merged 1 commit into from
Jul 13, 2022

Conversation

orpheuslummis
Copy link
Contributor

@orpheuslummis orpheuslummis commented Jul 12, 2022 •
edited
Loading

Relevant issue(s)

Resolves #623

Description

Backports code from Go 1.19 in the integration test initialization to increase open file limit to fix related error when running the tests on systems that are configured (for legacy reasons) to have very low file limit.

Draft PR as experimental and potentially controversial?

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

Local

Specify the platform(s) on which this was tested:

  • Debian Linux
  • MacOS

@orpheuslummis orpheuslummis added bug Something isn't working area/testing Related to any test or testing suite labels Jul 12, 2022
@orpheuslummis orpheuslummis added this to the DefraDB v0.3 milestone Jul 12, 2022
@orpheuslummis orpheuslummis self-assigned this Jul 12, 2022
@orpheuslummis orpheuslummis requested a review from a team July 12, 2022 20:29
@source-devs
Copy link

Benchmark Results

Summary

  • 113 Benchmarks successfully compared.
  • 84 Benchmarks were ✅ Better.
  • 29 Benchmarks were ❌ Worse .
  • 0 Benchmarks were ✨ Unchanged.
✅ See Better Results...
time/opdelta
_Collection_UserSimple_CreateMany_Sync_0_100-4257ms ± 0%238ms ± 0%−7.33%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_10-410.6ms ± 0%10.4ms ± 0%−1.65%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_100_100-43.92ms ± 0%3.82ms ± 0%−2.65%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_1000-442.1ms ± 0%41.3ms ± 0%−1.98%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4381µs ± 0%352µs ± 0%−7.64%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-43.96ms ± 0%3.87ms ± 0%−2.23%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_10_10-4257µs ± 0%252µs ± 0%−1.98%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-41.83ms ± 0%1.78ms ± 0%−2.64%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-41.90ms ± 0%1.82ms ± 0%−4.09%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-41.30ms ± 0%1.09ms ± 0%−15.91%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_1000-49.28ms ± 0%9.03ms ± 0%−2.61%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4539µs ± 0%447µs ± 0%−17.02%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-41.57ms ± 0%1.25ms ± 0%−20.35%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-410.3ms ± 0%9.5ms ± 0%−8.14%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4490µs ± 0%397µs ± 0%−18.98%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4509µs ± 0%444µs ± 0%−12.72%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4449µs ± 0%443µs ± 0%−1.29%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-4751µs ± 0%640µs ± 0%−14.85%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4716µs ± 0%667µs ± 0%−6.85%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4441µs ± 0%411µs ± 0%−6.64%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-41.30ms ± 0%1.23ms ± 0%−5.77%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-410.0ms ± 0%9.6ms ± 0%−4.68%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4333µs ± 0%297µs ± 0%−10.74%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4308µs ± 0%299µs ± 0%−2.74%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-414.2µs ± 0%13.6µs ± 0%−4.00%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-415.0µs ± 0%14.1µs ± 0%−5.54%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-416.6µs ± 0%15.7µs ± 0%−5.08%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4131µs ± 0%129µs ± 0%−1.26%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4130µs ± 0%128µs ± 0%−2.08%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4146µs ± 0%144µs ± 0%−1.47%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4181µs ± 0%157µs ± 0%−13.28%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4212µs ± 0%190µs ± 0%−10.28%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-414.7µs ± 0%14.6µs ± 0%−0.68%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-416.0µs ± 0%15.1µs ± 0%−6.12%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-416.4µs ± 0%15.2µs ± 0%−7.43%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-418.8µs ± 0%17.0µs ± 0%−9.79%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-421.7µs ± 0%20.4µs ± 0%−5.78%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4137µs ± 0%134µs ± 0%−2.58%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4145µs ± 0%138µs ± 0%−4.71%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4161µs ± 0%146µs ± 0%−9.37%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4170µs ± 0%155µs ± 0%−8.68%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4202µs ± 0%201µs ± 0%−0.43%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-448.3µs ± 0%45.4µs ± 0%−6.07%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-451.5µs ± 0%45.5µs ± 0%−11.58%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-454.3µs ± 0%53.3µs ± 0%−1.91%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-473.6µs ± 0%66.9µs ± 0%−9.12%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4378µs ± 0%358µs ± 0%−5.22%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4420µs ± 0%351µs ± 0%−16.37%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4377µs ± 0%372µs ± 0%−1.31%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4401µs ± 0%399µs ± 0%−0.54%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4520µs ± 0%482µs ± 0%−7.36%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-445.8µs ± 0%45.4µs ± 0%−0.82%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-471.9µs ± 0%66.3µs ± 0%−7.72%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4361µs ± 0%343µs ± 0%−5.00%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4365µs ± 0%341µs ± 0%−6.69%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4361µs ± 0%361µs ± 0%−0.01%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4520µs ± 0%480µs ± 0%−7.63%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4132µs ± 0%116µs ± 0%−12.35%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4118µs ± 0%116µs ± 0%−1.29%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4123µs ± 0%122µs ± 0%−0.94%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-41.17ms ± 0%1.14ms ± 0%−2.54%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-41.34ms ± 0%1.20ms ± 0%−10.69%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-41.43ms ± 0%1.21ms ± 0%−15.42%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-41.46ms ± 0%1.22ms ± 0%−16.22%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-41.40ms ± 0%1.38ms ± 0%−1.84%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4114µs ± 0%109µs ± 0%−4.86%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4116µs ± 0%112µs ± 0%−3.93%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4123µs ± 0%120µs ± 0%−2.70%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4126µs ± 0%118µs ± 0%−6.92%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4139µs ± 0%136µs ± 0%−2.01%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-41.20ms ± 0%1.18ms ± 0%−1.74%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-411.1µs ± 0%9.5µs ± 0%−14.77%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-411.5µs ± 0%11.3µs ± 0%−1.06%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-416.1µs ± 0%14.6µs ± 0%−9.33%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-487.6µs ± 0%84.4µs ± 0%−3.62%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-4102µs ± 0%94µs ± 0%−7.56%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4143µs ± 0%119µs ± 0%−17.10%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4176µs ± 0%156µs ± 0%−11.40%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4127µs ± 0%120µs ± 0%−5.72%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4131µs ± 0%128µs ± 0%−2.66%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-41.23ms ± 0%1.23ms ± 0%−0.01%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-41.26ms ± 0%1.21ms ± 0%−3.87%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-41.30ms ± 0%1.27ms ± 0%−2.52%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-41.57ms ± 0%1.29ms ± 0%−17.70%(p=1.000 n=1+1)
 
❌ See Worse Results...
time/opdelta
_Collection_UserSimple_Create_Sync_0_100-4107ms ± 0%110ms ± 0%+3.02%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_1000-41.02s ± 0%1.05s ± 0%+2.88%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-447.1ms ± 0%53.2ms ± 0%+12.92%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_1000-4465ms ± 0%524ms ± 0%+12.75%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-44.84s ± 0%5.02s ± 0%+3.71%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4361µs ± 0%363µs ± 0%+0.52%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-423.0ms ± 0%23.7ms ± 0%+3.27%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4264µs ± 0%265µs ± 0%+0.22%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4655µs ± 0%668µs ± 0%+1.94%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4298µs ± 0%302µs ± 0%+1.46%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-419.7µs ± 0%19.8µs ± 0%+0.50%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-447.7µs ± 0%48.4µs ± 0%+1.44%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-443.7µs ± 0%46.5µs ± 0%+6.40%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-445.5µs ± 0%45.8µs ± 0%+0.76%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-452.2µs ± 0%52.8µs ± 0%+1.19%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4402µs ± 0%407µs ± 0%+1.16%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4121µs ± 0%129µs ± 0%+6.81%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4134µs ± 0%136µs ± 0%+1.24%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-41.12ms ± 0%1.14ms ± 0%+1.81%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-41.11ms ± 0%1.19ms ± 0%+7.57%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-41.17ms ± 0%1.23ms ± 0%+5.09%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-41.32ms ± 0%1.37ms ± 0%+4.35%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-48.86µs ± 0%9.00µs ± 0%+1.57%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-48.87µs ± 0%9.15µs ± 0%+3.18%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-4104µs ± 0%107µs ± 0%+2.85%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4122µs ± 0%125µs ± 0%+2.20%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4126µs ± 0%129µs ± 0%+2.56%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4126µs ± 0%135µs ± 0%+7.14%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-41.23ms ± 0%1.27ms ± 0%+3.46%(p=1.000 n=1+1)
 
✨ See Unchanged Results...
time/opdelta
 
🐋 See Full Results...
develop.txtcurrent.txt
time/opdelta
pkg:collection goos:linux goarch:amd64
_Collection_UserSimple_CreateMany_Sync_0_10-411.5ms ± 0%11.8ms ± 0%+2.53%(p=1.000 n=1+1)
_Collection_UserSimple_CreateMany_Sync_0_100-4257ms ± 0%238ms ± 0%−7.33%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_10-410.6ms ± 0%10.4ms ± 0%−1.65%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_100-4107ms ± 0%110ms ± 0%+3.02%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_1000-41.02s ± 0%1.05s ± 0%+2.88%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-447.1ms ± 0%53.2ms ± 0%+12.92%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_1000-4465ms ± 0%524ms ± 0%+12.75%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-44.84s ± 0%5.02s ± 0%+3.71%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4361µs ± 0%363µs ± 0%+0.52%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_100_100-43.92ms ± 0%3.82ms ± 0%−2.65%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_1000-442.1ms ± 0%41.3ms ± 0%−1.98%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4381µs ± 0%352µs ± 0%−7.64%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-43.96ms ± 0%3.87ms ± 0%−2.23%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_10_10-4257µs ± 0%252µs ± 0%−1.98%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-41.83ms ± 0%1.78ms ± 0%−2.64%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-423.0ms ± 0%23.7ms ± 0%+3.27%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4264µs ± 0%265µs ± 0%+0.22%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-41.90ms ± 0%1.82ms ± 0%−4.09%(p=1.000 n=1+1)
pkg:query/simple goos:linux goarch:amd64
_Query_UserSimple_Query_Sync_10-4467µs ± 0%368µs ± 0%−21.16%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-41.30ms ± 0%1.09ms ± 0%−15.91%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_1000-49.28ms ± 0%9.03ms ± 0%−2.61%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4539µs ± 0%447µs ± 0%−17.02%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-41.57ms ± 0%1.25ms ± 0%−20.35%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-410.3ms ± 0%9.5ms ± 0%−8.14%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4490µs ± 0%397µs ± 0%−18.98%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4509µs ± 0%444µs ± 0%−12.72%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4449µs ± 0%443µs ± 0%−1.29%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-4751µs ± 0%640µs ± 0%−14.85%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4716µs ± 0%667µs ± 0%−6.85%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4655µs ± 0%668µs ± 0%+1.94%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4441µs ± 0%411µs ± 0%−6.64%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-41.30ms ± 0%1.23ms ± 0%−5.77%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-410.0ms ± 0%9.6ms ± 0%−4.68%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4333µs ± 0%297µs ± 0%−10.74%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4308µs ± 0%299µs ± 0%−2.74%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4298µs ± 0%302µs ± 0%+1.46%(p=1.000 n=1+1)
pkg:storage goos:linux goarch:amd64
_Storage_Simple_Read_Sync_1_10/ValueSize:0064-412.7µs ± 0%12.5µs ± 0%−1.45%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-414.2µs ± 0%13.6µs ± 0%−4.00%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-415.0µs ± 0%14.1µs ± 0%−5.54%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-416.6µs ± 0%15.7µs ± 0%−5.08%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-419.7µs ± 0%19.8µs ± 0%+0.50%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4131µs ± 0%129µs ± 0%−1.26%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4130µs ± 0%128µs ± 0%−2.08%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4146µs ± 0%144µs ± 0%−1.47%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4181µs ± 0%157µs ± 0%−13.28%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4212µs ± 0%190µs ± 0%−10.28%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-414.7µs ± 0%14.6µs ± 0%−0.68%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-416.0µs ± 0%15.1µs ± 0%−6.12%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-416.4µs ± 0%15.2µs ± 0%−7.43%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-418.8µs ± 0%17.0µs ± 0%−9.79%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-421.7µs ± 0%20.4µs ± 0%−5.78%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4137µs ± 0%134µs ± 0%−2.58%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4145µs ± 0%138µs ± 0%−4.71%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4161µs ± 0%146µs ± 0%−9.37%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4170µs ± 0%155µs ± 0%−8.68%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4202µs ± 0%201µs ± 0%−0.43%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-448.3µs ± 0%45.4µs ± 0%−6.07%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-451.5µs ± 0%45.5µs ± 0%−11.58%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-447.7µs ± 0%48.4µs ± 0%+1.44%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-454.3µs ± 0%53.3µs ± 0%−1.91%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-473.6µs ± 0%66.9µs ± 0%−9.12%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4378µs ± 0%358µs ± 0%−5.22%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4420µs ± 0%351µs ± 0%−16.37%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4377µs ± 0%372µs ± 0%−1.31%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4401µs ± 0%399µs ± 0%−0.54%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4520µs ± 0%482µs ± 0%−7.36%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-443.7µs ± 0%46.5µs ± 0%+6.40%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-445.8µs ± 0%45.4µs ± 0%−0.82%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-445.5µs ± 0%45.8µs ± 0%+0.76%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-452.2µs ± 0%52.8µs ± 0%+1.19%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-471.9µs ± 0%66.3µs ± 0%−7.72%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4361µs ± 0%343µs ± 0%−5.00%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4365µs ± 0%341µs ± 0%−6.69%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4361µs ± 0%361µs ± 0%−0.01%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4402µs ± 0%407µs ± 0%+1.16%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4520µs ± 0%480µs ± 0%−7.63%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4132µs ± 0%116µs ± 0%−12.35%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4118µs ± 0%116µs ± 0%−1.29%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4123µs ± 0%122µs ± 0%−0.94%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4121µs ± 0%129µs ± 0%+6.81%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4134µs ± 0%136µs ± 0%+1.24%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-41.17ms ± 0%1.14ms ± 0%−2.54%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-41.34ms ± 0%1.20ms ± 0%−10.69%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-41.43ms ± 0%1.21ms ± 0%−15.42%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-41.46ms ± 0%1.22ms ± 0%−16.22%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-41.40ms ± 0%1.38ms ± 0%−1.84%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4114µs ± 0%109µs ± 0%−4.86%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4116µs ± 0%112µs ± 0%−3.93%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4123µs ± 0%120µs ± 0%−2.70%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4126µs ± 0%118µs ± 0%−6.92%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4139µs ± 0%136µs ± 0%−2.01%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-41.12ms ± 0%1.14ms ± 0%+1.81%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-41.11ms ± 0%1.19ms ± 0%+7.57%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-41.20ms ± 0%1.18ms ± 0%−1.74%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-41.17ms ± 0%1.23ms ± 0%+5.09%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-41.32ms ± 0%1.37ms ± 0%+4.35%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-48.86µs ± 0%9.00µs ± 0%+1.57%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-48.87µs ± 0%9.15µs ± 0%+3.18%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-411.1µs ± 0%9.5µs ± 0%−14.77%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-411.5µs ± 0%11.3µs ± 0%−1.06%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-416.1µs ± 0%14.6µs ± 0%−9.33%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-487.6µs ± 0%84.4µs ± 0%−3.62%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-4102µs ± 0%94µs ± 0%−7.56%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-4104µs ± 0%107µs ± 0%+2.85%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4143µs ± 0%119µs ± 0%−17.10%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4176µs ± 0%156µs ± 0%−11.40%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4127µs ± 0%120µs ± 0%−5.72%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4122µs ± 0%125µs ± 0%+2.20%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4131µs ± 0%128µs ± 0%−2.66%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4126µs ± 0%129µs ± 0%+2.56%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4126µs ± 0%135µs ± 0%+7.14%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-41.23ms ± 0%1.27ms ± 0%+3.46%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-41.23ms ± 0%1.23ms ± 0%−0.01%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-41.26ms ± 0%1.21ms ± 0%−3.87%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-41.30ms ± 0%1.27ms ± 0%−2.52%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-41.57ms ± 0%1.29ms ± 0%−17.70%(p=1.000 n=1+1)
 

AndrewSisley
AndrewSisley approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy so long as we are sure this will not run in production (might be worth checking that if unsure by adding a panic on the first line and then spinning up a server with go install and defra start)

@orpheuslummis
Copy link
Contributor Author

@shahzadlone if you could replicate the issue you reported and confirm this solves it, that'd be useful to know!

@orpheuslummis
Copy link
Contributor Author

Happy so long as we are sure this will not run in production (might be worth checking that if unsure by adding a panic on the first line and then spinning up a server with go install and defra start)

I confirm that it doesn't crash when doing that. The tests are not imported by defradb

@orpheuslummis orpheuslummis marked this pull request as ready for review July 12, 2022 22:30
@AndrewSisley
Copy link
Contributor

I confirm that it doesn't crash when doing that. The tests are not imported by defradb

Of course it doesn't - I was being an idiot and forgot each dir gets compiled separately in go (and tests are not exceptions). Sorry for your time, and feel free to call me an idiot next time I say something like this :)

@orpheuslummis
Copy link
Contributor Author

I'm happy to do quick checks like that as it "turns the logic into intuition", at least once.

Agreed that it's good to help teammates to spend efforts towards most important/useful activities. :)

shahzadlone
shahzadlone approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that the file limit error disappears (did 3 runs to test).

Thanks Orpheee!

@shahzadlone shahzadlone added the action/no-benchmark Skips the action that runs the benchmark. label Jul 13, 2022
@orpheuslummis orpheuslummis merged commit 4bafe70 into develop Jul 13, 2022
@orpheuslummis orpheuslummis deleted the orpheus/fix/test-file-limit branch July 13, 2022 15:57
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@orpheuslummis
fix: Increase system's open files limit in integration tests (sourcen…
09fcf2b 
…etwork#627)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewSisley AndrewSisley AndrewSisley approved these changes

@shahzadlone shahzadlone shahzadlone approved these changes

@fredcarle fredcarle fredcarle approved these changes

Assignees

@orpheuslummis orpheuslummis

Labels
action/no-benchmark Skips the action that runs the benchmark. area/testing Related to any test or testing suite bug Something isn't working
Projects
None yet
Milestone
DefraDB v0.3
Development

Successfully merging this pull request may close these issues.

Change detection random errors despite CI passing (most of the times)
5 participants
@orpheuslummis @source-devs @AndrewSisley @fredcarle @shahzadlone