Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fix formatting of tests with no extra brackets #643

Merged
merged 3 commits into from
Jul 18, 2022
Merged

test: Fix formatting of tests with no extra brackets #643

merged 3 commits into from
Jul 18, 2022

Conversation

shahzadlone
Copy link
Member

@shahzadlone shahzadlone commented Jul 18, 2022 •
edited
Loading

Relevant issue(s)

Resolves #642

Description

Format test file code in a consistent manner, with proper indent style and remove the extra brackets.

All files are under integration tests.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

CI + Local

Specify the platform(s) on which this was tested:

  • Arch Linux

@shahzadlone shahzadlone added area/testing Related to any test or testing suite code quality Related to improving code quality labels Jul 18, 2022
@shahzadlone shahzadlone added this to the DefraDB v0.3 milestone Jul 18, 2022
@shahzadlone shahzadlone self-assigned this Jul 18, 2022
@shahzadlone shahzadlone requested a review from a team July 18, 2022 04:30
@shahzadlone shahzadlone added the action/no-benchmark Skips the action that runs the benchmark. label Jul 18, 2022
@sourcenetwork sourcenetwork deleted a comment from source-devs Jul 18, 2022
@sourcenetwork sourcenetwork deleted a comment from source-devs Jul 18, 2022
AndrewSisley
AndrewSisley approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzadlone shahzadlone merged commit f1beb0a into develop Jul 18, 2022
@shahzadlone shahzadlone deleted the lone/test/remove-extra-brackets-in-tests branch July 18, 2022 13:44
@shahzadlone shahzadlone restored the lone/test/remove-extra-brackets-in-tests branch July 18, 2022 13:45
@shahzadlone shahzadlone deleted the lone/test/remove-extra-brackets-in-tests branch July 18, 2022 13:55
shahzadlone added a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@shahzadlone
test: Fix formatting of tests with no extra brackets (sourcenetwork#643)
1baf8b1 
- Resolves sourcenetwork#642 

- Description: Format test file code in a consistent manner, with proper indent style, and remove the extra brackets.

Note: All changed files are under integration tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewSisley AndrewSisley AndrewSisley approved these changes

Assignees

@shahzadlone shahzadlone

Labels
action/no-benchmark Skips the action that runs the benchmark. area/testing Related to any test or testing suite code quality Related to improving code quality
Projects
None yet
Milestone
DefraDB v0.3
Development

Successfully merging this pull request may close these issues.

fix inconsistent integration test formatting
2 participants
@shahzadlone @AndrewSisley