Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Consider --logoutput CLI flag properly #645

Merged
merged 2 commits into from
Jul 19, 2022
Merged

fix: Consider --logoutput CLI flag properly #645

merged 2 commits into from
Jul 19, 2022

Conversation

orpheuslummis
Copy link
Contributor

@orpheuslummis orpheuslummis commented Jul 19, 2022 •
edited
Loading

Relevant issue(s)

Resolves #644

Description

This is a one-line fix... https://github.com/sourcenetwork/defradb/compare/orpheus/fix/config-cli?expand=1#diff-f95036fc6ff63eb5fcf251353f47b191fa8a2d927d37eacbb51e47e74e5f71f4R108

Viper wasn't binding to the key because of a typo.

Otherwise the PR renames Config.Logging to Config.Log which I suggest is clearer. This way, for example, it's possible to configure loglevel like DEFRA_LOG_LEVEL=debug instead of DEFRA_LOGGING_LEVEL=debug.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

CI

Specify the platform(s) on which this was tested:

  • MacOS

@orpheuslummis orpheuslummis added area/cli Related to the CLI binary area/config Related to configuration labels Jul 19, 2022
@orpheuslummis orpheuslummis added this to the DefraDB v0.3 milestone Jul 19, 2022
@orpheuslummis orpheuslummis requested a review from a team July 19, 2022 21:24
@orpheuslummis orpheuslummis self-assigned this Jul 19, 2022
@source-devs
Copy link

Benchmark Results

Summary

  • 113 Benchmarks successfully compared.
  • 87 Benchmarks were ✅ Better.
  • 26 Benchmarks were ❌ Worse .
  • 0 Benchmarks were ✨ Unchanged.
✅ See Better Results...
time/opdelta
_Collection_UserSimple_CreateMany_Sync_0_100-4256ms ± 0%218ms ± 0%−14.76%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_10-410.2ms ± 0%10.0ms ± 0%−1.79%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_100-4111ms ± 0%99ms ± 0%−10.77%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_1000-41.12s ± 0%1.00s ± 0%−11.08%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-446.9ms ± 0%44.5ms ± 0%−5.11%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_1000-4469ms ± 0%434ms ± 0%−7.37%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-44.76s ± 0%4.46s ± 0%−6.29%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4344µs ± 0%339µs ± 0%−1.56%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4377µs ± 0%368µs ± 0%−2.56%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-43.97ms ± 0%3.77ms ± 0%−4.85%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_10_10-4260µs ± 0%253µs ± 0%−2.47%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-41.87ms ± 0%1.81ms ± 0%−3.18%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-424.2ms ± 0%23.7ms ± 0%−2.11%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4265µs ± 0%254µs ± 0%−4.04%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-41.90ms ± 0%1.79ms ± 0%−5.95%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-41.15ms ± 0%1.14ms ± 0%−1.42%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_1000-49.56ms ± 0%8.91ms ± 0%−6.73%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4466µs ± 0%443µs ± 0%−4.88%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-41.29ms ± 0%1.24ms ± 0%−3.19%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-49.72ms ± 0%9.45ms ± 0%−2.72%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4477µs ± 0%471µs ± 0%−1.10%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-4720µs ± 0%658µs ± 0%−8.62%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4726µs ± 0%668µs ± 0%−8.00%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4683µs ± 0%658µs ± 0%−3.69%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4443µs ± 0%428µs ± 0%−3.21%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-41.24ms ± 0%1.22ms ± 0%−1.29%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-410.1ms ± 0%9.6ms ± 0%−4.76%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4313µs ± 0%307µs ± 0%−1.83%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4316µs ± 0%309µs ± 0%−2.26%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4312µs ± 0%310µs ± 0%−0.60%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-414.0µs ± 0%13.5µs ± 0%−3.67%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-414.8µs ± 0%14.0µs ± 0%−5.43%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-416.4µs ± 0%15.4µs ± 0%−5.91%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-420.5µs ± 0%19.9µs ± 0%−3.22%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4133µs ± 0%127µs ± 0%−4.48%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4131µs ± 0%127µs ± 0%−3.55%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4160µs ± 0%156µs ± 0%−2.61%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4196µs ± 0%194µs ± 0%−1.13%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-414.8µs ± 0%14.7µs ± 0%−0.83%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-415.2µs ± 0%14.9µs ± 0%−1.96%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-415.7µs ± 0%15.1µs ± 0%−3.78%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-417.7µs ± 0%17.1µs ± 0%−3.72%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-421.1µs ± 0%20.1µs ± 0%−4.70%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4152µs ± 0%148µs ± 0%−2.52%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4164µs ± 0%156µs ± 0%−4.94%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4201µs ± 0%198µs ± 0%−1.54%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-447.8µs ± 0%45.0µs ± 0%−5.75%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-448.4µs ± 0%48.1µs ± 0%−0.68%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-457.4µs ± 0%55.1µs ± 0%−4.06%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-470.2µs ± 0%68.3µs ± 0%−2.67%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4379µs ± 0%357µs ± 0%−5.81%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4367µs ± 0%362µs ± 0%−1.57%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4376µs ± 0%362µs ± 0%−3.57%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4413µs ± 0%393µs ± 0%−4.95%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4506µs ± 0%468µs ± 0%−7.57%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-445.4µs ± 0%45.1µs ± 0%−0.74%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-447.1µs ± 0%47.1µs ± 0%−0.16%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-454.5µs ± 0%52.6µs ± 0%−3.59%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-466.5µs ± 0%66.4µs ± 0%−0.04%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4364µs ± 0%333µs ± 0%−8.40%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4371µs ± 0%345µs ± 0%−6.96%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4417µs ± 0%376µs ± 0%−9.85%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4515µs ± 0%491µs ± 0%−4.63%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4120µs ± 0%119µs ± 0%−0.26%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4120µs ± 0%119µs ± 0%−1.06%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4140µs ± 0%134µs ± 0%−4.31%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-41.20ms ± 0%1.16ms ± 0%−3.84%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-41.21ms ± 0%1.21ms ± 0%−0.36%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-41.24ms ± 0%1.23ms ± 0%−0.86%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-41.30ms ± 0%1.27ms ± 0%−2.92%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-41.58ms ± 0%1.39ms ± 0%−12.15%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4119µs ± 0%117µs ± 0%−2.47%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4124µs ± 0%115µs ± 0%−7.47%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4123µs ± 0%116µs ± 0%−5.57%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4124µs ± 0%122µs ± 0%−1.85%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4145µs ± 0%133µs ± 0%−8.15%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-41.21ms ± 0%1.14ms ± 0%−5.86%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-41.30ms ± 0%1.15ms ± 0%−11.71%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-41.24ms ± 0%1.22ms ± 0%−1.24%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-41.41ms ± 0%1.38ms ± 0%−2.69%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-48.29µs ± 0%8.22µs ± 0%−0.81%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-414.5µs ± 0%14.5µs ± 0%−0.32%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-487.1µs ± 0%86.7µs ± 0%−0.45%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-491.9µs ± 0%91.0µs ± 0%−0.96%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-4100µs ± 0%97µs ± 0%−2.51%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4115µs ± 0%112µs ± 0%−3.26%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4172µs ± 0%146µs ± 0%−15.18%(p=1.000 n=1+1)
 
❌ See Worse Results...
time/opdelta
_Collection_UserSimple_Read_Sync_100_100-43.64ms ± 0%3.67ms ± 0%+0.90%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_1000-439.2ms ± 0%40.5ms ± 0%+3.25%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4410µs ± 0%410µs ± 0%+0.20%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4470µs ± 0%474µs ± 0%+0.97%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4137µs ± 0%138µs ± 0%+0.54%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4136µs ± 0%138µs ± 0%+1.22%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4142µs ± 0%142µs ± 0%+0.10%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-445.9µs ± 0%47.2µs ± 0%+2.73%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-445.1µs ± 0%46.1µs ± 0%+2.16%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4362µs ± 0%370µs ± 0%+2.32%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4120µs ± 0%122µs ± 0%+1.81%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4124µs ± 0%124µs ± 0%+0.39%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-41.17ms ± 0%1.19ms ± 0%+1.07%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-48.70µs ± 0%9.05µs ± 0%+4.02%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-49.22µs ± 0%9.56µs ± 0%+3.62%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-410.8µs ± 0%10.9µs ± 0%+0.21%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4116µs ± 0%126µs ± 0%+9.29%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4116µs ± 0%128µs ± 0%+10.65%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4122µs ± 0%128µs ± 0%+4.67%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4127µs ± 0%130µs ± 0%+2.20%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4131µs ± 0%139µs ± 0%+5.89%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-41.18ms ± 0%1.26ms ± 0%+6.95%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-41.23ms ± 0%1.24ms ± 0%+0.57%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-41.21ms ± 0%1.25ms ± 0%+3.66%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-41.20ms ± 0%1.30ms ± 0%+8.51%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-41.29ms ± 0%1.35ms ± 0%+4.82%(p=1.000 n=1+1)
 
✨ See Unchanged Results...
time/opdelta
 
🐋 See Full Results...
develop.txtcurrent.txt
time/opdelta
pkg:collection goos:linux goarch:amd64
_Collection_UserSimple_CreateMany_Sync_0_10-411.6ms ± 0%10.8ms ± 0%−6.75%(p=1.000 n=1+1)
_Collection_UserSimple_CreateMany_Sync_0_100-4256ms ± 0%218ms ± 0%−14.76%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_10-410.2ms ± 0%10.0ms ± 0%−1.79%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_100-4111ms ± 0%99ms ± 0%−10.77%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_1000-41.12s ± 0%1.00s ± 0%−11.08%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-446.9ms ± 0%44.5ms ± 0%−5.11%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_1000-4469ms ± 0%434ms ± 0%−7.37%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-44.76s ± 0%4.46s ± 0%−6.29%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4344µs ± 0%339µs ± 0%−1.56%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_100_100-43.64ms ± 0%3.67ms ± 0%+0.90%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_1000-439.2ms ± 0%40.5ms ± 0%+3.25%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4377µs ± 0%368µs ± 0%−2.56%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-43.97ms ± 0%3.77ms ± 0%−4.85%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_10_10-4260µs ± 0%253µs ± 0%−2.47%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-41.87ms ± 0%1.81ms ± 0%−3.18%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-424.2ms ± 0%23.7ms ± 0%−2.11%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4265µs ± 0%254µs ± 0%−4.04%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-41.90ms ± 0%1.79ms ± 0%−5.95%(p=1.000 n=1+1)
pkg:query/simple goos:linux goarch:amd64
_Query_UserSimple_Query_Sync_10-4379µs ± 0%376µs ± 0%−0.64%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-41.15ms ± 0%1.14ms ± 0%−1.42%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_1000-49.56ms ± 0%8.91ms ± 0%−6.73%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4466µs ± 0%443µs ± 0%−4.88%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-41.29ms ± 0%1.24ms ± 0%−3.19%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-49.72ms ± 0%9.45ms ± 0%−2.72%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4410µs ± 0%410µs ± 0%+0.20%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4477µs ± 0%471µs ± 0%−1.10%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4470µs ± 0%474µs ± 0%+0.97%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-4720µs ± 0%658µs ± 0%−8.62%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4726µs ± 0%668µs ± 0%−8.00%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4683µs ± 0%658µs ± 0%−3.69%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4443µs ± 0%428µs ± 0%−3.21%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-41.24ms ± 0%1.22ms ± 0%−1.29%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-410.1ms ± 0%9.6ms ± 0%−4.76%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4313µs ± 0%307µs ± 0%−1.83%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4316µs ± 0%309µs ± 0%−2.26%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4312µs ± 0%310µs ± 0%−0.60%(p=1.000 n=1+1)
pkg:storage goos:linux goarch:amd64
_Storage_Simple_Read_Sync_1_10/ValueSize:0064-412.8µs ± 0%13.0µs ± 0%+1.52%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-414.0µs ± 0%13.5µs ± 0%−3.67%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-414.8µs ± 0%14.0µs ± 0%−5.43%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-416.4µs ± 0%15.4µs ± 0%−5.91%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-420.5µs ± 0%19.9µs ± 0%−3.22%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4133µs ± 0%127µs ± 0%−4.48%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4131µs ± 0%127µs ± 0%−3.55%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4137µs ± 0%138µs ± 0%+0.54%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4160µs ± 0%156µs ± 0%−2.61%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4196µs ± 0%194µs ± 0%−1.13%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-414.8µs ± 0%14.7µs ± 0%−0.83%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-415.2µs ± 0%14.9µs ± 0%−1.96%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-415.7µs ± 0%15.1µs ± 0%−3.78%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-417.7µs ± 0%17.1µs ± 0%−3.72%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-421.1µs ± 0%20.1µs ± 0%−4.70%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4136µs ± 0%138µs ± 0%+1.22%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4142µs ± 0%142µs ± 0%+0.10%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4152µs ± 0%148µs ± 0%−2.52%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4164µs ± 0%156µs ± 0%−4.94%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4201µs ± 0%198µs ± 0%−1.54%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-447.8µs ± 0%45.0µs ± 0%−5.75%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-445.9µs ± 0%47.2µs ± 0%+2.73%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-448.4µs ± 0%48.1µs ± 0%−0.68%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-457.4µs ± 0%55.1µs ± 0%−4.06%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-470.2µs ± 0%68.3µs ± 0%−2.67%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4379µs ± 0%357µs ± 0%−5.81%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4367µs ± 0%362µs ± 0%−1.57%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4376µs ± 0%362µs ± 0%−3.57%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4413µs ± 0%393µs ± 0%−4.95%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4506µs ± 0%468µs ± 0%−7.57%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-445.4µs ± 0%45.1µs ± 0%−0.74%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-445.1µs ± 0%46.1µs ± 0%+2.16%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-447.1µs ± 0%47.1µs ± 0%−0.16%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-454.5µs ± 0%52.6µs ± 0%−3.59%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-466.5µs ± 0%66.4µs ± 0%−0.04%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4362µs ± 0%370µs ± 0%+2.32%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4364µs ± 0%333µs ± 0%−8.40%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4371µs ± 0%345µs ± 0%−6.96%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4417µs ± 0%376µs ± 0%−9.85%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4515µs ± 0%491µs ± 0%−4.63%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4120µs ± 0%119µs ± 0%−0.26%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4120µs ± 0%119µs ± 0%−1.06%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4120µs ± 0%122µs ± 0%+1.81%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4124µs ± 0%124µs ± 0%+0.39%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4140µs ± 0%134µs ± 0%−4.31%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-41.20ms ± 0%1.16ms ± 0%−3.84%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-41.21ms ± 0%1.21ms ± 0%−0.36%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-41.24ms ± 0%1.23ms ± 0%−0.86%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-41.30ms ± 0%1.27ms ± 0%−2.92%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-41.58ms ± 0%1.39ms ± 0%−12.15%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4119µs ± 0%117µs ± 0%−2.47%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4124µs ± 0%115µs ± 0%−7.47%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4123µs ± 0%116µs ± 0%−5.57%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4124µs ± 0%122µs ± 0%−1.85%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4145µs ± 0%133µs ± 0%−8.15%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-41.21ms ± 0%1.14ms ± 0%−5.86%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-41.30ms ± 0%1.15ms ± 0%−11.71%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-41.17ms ± 0%1.19ms ± 0%+1.07%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-41.24ms ± 0%1.22ms ± 0%−1.24%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-41.41ms ± 0%1.38ms ± 0%−2.69%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-48.29µs ± 0%8.22µs ± 0%−0.81%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-48.70µs ± 0%9.05µs ± 0%+4.02%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-49.22µs ± 0%9.56µs ± 0%+3.62%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-410.8µs ± 0%10.9µs ± 0%+0.21%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-414.5µs ± 0%14.5µs ± 0%−0.32%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-487.1µs ± 0%86.7µs ± 0%−0.45%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-491.9µs ± 0%91.0µs ± 0%−0.96%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-4100µs ± 0%97µs ± 0%−2.51%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4115µs ± 0%112µs ± 0%−3.26%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4172µs ± 0%146µs ± 0%−15.18%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4116µs ± 0%126µs ± 0%+9.29%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4116µs ± 0%128µs ± 0%+10.65%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4122µs ± 0%128µs ± 0%+4.67%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4127µs ± 0%130µs ± 0%+2.20%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4131µs ± 0%139µs ± 0%+5.89%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-41.18ms ± 0%1.26ms ± 0%+6.95%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-41.23ms ± 0%1.24ms ± 0%+0.57%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-41.21ms ± 0%1.25ms ± 0%+3.66%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-41.20ms ± 0%1.30ms ± 0%+8.51%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-41.29ms ± 0%1.35ms ± 0%+4.82%(p=1.000 n=1+1)
 

fredcarle
fredcarle approved these changes Jul 19, 2022
View reviewed changes
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@source-devs
Copy link

Benchmark Results

Summary

  • 113 Benchmarks successfully compared.
  • 29 Benchmarks were ✅ Better.
  • 84 Benchmarks were ❌ Worse .
  • 0 Benchmarks were ✨ Unchanged.
✅ See Better Results...
time/opdelta
_Collection_UserSimple_CreateMany_Sync_0_100-4256ms ± 0%232ms ± 0%−9.41%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_100-4111ms ± 0%101ms ± 0%−8.85%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_1000-41.12s ± 0%1.07s ± 0%−4.37%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-446.9ms ± 0%45.3ms ± 0%−3.46%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_1000-4469ms ± 0%452ms ± 0%−3.52%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-44.76s ± 0%4.54s ± 0%−4.79%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4377µs ± 0%350µs ± 0%−7.28%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-43.97ms ± 0%3.83ms ± 0%−3.38%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-41.87ms ± 0%1.85ms ± 0%−0.98%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-424.2ms ± 0%23.5ms ± 0%−3.09%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4265µs ± 0%256µs ± 0%−3.44%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-41.90ms ± 0%1.81ms ± 0%−4.68%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_1000-49.56ms ± 0%9.39ms ± 0%−1.76%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4466µs ± 0%447µs ± 0%−3.98%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4470µs ± 0%467µs ± 0%−0.47%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4683µs ± 0%678µs ± 0%−0.79%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4316µs ± 0%316µs ± 0%−0.23%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4312µs ± 0%298µs ± 0%−4.38%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-414.0µs ± 0%13.8µs ± 0%−1.62%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4515µs ± 0%496µs ± 0%−3.70%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-41.20ms ± 0%1.20ms ± 0%−0.23%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-41.30ms ± 0%1.22ms ± 0%−6.74%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-41.58ms ± 0%1.44ms ± 0%−9.00%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4124µs ± 0%122µs ± 0%−1.66%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4145µs ± 0%140µs ± 0%−3.30%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-41.21ms ± 0%1.15ms ± 0%−4.70%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-41.30ms ± 0%1.25ms ± 0%−4.09%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4172µs ± 0%156µs ± 0%−9.54%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-41.23ms ± 0%1.23ms ± 0%−0.57%(p=1.000 n=1+1)
 
❌ See Worse Results...
time/opdelta
_Collection_UserSimple_Create_Sync_0_10-410.2ms ± 0%11.8ms ± 0%+16.00%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4344µs ± 0%346µs ± 0%+0.62%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_100_100-43.64ms ± 0%3.69ms ± 0%+1.55%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_1000-439.2ms ± 0%39.6ms ± 0%+0.97%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_10_10-4260µs ± 0%269µs ± 0%+3.62%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-41.15ms ± 0%1.32ms ± 0%+14.09%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-41.29ms ± 0%1.38ms ± 0%+7.01%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-49.72ms ± 0%9.73ms ± 0%+0.16%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4410µs ± 0%471µs ± 0%+14.87%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4477µs ± 0%512µs ± 0%+7.48%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-4720µs ± 0%722µs ± 0%+0.21%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4726µs ± 0%761µs ± 0%+4.80%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4443µs ± 0%476µs ± 0%+7.58%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-41.24ms ± 0%1.29ms ± 0%+4.45%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-410.1ms ± 0%10.1ms ± 0%+0.03%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4313µs ± 0%317µs ± 0%+1.18%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-414.8µs ± 0%15.3µs ± 0%+3.42%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-416.4µs ± 0%18.0µs ± 0%+9.85%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-420.5µs ± 0%21.2µs ± 0%+3.23%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4133µs ± 0%142µs ± 0%+7.00%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4131µs ± 0%151µs ± 0%+15.42%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4137µs ± 0%148µs ± 0%+8.10%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4160µs ± 0%174µs ± 0%+8.87%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4196µs ± 0%225µs ± 0%+15.05%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-414.8µs ± 0%15.7µs ± 0%+5.87%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-415.2µs ± 0%15.5µs ± 0%+1.68%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-415.7µs ± 0%18.6µs ± 0%+17.99%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-417.7µs ± 0%22.1µs ± 0%+24.47%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-421.1µs ± 0%22.7µs ± 0%+7.50%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4136µs ± 0%142µs ± 0%+4.71%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4142µs ± 0%167µs ± 0%+17.88%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4152µs ± 0%172µs ± 0%+13.30%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4164µs ± 0%178µs ± 0%+8.93%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4201µs ± 0%237µs ± 0%+18.27%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-447.8µs ± 0%50.1µs ± 0%+4.94%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-445.9µs ± 0%52.0µs ± 0%+13.13%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-448.4µs ± 0%61.8µs ± 0%+27.71%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-457.4µs ± 0%68.2µs ± 0%+18.77%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-470.2µs ± 0%81.7µs ± 0%+16.46%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4379µs ± 0%479µs ± 0%+26.23%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4367µs ± 0%440µs ± 0%+19.80%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4376µs ± 0%423µs ± 0%+12.51%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4413µs ± 0%499µs ± 0%+20.75%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4506µs ± 0%559µs ± 0%+10.39%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-445.4µs ± 0%51.1µs ± 0%+12.51%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-445.1µs ± 0%51.2µs ± 0%+13.58%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-447.1µs ± 0%53.0µs ± 0%+12.50%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-454.5µs ± 0%63.7µs ± 0%+16.81%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-466.5µs ± 0%67.4µs ± 0%+1.47%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4362µs ± 0%390µs ± 0%+7.63%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4364µs ± 0%382µs ± 0%+5.08%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4371µs ± 0%379µs ± 0%+2.16%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4417µs ± 0%433µs ± 0%+3.79%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4120µs ± 0%121µs ± 0%+1.33%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4120µs ± 0%125µs ± 0%+3.94%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4120µs ± 0%122µs ± 0%+1.52%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4124µs ± 0%125µs ± 0%+0.82%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4140µs ± 0%151µs ± 0%+7.30%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-41.21ms ± 0%1.29ms ± 0%+6.51%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-41.24ms ± 0%1.25ms ± 0%+0.49%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4119µs ± 0%125µs ± 0%+4.36%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4124µs ± 0%132µs ± 0%+6.46%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4123µs ± 0%125µs ± 0%+1.32%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-41.17ms ± 0%1.41ms ± 0%+20.02%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-41.24ms ± 0%1.36ms ± 0%+9.58%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-41.41ms ± 0%1.67ms ± 0%+18.14%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-48.29µs ± 0%9.12µs ± 0%+10.05%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-48.70µs ± 0%9.38µs ± 0%+7.78%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-49.22µs ± 0%10.88µs ± 0%+18.00%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-410.8µs ± 0%12.7µs ± 0%+17.57%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-414.5µs ± 0%17.9µs ± 0%+23.07%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-487.1µs ± 0%115.5µs ± 0%+32.67%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-491.9µs ± 0%105.4µs ± 0%+14.72%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-4100µs ± 0%102µs ± 0%+2.39%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4115µs ± 0%130µs ± 0%+12.57%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4116µs ± 0%132µs ± 0%+13.87%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4116µs ± 0%127µs ± 0%+9.21%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4122µs ± 0%132µs ± 0%+7.74%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4127µs ± 0%131µs ± 0%+3.06%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4131µs ± 0%139µs ± 0%+5.83%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-41.18ms ± 0%1.32ms ± 0%+11.61%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-41.21ms ± 0%1.24ms ± 0%+3.20%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-41.20ms ± 0%1.23ms ± 0%+2.37%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-41.29ms ± 0%1.35ms ± 0%+4.93%(p=1.000 n=1+1)
 
✨ See Unchanged Results...
time/opdelta
 
🐋 See Full Results...
develop.txtcurrent.txt
time/opdelta
pkg:collection goos:linux goarch:amd64
_Collection_UserSimple_CreateMany_Sync_0_10-411.6ms ± 0%10.9ms ± 0%−5.44%(p=1.000 n=1+1)
_Collection_UserSimple_CreateMany_Sync_0_100-4256ms ± 0%232ms ± 0%−9.41%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_10-410.2ms ± 0%11.8ms ± 0%+16.00%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_100-4111ms ± 0%101ms ± 0%−8.85%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_1000-41.12s ± 0%1.07s ± 0%−4.37%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-446.9ms ± 0%45.3ms ± 0%−3.46%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_1000-4469ms ± 0%452ms ± 0%−3.52%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-44.76s ± 0%4.54s ± 0%−4.79%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4344µs ± 0%346µs ± 0%+0.62%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_100_100-43.64ms ± 0%3.69ms ± 0%+1.55%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_1000-439.2ms ± 0%39.6ms ± 0%+0.97%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4377µs ± 0%350µs ± 0%−7.28%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-43.97ms ± 0%3.83ms ± 0%−3.38%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_10_10-4260µs ± 0%269µs ± 0%+3.62%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-41.87ms ± 0%1.85ms ± 0%−0.98%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-424.2ms ± 0%23.5ms ± 0%−3.09%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4265µs ± 0%256µs ± 0%−3.44%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-41.90ms ± 0%1.81ms ± 0%−4.68%(p=1.000 n=1+1)
pkg:query/simple goos:linux goarch:amd64
_Query_UserSimple_Query_Sync_10-4379µs ± 0%399µs ± 0%+5.30%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-41.15ms ± 0%1.32ms ± 0%+14.09%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_1000-49.56ms ± 0%9.39ms ± 0%−1.76%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4466µs ± 0%447µs ± 0%−3.98%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-41.29ms ± 0%1.38ms ± 0%+7.01%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-49.72ms ± 0%9.73ms ± 0%+0.16%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4410µs ± 0%471µs ± 0%+14.87%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4477µs ± 0%512µs ± 0%+7.48%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4470µs ± 0%467µs ± 0%−0.47%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-4720µs ± 0%722µs ± 0%+0.21%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4726µs ± 0%761µs ± 0%+4.80%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4683µs ± 0%678µs ± 0%−0.79%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4443µs ± 0%476µs ± 0%+7.58%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-41.24ms ± 0%1.29ms ± 0%+4.45%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-410.1ms ± 0%10.1ms ± 0%+0.03%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4313µs ± 0%317µs ± 0%+1.18%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4316µs ± 0%316µs ± 0%−0.23%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4312µs ± 0%298µs ± 0%−4.38%(p=1.000 n=1+1)
pkg:storage goos:linux goarch:amd64
_Storage_Simple_Read_Sync_1_10/ValueSize:0064-412.8µs ± 0%14.7µs ± 0%+15.19%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-414.0µs ± 0%13.8µs ± 0%−1.62%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-414.8µs ± 0%15.3µs ± 0%+3.42%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-416.4µs ± 0%18.0µs ± 0%+9.85%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-420.5µs ± 0%21.2µs ± 0%+3.23%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4133µs ± 0%142µs ± 0%+7.00%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4131µs ± 0%151µs ± 0%+15.42%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4137µs ± 0%148µs ± 0%+8.10%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4160µs ± 0%174µs ± 0%+8.87%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4196µs ± 0%225µs ± 0%+15.05%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-414.8µs ± 0%15.7µs ± 0%+5.87%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-415.2µs ± 0%15.5µs ± 0%+1.68%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-415.7µs ± 0%18.6µs ± 0%+17.99%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-417.7µs ± 0%22.1µs ± 0%+24.47%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-421.1µs ± 0%22.7µs ± 0%+7.50%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4136µs ± 0%142µs ± 0%+4.71%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4142µs ± 0%167µs ± 0%+17.88%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4152µs ± 0%172µs ± 0%+13.30%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4164µs ± 0%178µs ± 0%+8.93%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4201µs ± 0%237µs ± 0%+18.27%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-447.8µs ± 0%50.1µs ± 0%+4.94%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-445.9µs ± 0%52.0µs ± 0%+13.13%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-448.4µs ± 0%61.8µs ± 0%+27.71%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-457.4µs ± 0%68.2µs ± 0%+18.77%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-470.2µs ± 0%81.7µs ± 0%+16.46%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4379µs ± 0%479µs ± 0%+26.23%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4367µs ± 0%440µs ± 0%+19.80%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4376µs ± 0%423µs ± 0%+12.51%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4413µs ± 0%499µs ± 0%+20.75%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4506µs ± 0%559µs ± 0%+10.39%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-445.4µs ± 0%51.1µs ± 0%+12.51%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-445.1µs ± 0%51.2µs ± 0%+13.58%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-447.1µs ± 0%53.0µs ± 0%+12.50%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-454.5µs ± 0%63.7µs ± 0%+16.81%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-466.5µs ± 0%67.4µs ± 0%+1.47%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4362µs ± 0%390µs ± 0%+7.63%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4364µs ± 0%382µs ± 0%+5.08%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4371µs ± 0%379µs ± 0%+2.16%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4417µs ± 0%433µs ± 0%+3.79%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4515µs ± 0%496µs ± 0%−3.70%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4120µs ± 0%121µs ± 0%+1.33%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4120µs ± 0%125µs ± 0%+3.94%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4120µs ± 0%122µs ± 0%+1.52%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4124µs ± 0%125µs ± 0%+0.82%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4140µs ± 0%151µs ± 0%+7.30%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-41.20ms ± 0%1.20ms ± 0%−0.23%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-41.21ms ± 0%1.29ms ± 0%+6.51%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-41.24ms ± 0%1.25ms ± 0%+0.49%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-41.30ms ± 0%1.22ms ± 0%−6.74%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-41.58ms ± 0%1.44ms ± 0%−9.00%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4119µs ± 0%125µs ± 0%+4.36%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4124µs ± 0%132µs ± 0%+6.46%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4123µs ± 0%125µs ± 0%+1.32%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4124µs ± 0%122µs ± 0%−1.66%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4145µs ± 0%140µs ± 0%−3.30%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-41.21ms ± 0%1.15ms ± 0%−4.70%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-41.30ms ± 0%1.25ms ± 0%−4.09%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-41.17ms ± 0%1.41ms ± 0%+20.02%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-41.24ms ± 0%1.36ms ± 0%+9.58%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-41.41ms ± 0%1.67ms ± 0%+18.14%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-48.29µs ± 0%9.12µs ± 0%+10.05%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-48.70µs ± 0%9.38µs ± 0%+7.78%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-49.22µs ± 0%10.88µs ± 0%+18.00%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-410.8µs ± 0%12.7µs ± 0%+17.57%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-414.5µs ± 0%17.9µs ± 0%+23.07%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-487.1µs ± 0%115.5µs ± 0%+32.67%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-491.9µs ± 0%105.4µs ± 0%+14.72%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-4100µs ± 0%102µs ± 0%+2.39%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4115µs ± 0%130µs ± 0%+12.57%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4172µs ± 0%156µs ± 0%−9.54%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4116µs ± 0%132µs ± 0%+13.87%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4116µs ± 0%127µs ± 0%+9.21%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4122µs ± 0%132µs ± 0%+7.74%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4127µs ± 0%131µs ± 0%+3.06%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4131µs ± 0%139µs ± 0%+5.83%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-41.18ms ± 0%1.32ms ± 0%+11.61%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-41.23ms ± 0%1.23ms ± 0%−0.57%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-41.21ms ± 0%1.24ms ± 0%+3.20%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-41.20ms ± 0%1.23ms ± 0%+2.37%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-41.29ms ± 0%1.35ms ± 0%+4.93%(p=1.000 n=1+1)
 

@codecov
Copy link

codecov bot commented Jul 19, 2022 •
edited
Loading

Codecov Report

Merging #645 (96992d1) into develop (e323230) will not change coverage.
The diff coverage is 75.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #645   +/-   ##
========================================
  Coverage    57.09%   57.09%           
========================================
  Files          122      122           
  Lines        14646    14646           
========================================
  Hits          8362     8362           
  Misses        5567     5567           
  Partials       717      717
Impacted Files Coverage Δ
config/configfile.go 75.00% <ø> (ø)
config/config.go 73.30% <75.00%> (ø)

@AndrewSisley
Copy link
Contributor

Might be worth constructing these binding-paths using reflect (in a later PR), is best practice in C# where strings must match types (as it makes the dependency clear, and adds some compile time protection). I assume Golang has a func that can get the name of a property.

AndrewSisley
AndrewSisley approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a suggestion for a future PR, cheers for the quick fix

@orpheuslummis
Copy link
Contributor Author

Might be worth constructing these binding-paths using reflect (in a later PR), is best practice in C# where strings must match types (as it makes the dependency clear, and adds some compile time protection). I assume Golang has a func that can get the name of a property.

Yes that's my thinking as well, doing so via struct tags, but I haven't found a nice way yet to do it....

@orpheuslummis
Copy link
Contributor Author

Might be worth constructing these binding-paths using reflect (in a later PR), is best practice in C# where strings must match types (as it makes the dependency clear, and adds some compile time protection). I assume Golang has a func that can get the name of a property.

Yes that's my thinking as well, doing so via struct tags, but I haven't found a nice way yet to do it....

A counterpoint is the comment John made today about WASM and avoiding reflection. TBD

@orpheuslummis orpheuslummis merged commit c7257c4 into develop Jul 19, 2022
@orpheuslummis orpheuslummis deleted the orpheus/fix/config-cli branch July 19, 2022 22:01
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@orpheuslummis
fix: Consider --logoutput CLI flag properly (sourcenetwork#645)
44556cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredcarle fredcarle fredcarle approved these changes

@AndrewSisley AndrewSisley AndrewSisley approved these changes

Assignees

@orpheuslummis orpheuslummis

Labels
area/cli Related to the CLI binary area/config Related to configuration
Projects
None yet
Milestone
DefraDB v0.3
Development

Successfully merging this pull request may close these issues.

--logoutput CLI flag not being considered properly
4 participants
@orpheuslummis @source-devs @AndrewSisley @fredcarle