fix: Handle errors generated in fields thunk #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
bug
|
Merged the updates on the sourcenetwork/graphql-go fork. Does anything need to change here (ie go.mod stuff) before merging? |
|
nvm, I see you already marked that as an outstanding task. Ill let you take care of it 👍, ping me if/when another review is needed |
AndrewSisley
force-pushed
the
sisley/fix/I53-error-handling-in-fields-thunk-updated-fork
branch
from
796c955
to
998be84
Compare
AndrewSisley
deleted the
sisley/fix/I53-error-handling-in-fields-thunk-updated-fork
branch
Closed
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
* Resolve fields in ResolveTypes function * Include type name in type missing error * Handle errors occuring during fields thunk resolution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #53
The new version of the fork (in review sourcenetwork/graphql-go#2) stores errors from the thunk onto
object.err(accessed publicly viaobject.Errors().To do before merge:
developbranch