Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove portSyncLock deadlock condition #671

Merged
merged 2 commits into from
Jul 26, 2022
Merged

fix: Remove portSyncLock deadlock condition #671

merged 2 commits into from
Jul 26, 2022

Conversation

fredcarle
Copy link
Collaborator

Relevant issue(s)

Resolves #670

Description

This PR fixes a possible deadlock condition on the random port number generator.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

integration test

Specify the platform(s) on which this was tested:

  • MacOS

@fredcarle fredcarle added bug Something isn't working area/testing Related to any test or testing suite action/no-benchmark Skips the action that runs the benchmark. labels Jul 26, 2022
@fredcarle fredcarle added this to the DefraDB v0.3 milestone Jul 26, 2022
@fredcarle fredcarle requested a review from a team July 26, 2022 01:49
@fredcarle fredcarle self-assigned this Jul 26, 2022
jsimnz
jsimnz approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@jsimnz jsimnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fredcarle fredcarle force-pushed the fredcarle/fix/used-port-unlock branch from b8eba72 to 94f71a4 Compare July 26, 2022 02:17
@fredcarle fredcarle force-pushed the fredcarle/fix/used-port-unlock branch from 5247708 to 50bc546 Compare July 26, 2022 02:31
@fredcarle fredcarle merged commit 936675c into develop Jul 26, 2022
@fredcarle fredcarle deleted the fredcarle/fix/used-port-unlock branch July 26, 2022 02:40
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@fredcarle
fix: Remove portSyncLock deadlock condition (sourcenetwork#671)
09c7b26 
Relevant issue(s)
Resolves sourcenetwork#670

Description
This PR fixes a possible deadlock condition on the random port number generator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsimnz jsimnz jsimnz approved these changes

@orpheuslummis orpheuslummis orpheuslummis left review comments

Assignees

@fredcarle fredcarle

Labels
action/no-benchmark Skips the action that runs the benchmark. area/testing Related to any test or testing suite bug Something isn't working
Projects
None yet
Milestone
DefraDB v0.3
Development

Successfully merging this pull request may close these issues.

portSyncLock deadlocks if the RNG returns the same port twice.
3 participants
@fredcarle @orpheuslummis @jsimnz