fix: Add content-type media type parsing #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredcarle
added
bug
Codecov Report
@@ Coverage Diff @@
## develop #678 +/- ##
===========================================
+ Coverage 57.21% 57.24% +0.02%
===========================================
Files 143 143
Lines 16383 16393 +10
===========================================
+ Hits 9374 9384 +10
Misses 6127 6127
Partials 882 882
|
| switch req.Header.Get("Content-Type") { | ||
| // extract the media type from the content-type header | ||
| contentType, _, err := mime.ParseMediaType(req.Header.Get("Content-Type")) | ||
| if err != nil && err.Error() != "mime: no media type" { |
There was a problem hiding this comment.
suggestion: add a comment explaining the err.Error() != "mime: no media type" section if possible
There was a problem hiding this comment.
Let me know what you think of the comment.
fredcarle
force-pushed
the
fredcarle/fix/I677-content-type-switch
branch
from
279740e
to
480125e
Compare
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
Relevant issue(s) Resolves sourcenetwork#677 Description This PR fixes an issue where some http clients add parameters to the content-type and caused the content-type switch to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #677
Description
This PR fixes an issue where some http clients add parameters to the content-type and caused the content-type switch to fail.
Tasks
How has this been tested?
unit test
Specify the platform(s) on which this was tested: