Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Use permanent link to BSL license document #692

Merged
merged 1 commit into from
Jul 30, 2022
Merged

docs: Use permanent link to BSL license document #692

merged 1 commit into from
Jul 30, 2022

Conversation

orpheuslummis
Copy link
Contributor

@orpheuslummis orpheuslummis commented Jul 29, 2022 •
edited
Loading

Relevant issue(s)

Resolves #691

Description

Simple link update

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

Human

@orpheuslummis orpheuslummis added documentation Improvements or additions to documentation action/no-benchmark Skips the action that runs the benchmark. labels Jul 29, 2022
@orpheuslummis orpheuslummis added this to the DefraDB v0.3 milestone Jul 29, 2022
@orpheuslummis orpheuslummis requested a review from a team July 29, 2022 19:43
@orpheuslummis orpheuslummis self-assigned this Jul 29, 2022
@orpheuslummis
Copy link
Contributor Author

I don't know why checks failed

@shahzadlone
Copy link
Member

I don't know why checks failed

This is weird, I even tried restarting them. Will investigate.

@orpheuslummis
Copy link
Contributor Author

I don't know why checks failed

This is weird, I even tried restarting them. Will investigate.

Thank you !!

@fredcarle
Copy link
Collaborator

This has got to be the smallest PR yet 🙃

shahzadlone
shahzadlone approved these changes Jul 30, 2022
View reviewed changes
Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orpheuslummis orpheuslummis merged commit 23e728e into develop Jul 30, 2022
@orpheuslummis orpheuslummis deleted the orpheus/docs/bsl-lini branch July 30, 2022 04:21
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@orpheuslummis
docs: Use permanent link to BSL license document (sourcenetwork#692)
431175d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzadlone shahzadlone shahzadlone approved these changes

Assignees

@orpheuslummis orpheuslummis

Labels
action/no-benchmark Skips the action that runs the benchmark. documentation Improvements or additions to documentation
Projects
None yet
Milestone
DefraDB v0.3
Development

Successfully merging this pull request may close these issues.

docs: Use permanent link to BSL license
3 participants
@orpheuslummis @shahzadlone @fredcarle