fix: Support multiple --logger flags
#704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orpheuslummis
added
action/no-benchmark
jsimnz
approved these changes
Aug 1, 2022
fredcarle
approved these changes
Aug 2, 2022
shahzadlone
reviewed
Aug 2, 2022
cli/root.go
Outdated
| "Named logger parameter override. usage: --logger <name>,level=<level>,output=<output>,...", | ||
| rootCmd.PersistentFlags().StringArray( | ||
| "logger", []string{}, | ||
| "Named logger parameter override. Usage: --logger <name>,level=<level>,output=<output>,...", |
There was a problem hiding this comment.
suggestion: Perhaps similar to fred's suggestion to above we can make it clear that can specify multiple --logger flags in Usage section.
There was a problem hiding this comment.
I've changed slightly the text. By default, cobra indicates the expected type (here stringArray ...), so there is the information for the user. Because of these two reasons, I suggest that it is sufficiently clear that it can be used multiple times.
That said I'm not satisfied with the type name that is shown as it could be clearer.
shahzadlone
approved these changes
Aug 2, 2022
orpheuslummis
force-pushed
the
orpheus/fix/multiple-logger-cli
branch
from
8221578
to
3e59adf
Compare
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #699
Description
Support multiple
--loggerflagsTasks
How has this been tested?
Manual
Specify the platform(s) on which this was tested: