Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fix the linter version to v1.47 #726

Merged
merged 1 commit into from
Aug 5, 2022
Merged

ci: Fix the linter version to v1.47 #726

merged 1 commit into from
Aug 5, 2022

Conversation

shahzadlone
Copy link
Member

@shahzadlone shahzadlone commented Aug 5, 2022 •
edited
Loading

Relevant issue(s)

Resolves #727

Description

Since the release of golangci-lint v1.48 the github action's pre-compiled version pick up GoLang v1.19 gofmt linter rules, despite explicitly setting v1.18. This PR would fix it to be v1.47 for now.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

CI

Specify the platform(s) on which this was tested:

  • Ubuntu

@shahzadlone
pr: Make the golangci action version static because it uses a
80955c7 
pre-compiled with go 1.19 binary otherwise.
@shahzadlone shahzadlone added the action/no-benchmark Skips the action that runs the benchmark. label Aug 5, 2022
@shahzadlone shahzadlone added this to the DefraDB v0.3.1 milestone Aug 5, 2022
@shahzadlone shahzadlone self-assigned this Aug 5, 2022
@shahzadlone shahzadlone added the ci/build This is issue is about the build or CI system, and the administration of it. label Aug 5, 2022
@shahzadlone shahzadlone requested a review from a team August 5, 2022 16:31
fredcarle
fredcarle approved these changes Aug 5, 2022
View reviewed changes
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MERGE IT!!!!

@shahzadlone shahzadlone merged commit ccccd59 into develop Aug 5, 2022
@shahzadlone shahzadlone deleted the lone/ci/fix-ci-linter-version branch August 5, 2022 16:41
shahzadlone added a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@shahzadlone
ci: Fix the linter version to v1.47 (sourcenetwork#726)
ddeb951 
- Resolves sourcenetwork#727 

- Description: Since the release of golangci-lint `v1.48` the github action's pre-compiled version pick up GoLang v1.19 gofmt linter rules, despite explicitly setting v1.18. This PR would fix it to be `v1.47` for now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredcarle fredcarle fredcarle approved these changes

Assignees

@shahzadlone shahzadlone

Labels
action/no-benchmark Skips the action that runs the benchmark. ci/build This is issue is about the build or CI system, and the administration of it.
Projects
None yet
Milestone
DefraDB v0.3.1
Development

Successfully merging this pull request may close these issues.

golangci-lint fails in CI picks up golang v1.19 gofmt errors.
2 participants
@shahzadlone @fredcarle