Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make topLevelNode explainable #737

Merged
merged 2 commits into from
Aug 15, 2022
Merged

feat: Make topLevelNode explainable #737

merged 2 commits into from
Aug 15, 2022

Conversation

shahzadlone
Copy link
Member

Relevant issue(s)

Resolves #736

Description

This PR makes topLevelNode explainable without changing the Source() function to fetch child graphs.
#626 will be done in a separate PR once topLevelNode.Source() is updated.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

Locally added and ran the integration tests, and CI.

Specify the platform(s) on which this was tested:

  • WSL2 Manjaro

@shahzadlone shahzadlone added feature New feature or request area/query Related to the query component action/no-benchmark Skips the action that runs the benchmark. area/planner Related to the planner system labels Aug 12, 2022
@shahzadlone shahzadlone added this to the DefraDB v0.3.1 milestone Aug 12, 2022
@shahzadlone shahzadlone requested a review from a team August 12, 2022 08:04
@shahzadlone shahzadlone self-assigned this Aug 12, 2022
fredcarle
fredcarle approved these changes Aug 12, 2022
View reviewed changes
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shahzadlone shahzadlone merged commit e18c872 into develop Aug 15, 2022
@shahzadlone shahzadlone deleted the lone/feat/explain-top-level-node branch August 15, 2022 08:41
shahzadlone added a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@shahzadlone
feat: Make topLevelNode explainable (sourcenetwork#737)
33a8c95 
- Resolves sourcenetwork#736

- Description: makes `topLevelNode` explainable without changing the `Source()` function to fetch child graphs.
 sourcenetwork#626 will be done in a separate PR once `topLevelNode.Source()` is updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredcarle fredcarle fredcarle approved these changes

Assignees

@shahzadlone shahzadlone

Labels
action/no-benchmark Skips the action that runs the benchmark. area/planner Related to the planner system area/query Related to the query component feature New feature or request
Projects
None yet
Milestone
DefraDB v0.3.1
Development

Successfully merging this pull request may close these issues.

Make topLevelNode explainable as is without updating Source()
2 participants
@shahzadlone @fredcarle