chore: Remove ipfslite dependency
#739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredcarle
added
area/p2p
fredcarle
force-pushed
the
fredcarle/chore/I738-remove-ipfslite-dependency
branch
2 times, most recently
from
07df391
to
088ae96
Compare
Codecov Report
@@ Coverage Diff @@
## develop #739 +/- ##
===========================================
+ Coverage 59.78% 59.84% +0.05%
===========================================
Files 156 156
Lines 17358 17415 +57
===========================================
+ Hits 10378 10422 +44
- Misses 6044 6056 +12
- Partials 936 937 +1
|
|
One thing in favor of this PR is that is allows to stop maintaining the custom fork https://github.com/sourcenetwork/ipfs-lite |
fredcarle
force-pushed
the
fredcarle/chore/I738-remove-ipfslite-dependency
branch
from
6c29ae8
to
b5f3675
Compare
fredcarle
changed the title
ipfslite dependencyipfslite dependency
This was referenced Oct 17, 2022
Closed
|
suggestion: when this merges, also archive the https://github.com/sourcenetwork/ipfs-lite repository |
AndrewSisley
approved these changes
Oct 17, 2022
fredcarle
force-pushed
the
fredcarle/chore/I738-remove-ipfslite-dependency
branch
from
48f1745
to
d30fa2d
Compare
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
Relevant issue(s) Resolves sourcenetwork#738 Description This PR removes our direct dependency on ipfslite. It is still an indirect dependency simply because it's used by an other package we import. Not from a function that we use but from a test of that package. Note that some commented code will need to be uncommented once sourcenetwork#683 is resolved. Although a ds.Batching implementing datastore needs to be used for the DHT within the net package, as long as badgerds.Datastore keeps the Batch method, the should have no problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #738
Description
This PR removes our direct dependency on
ipfslite. It is still an indirect dependency simply because it's used by an other package we import. Not from a function that we use but from a test of that package.Note that some commented code will need to be uncommented once #683 is resolved. Although a
ds.Batchingimplementing datastore needs to be used for the DHT within thenetpackage, as long asbadgerds.Datastorekeeps theBatchmethod, the should have no problem.Tasks
How has this been tested?
unit tests
Specify the platform(s) on which this was tested: