-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a config option to set the vlog max file size #743
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #743 +/- ##
===========================================
+ Coverage 57.52% 57.66% +0.14%
===========================================
Files 143 143
Lines 16394 16456 +62
===========================================
+ Hits 9430 9489 +59
- Misses 6081 6083 +2
- Partials 883 884 +1
|
9c85aa0
to
a3fa664
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the current config file with this PR still include the double options
yaml values?
Some minor suggestions, thoughts. Should be quick to get it to final approval state.
a3fa664
to
d6bc357
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
728a98b
to
cf2a0a1
Compare
…k#743) Description This PR adds a config option that gives the user the ability to set the maximum value log file size for the badger DB datastore.
Relevant issue(s)
Resolves #742
Description
This PR adds a config option that gives the user the ability to set the maximum value log file size for the badger DB datastore.
Tasks
How has this been tested?
unit test and manual test
Specify the platform(s) on which this was tested: