Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a config option to set the vlog max file size #743

Merged
merged 3 commits into from
Aug 18, 2022

Conversation

fredcarle
Copy link
Collaborator

Relevant issue(s)

Resolves #742

Description

This PR adds a config option that gives the user the ability to set the maximum value log file size for the badger DB datastore.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

unit test and manual test

Specify the platform(s) on which this was tested:

  • MacOS

@fredcarle fredcarle added feature New feature or request area/datastore Related to the datastore / storage engine system action/no-benchmark Skips the action that runs the benchmark. area/cli Related to the CLI binary area/config Related to configuration labels Aug 16, 2022
@fredcarle fredcarle added this to the DefraDB v0.3.1 milestone Aug 16, 2022
@fredcarle fredcarle requested a review from a team August 16, 2022 03:37
@fredcarle fredcarle self-assigned this Aug 16, 2022
@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #743 (cf2a0a1) into develop (f6ed210) will increase coverage by 0.14%.
The diff coverage is 93.93%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #743      +/-   ##
===========================================
+ Coverage    57.52%   57.66%   +0.14%     
===========================================
  Files          143      143              
  Lines        16394    16456      +62     
===========================================
+ Hits          9430     9489      +59     
- Misses        6081     6083       +2     
- Partials       883      884       +1     
Impacted Files Coverage Δ
config/configfile.go 75.00% <ø> (ø)
cli/start.go 16.75% <62.50%> (+1.99%) ⬆️
config/config.go 79.03% <98.27%> (+4.42%) ⬆️

@fredcarle fredcarle force-pushed the fredcarle/feat/I742-vlogmaxsize-config branch from 9c85aa0 to a3fa664 Compare August 16, 2022 03:40
@fredcarle fredcarle changed the title feat: Add a config option for setting the value log maximum file size feat: Add a config option to set the vlog max file size Aug 16, 2022
Copy link
Member

@jsimnz jsimnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the current config file with this PR still include the double options yaml values?

Some minor suggestions, thoughts. Should be quick to get it to final approval state.

config/config.go Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
cli/start.go Outdated Show resolved Hide resolved
cli/start.go Outdated Show resolved Hide resolved
@fredcarle fredcarle force-pushed the fredcarle/feat/I742-vlogmaxsize-config branch from a3fa664 to d6bc357 Compare August 16, 2022 22:44
config/configfile.go Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
cli/start.go Show resolved Hide resolved
config/config_test.go Outdated Show resolved Hide resolved
config/config.go Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
Copy link
Member

@jsimnz jsimnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fredcarle fredcarle force-pushed the fredcarle/feat/I742-vlogmaxsize-config branch from 728a98b to cf2a0a1 Compare August 18, 2022 20:40
@fredcarle fredcarle merged commit da7088e into develop Aug 18, 2022
@fredcarle fredcarle deleted the fredcarle/feat/I742-vlogmaxsize-config branch August 18, 2022 20:52
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
…k#743)

Description
This PR adds a config option that gives the user the ability to set the maximum value log file size for the badger DB datastore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/no-benchmark Skips the action that runs the benchmark. area/cli Related to the CLI binary area/config Related to configuration area/datastore Related to the datastore / storage engine system feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Value log max file size
4 participants