Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add tests for inline array grouping #752

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

AndrewSisley
Copy link
Contributor

Relevant issue(s)

Resolves #391

Description

Adds tests for inline array grouping. Ticket originally thought there was a gap in joins, however this was a misunderstanding and we already had coverage.

Specify the platform(s) on which this was tested:

  • Debian Linux

@AndrewSisley AndrewSisley added documentation Improvements or additions to documentation area/query Related to the query component code quality Related to improving code quality action/no-benchmark Skips the action that runs the benchmark. labels Aug 23, 2022
@AndrewSisley AndrewSisley added this to the DefraDB v0.3.1 milestone Aug 23, 2022
@AndrewSisley AndrewSisley requested a review from a team August 23, 2022 16:05
@AndrewSisley AndrewSisley self-assigned this Aug 23, 2022
Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these <3. LGTM

@AndrewSisley AndrewSisley merged commit f88100a into develop Aug 23, 2022
@AndrewSisley AndrewSisley deleted the sisley/test/I391-group-by-join-tests branch August 23, 2022 16:46
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/no-benchmark Skips the action that runs the benchmark. area/query Related to the query component code quality Related to improving code quality documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing tests for join and inline array access from within a groupby
2 participants