Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Clean up go.mod with pruned module graphs #756

Merged
merged 2 commits into from
Aug 23, 2022
Merged

chore: Clean up go.mod with pruned module graphs #756

merged 2 commits into from
Aug 23, 2022

Conversation

shahzadlone
Copy link
Member

@shahzadlone shahzadlone commented Aug 23, 2022 •
edited
Loading

Relevant issue(s)

Resolves #755

Description

Cleans up go.mod file according to go1.17 changes. Rather than having 3 blocks of mixed dependencies, now we have 2 blocks where one contains direct dependencies and one contains indirect ones.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

CI and Locally

Specify the platform(s) on which this was tested:

  • WSL 2 - Manjaro

@shahzadlone shahzadlone added action/no-benchmark Skips the action that runs the benchmark. dependencies Related to dependencies labels Aug 23, 2022
@shahzadlone shahzadlone added this to the DefraDB v0.3.1 milestone Aug 23, 2022
@shahzadlone shahzadlone self-assigned this Aug 23, 2022
@shahzadlone shahzadlone requested a review from a team August 23, 2022 20:55
orpheuslummis
orpheuslummis approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@orpheuslummis orpheuslummis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orpheuslummis
Copy link
Contributor

suggestion: include more detail in PR/commit title, e.g. something like "Clean up go.mod file with go1.17 pruned module graphs"

@shahzadlone shahzadlone changed the title chore: Clean up go.mod file chore: Clean up go.mod with pruned module graphs Aug 23, 2022
@shahzadlone shahzadlone merged commit d59592f into develop Aug 23, 2022
@shahzadlone shahzadlone deleted the lone/chore/gomod-cleanup branch August 23, 2022 23:20
shahzadlone added a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@shahzadlone
chore: Clean up go.mod with pruned module graphs (sourcenetwork#756)
05930e2 
- Resolves sourcenetwork#755

- Description: Cleans up `go.mod` file according to go1.17 changes. Rather than having 3 blocks of mixed dependencies, now we have 2 blocks where one contains direct dependencies and one contains indirect ones.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orpheuslummis orpheuslummis orpheuslummis approved these changes

Assignees

@shahzadlone shahzadlone

Labels
action/no-benchmark Skips the action that runs the benchmark. dependencies Related to dependencies
Projects
None yet
Milestone
DefraDB v0.3.1
Development

Successfully merging this pull request may close these issues.

Go mod file has multiple require blocks with mixed indirect and direct deps
2 participants
@shahzadlone @orpheuslummis