Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Make Option immutable #769

Merged
merged 2 commits into from
Aug 30, 2022

Conversation

AndrewSisley
Copy link
Contributor

Relevant issue(s)

Resolves #768

Description

Makes Option immutable.

Specify the platform(s) on which this was tested:

  • Debian Linux

@AndrewSisley AndrewSisley added refactor This issue specific to or requires *notable* refactoring of existing codebases and components action/no-benchmark Skips the action that runs the benchmark. labels Aug 30, 2022
@AndrewSisley AndrewSisley added this to the DefraDB v0.3.1 milestone Aug 30, 2022
@AndrewSisley AndrewSisley requested a review from a team August 30, 2022 16:26
@AndrewSisley AndrewSisley self-assigned this Aug 30, 2022
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #769 (79b6532) into develop (7d072bf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #769   +/-   ##
========================================
  Coverage    58.35%   58.36%           
========================================
  Files          147      147           
  Lines        16829    16833    +4     
========================================
+ Hits          9820     9824    +4     
  Misses        6084     6084           
  Partials       925      925           
Impacted Files Coverage Δ
client/option.go 100.00% <100.00%> (ø)
connor/eq.go 87.50% <100.00%> (ø)
query/graphql/planner/sum.go 82.41% <100.00%> (ø)

Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AndrewSisley AndrewSisley merged commit 58fabba into develop Aug 30, 2022
@AndrewSisley AndrewSisley deleted the sisley/refactor/I768-option-getters branch August 30, 2022 18:48
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
* Make HasValue immutable

* Make Value immutable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/no-benchmark Skips the action that runs the benchmark. refactor This issue specific to or requires *notable* refactoring of existing codebases and components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add getters to Option
2 participants