fix: Resolve the extra typeIndexJoins for _avg aggregate

[shahzadlone]

Resolves #640

Description

• Add limit check to tryGetTarget function.
• Fix the equality check with filter to find the host.
• Update the previously documented tests that had incorrect behavior.

More Info on the bug:

The host was not being found and kept getting added incorrectly, this is because reflect.DeepEqual Fails when you have a map where the key is pointer.

	a1 := "str"
	a2 := "str"
	a3 := map[*string]bool{&a1: true}
	a4 := map[*string]bool{&a2: true}
	fmt.Println(reflect.DeepEqual(a3, a4)) // False

In this case it was slightly more hidden because the key was an interface with an underlying pointer. Here is a more accurate example on what was happening (the last case represents what was happening):

type Key interface{ Get() any }
type GoodKey struct{ Name any }

func (g GoodKey) Get() any { return g.Name }

func main() {
	a := GoodKey{Name: "key"}            // {key}
	b := GoodKey{Name: "key"}            // {key}
	fmt.Println(reflect.DeepEqual(a, b)) // true

	ma := map[Key]any{a: "non-pointer"}    // map[{key}:non-pointer]
	mb := map[Key]any{b: "non-pointer"}    // map[{key}:non-pointer]
	fmt.Println(reflect.DeepEqual(ma, mb)) // true

	pa := &a                               // &{key}
	pb := &b                               // &{key}
	fmt.Println(reflect.DeepEqual(pa, pb)) // true

	mpa := map[Key]any{pa: "pointer"}        // map[0xc000014250:pointer]
	mpb := map[Key]any{pb: "pointer"}        // map[0xc000014260:pointer]
	fmt.Println(reflect.DeepEqual(mpa, mpb)) // false
}

Can run the above here: https://go.dev/play/p/bBvUubM8u_N

[codecov]

Codecov Report

Merging #774 (8f19fc5) into develop (b4d2d63) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #774      +/-   ##
===========================================
+ Coverage    59.17%   59.27%   +0.09%     
===========================================
  Files          153      153              
  Lines        16994    17035      +41     
===========================================
+ Hits         10057    10098      +41     
  Misses        6020     6020              
  Partials       917      917              

Impacted Files	Coverage Δ
query/graphql/mapper/mapper.go	85.54% <100.00%> (+0.69%)	⬆️
query/graphql/mapper/targetable.go	66.66% <100.00%> (+12.82%)	⬆️
connor/lt.go	72.72% <0.00%> (-4.55%)	⬇️

[AndrewSisley]

praise: Nice 😆

[AndrewSisley]

Looks much better than cloning and derefing and is easy to read, but added a couple of todos/question for you

[AndrewSisley]

Nice :) Was hoping you would do this

[AndrewSisley]

Approved, looks good, but 3 more comments that should preferably be addressed first (particularly the one RE why you keep looping when you already know that it is not equal)

[shahzadlone]

Approved, looks good, but 3 more comments that should preferably be addressed first (particularly the one RE why you keep looping when you already know that it is not equal)

Maybe there are some unpending comments, I only see 2 new comments + this one I am replying to.

Which comment are you referring to here: 'RE why you keep looping when you already know that it is not equal'?

[shahzadlone]

Approved, looks good, but 3 more comments that should preferably be addressed first (particularly the one RE why you keep looping when you already know that it is not equal)

Maybe there are some unpending comments, I only see 2 new comments + this one I am replying to.

Which comment are you referring to here: 'RE why you keep looping when you already know that it is not equal'?

EDIT: I think I know which one you are talking about left a follow-up reply.

[fredcarle]

Looking good. Just a few comments :)