-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Replace all interface{}
to any
alias
#805
Conversation
b640e3e
to
8d2cdd8
Compare
Codecov Report
@@ Coverage Diff @@
## develop #805 +/- ##
========================================
Coverage 59.55% 59.55%
========================================
Files 154 154
Lines 17219 17219
========================================
Hits 10254 10254
Misses 6039 6039
Partials 926 926
|
ebea721
to
38e235d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved without reading, should be fine so long as it builds (and you havent snuck anything else in here lol)
…go" -print0 | xargs -0 sed -i "s/interface{}/any/g"`
38e235d
to
354897d
Compare
question(non-blocking): it changes files in autogenerarted files. i wonder if when autoregenerating, i saw ones using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. skimmed through very fast and the pattern seemed consistent. it builds, tests are passing, ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I am not to sure about that, this should have replaced it in all *.go files. We can see if that does happen and linter complains we can add a rule for it. |
- Resolves: sourcenetwork#456 - Replace all occurrences of `interface{}` with `any` in all *.go files. - Add linter rule to ensure `any` is always used over `interface{}`. Command used: `find . -type f -name "*.go" -print0 | xargs -0 sed -i "s/interface{}/any/g"`
Relevant issue(s)
Resolves #456
Description
interface{}
withany
in all *.go files.any
is always used overinterface{}
.Command used:
find . -type f -name "*.go" -print0 | xargs -0 sed -i "s/interface{}/any/g"
Tasks
How has this been tested?
CI and Locally
Specify the platform(s) on which this was tested: