fix: Reset scan node for each join #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
bug
Scan node will have completed and will be in a finished state
AndrewSisley
force-pushed
the
sisley/fix/I827-one-one-bug
branch
from
3e32509
to
b40b99a
Compare
Codecov Report
@@ Coverage Diff @@
## develop #828 +/- ##
===========================================
- Coverage 59.59% 59.57% -0.02%
===========================================
Files 155 155
Lines 17266 17271 +5
===========================================
+ Hits 10289 10290 +1
- Misses 6048 6051 +3
- Partials 929 930 +1
|
shahzadlone
reviewed
Sep 19, 2022
Comment on lines
+124
to
+132
| // bae-fd541c25-229e-5280-b44b-e5c2af3e374d | ||
| `{ | ||
| "name": "Painted House", | ||
| "rating": 4.9 | ||
| }`, | ||
| // "bae-d3bc0f38-a2e1-5a26-9cc9-5b3fdb41c6db" | ||
| `{ | ||
| "name": "Go Guide for Rust developers", | ||
| "rating": 5.0 |
There was a problem hiding this comment.
question: why not keep the 4 fields?
There was a problem hiding this comment.
They are irrelevant, and including them suggests relevance
There was a problem hiding this comment.
A little strict xD. It doesn't hinder understanding with them in, however it also doesn't add anything
There was a problem hiding this comment.
IMO it does, when tracking down the bug the first thing I did (and this was about 50% of the effort) was remove everything extra so I had a minimal failing case. Specificity matters a lot in tests IMO. Really cuts down the possible what-if cases when looking to see why it is failing
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
Scan node will have completed and will be in a finished state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #827
Description
Resets scan node for each join. Scan node may have completed and will be in a finished state and will return nil for other items.
Specify the platform(s) on which this was tested: