Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add order support to allCommits #845

Merged
merged 4 commits into from
Sep 22, 2022

Conversation

AndrewSisley
Copy link
Contributor

Relevant issue(s)

Resolves #838

Description

Adds order support to allCommits. Also moves some types around in the schema package (separate commits).

Specify the platform(s) on which this was tested:

  • Debian Linux

@AndrewSisley AndrewSisley added area/query Related to the query component action/no-benchmark Skips the action that runs the benchmark. labels Sep 21, 2022
@AndrewSisley AndrewSisley added this to the DefraDB v0.4 milestone Sep 21, 2022
@AndrewSisley AndrewSisley requested a review from a team September 21, 2022 16:25
@AndrewSisley AndrewSisley self-assigned this Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #845 (4d5d237) into develop (5ed7426) will increase coverage by 0.04%.
The diff coverage is 86.95%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #845      +/-   ##
===========================================
+ Coverage    59.59%   59.63%   +0.04%     
===========================================
  Files          155      155              
  Lines        17274    17284      +10     
===========================================
+ Hits         10295    10308      +13     
+ Misses        6051     6045       -6     
- Partials       928      931       +3     
Impacted Files Coverage Δ
query/graphql/schema/types/types.go 100.00% <ø> (ø)
query/graphql/parser/commit.go 81.63% <70.00%> (-3.37%) ⬇️
query/graphql/schema/manager.go 97.36% <100.00%> (+0.02%) ⬆️
db/base/compare.go 61.01% <0.00%> (+10.16%) ⬆️

Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AndrewSisley AndrewSisley merged commit 0accfa5 into develop Sep 22, 2022
@AndrewSisley AndrewSisley deleted the sisley/feat/I838-order-commits branch September 22, 2022 15:20
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
* Move commit types to own file

Current file does not scale

* Move base gql types to types dir

* Move Ordering to types dir

* Add order support for allCommits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/no-benchmark Skips the action that runs the benchmark. area/query Related to the query component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commits: Add order support to all_commits
2 participants