feat: Add limit support to allCommits query #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
feature
Codecov Report
@@ Coverage Diff @@
## develop #856 +/- ##
========================================
Coverage 59.63% 59.64%
========================================
Files 155 155
Lines 17284 17294 +10
========================================
+ Hits 10308 10315 +7
- Misses 6045 6047 +2
- Partials 931 932 +1
|
shahzadlone
requested changes
Sep 22, 2022
I couldn't see how that could break here (note this PR only had to add to the parser and gql types, all order/mapper/limit code remains unchanged) |
AndrewSisley
force-pushed
the
sisley/feat/I839-commit-limit
branch
from
736e477
to
6ee8f27
Compare
Added one with offset too in #859 as it makes the offset testing more robust IMO |
|
Didn't properly link a issue 😂 |
|
:D my bad, will close it the old fashioned way lol |
The good ol' days |
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #
Description
Adds limit support to allCommits query. Let me know if you dont want it in 0.3.1.
Specify the platform(s) on which this was tested: