fix: Handle subscriber close #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
bug
Codecov Report
@@ Coverage Diff @@
## develop #877 +/- ##
===========================================
- Coverage 59.81% 59.80% -0.01%
===========================================
Files 157 157
Lines 17425 17425
===========================================
- Hits 10422 10421 -1
- Misses 6066 6067 +1
Partials 937 937
|
fredcarle
approved these changes
Oct 7, 2022
| @@ -70,14 +70,14 @@ func (c *simpleChannel[T]) Close() { | |||
| if c.isClosed { | |||
| return | |||
| } | |||
| c.isClosed = true | |||
There was a problem hiding this comment.
praise: this change fixes the race condition :) Thanks!
There was a problem hiding this comment.
Ah I see, what you meant in the original now - this was also (somewhat sneakily) added in that PR too :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #872
Description
Much simpler solution to #873 as pointed out by Fred :)
How has this been tested?
Tested manually.
Specify the platform(s) on which this was tested: