fix: Remove panics from document #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
bug
Codecov Report
@@ Coverage Diff @@
## develop #881 +/- ##
===========================================
- Coverage 59.84% 59.82% -0.02%
===========================================
Files 157 157
Lines 17443 17445 +2
===========================================
- Hits 10439 10437 -2
- Misses 6067 6070 +3
- Partials 937 938 +1
|
shahzadlone
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #615
Description
Removes panics from document. Got pushed out of 0.3.1 due to func signature change. I am assuming that there is no std-lib compatibility-type interface with
func String() stringthat we want to implement here that will now break.Specify the platform(s) on which this was tested: