test: Skip change detection for tests that assert panic #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzadlone
added
area/testing
AndrewSisley
reviewed
Oct 7, 2022
| assert.Panics(t, func() { | ||
| executeTestCase(t, test) | ||
| }) | ||
| testUtils.AssertPanicAndSkipChangeDetection(t, func() { executeTestCase(t, test) }) |
There was a problem hiding this comment.
thought: I was thinking more of adding a bool prop to the QueryTestCase struct and handling the skip within testUtils.executeTestCase - but this works too. Cheers for sorting it out
There was a problem hiding this comment.
I thought about that too, but IMO this gives us slightly more control (can assert a function other than executeTestCase if one desires) also wanted to avoid crowding QueryTestCase with another bool.
There was a problem hiding this comment.
Can revisit this in the future and is an easy change if we do prefer that route.
AndrewSisley
approved these changes
Oct 7, 2022
shahzadlone
force-pushed
the
lone/test/omit-panic-asserted-tests-from-change-detection
branch
from
8713134
to
067ff04
Compare
shahzadlone
deleted the
lone/test/omit-panic-asserted-tests-from-change-detection
branch
shahzadlone
added a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…k#883) - Resolves sourcenetwork#882 - Skip change detector for tests that assert for panics. - Clean up the assertion of panic and skipping of the change detector into a utility function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #882
Description
Tasks
How has this been tested?
CI & Locally
Specify the platform(s) on which this was tested: