feat: Add depth support for commits #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
feature
AndrewSisley
commented
Oct 12, 2022
| Results: []map[string]any{ | ||
| { | ||
| // Composite head | ||
| "cid": "bafybeiaxjhz6dna7fyf7tqo5hooilwvaezswd5xfsmb2lfgcy7tpzklikm", |
There was a problem hiding this comment.
These can be made more obvious once #852 is done
AndrewSisley
commented
Oct 12, 2022
| @@ -268,6 +268,8 @@ func (n *dagScanNode) Next() (bool, error) { | |||
| return false, errors.New("Headset scan node returned an invalid cid") | |||
| } | |||
| n.currentCid = &cid | |||
| // Reset the depthVisited for each head yielded by headset | |||
| n.depthVisited = 0 | |||
There was a problem hiding this comment.
Was a hidden/logic bug that existed previously, however was never exposed as latestCommits has a mandatory docKey (for now :)) and thus only one head will have been yielded per node-instance where depth != 0 (commits previously only allowed infinite depth)
Codecov Report
@@ Coverage Diff @@
## develop #889 +/- ##
===========================================
+ Coverage 59.73% 59.76% +0.02%
===========================================
Files 157 157
Lines 17406 17420 +14
===========================================
+ Hits 10398 10411 +13
- Misses 6067 6068 +1
Partials 941 941
|
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
* Reset the depthVisited for each head * Add depth support to commits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #888
Description
Adds depth support for commits.