refactor: Simplify dag fetcher #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is no need for this complication
Now we can see what it does, allowing for future improvements
Statefull prop doesn't really do anything
Instead of the end, plus init. I find this much easier to read.
Is easier to read IMO, and allows for future refactorings
Simpler and easier to read
AndrewSisley
added
area/db-system
Codecov Report
@@ Coverage Diff @@
## develop #913 +/- ##
========================================
Coverage 59.89% 59.90%
========================================
Files 159 159
Lines 17423 17391 -32
========================================
- Hits 10436 10418 -18
+ Misses 6053 6044 -9
+ Partials 934 929 -5
|
Is no reason for us to have to worry about this
shahzadlone
reviewed
Oct 25, 2022
shahzadlone
reviewed
Oct 25, 2022
shahzadlone
approved these changes
Oct 25, 2022
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
* Remove commented out code from commitFetcher * Remove cid from state Is no need for this complication * Remove unused type * Unfactor func called once Now we can see what it does, allowing for future improvements * Remove unused return param * Remove kvEnd Statefull prop doesn't really do anything * Call nextKey at the start of loop Instead of the end, plus init. I find this much easier to read. * Unfactor single use function Is easier to read IMO, and allows for future refactorings * Remove iteration state Simpler and easier to read * Remove potential spans error Is no reason for us to have to worry about this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Quick refactor prior to starting #849
Description
Refactors the dag fetcher prior to starting #849 - should make working in this file a bit easier.