Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include version metadata in cross-platform build script. #929

Closed
jsimnz opened this issue Nov 2, 2022 · 0 comments · Fixed by #930
Closed

Include version metadata in cross-platform build script. #929

jsimnz opened this issue Nov 2, 2022 · 0 comments · Fixed by #930
Labels
area/cli Related to the CLI binary bug Something isn't working

Comments

@jsimnz
Copy link
Member

jsimnz commented Nov 2, 2022

At the moment, the version metadata populated by the LDFLAGS at build time is only included in the regular make build step. But we also need it for the make cross-build step, which runs the cross-build.sh script.
@jsimnz jsimnz added bug Something isn't working area/cli Related to the CLI binary labels Nov 2, 2022
@jsimnz jsimnz added this to the DefraDB v0.4 milestone Nov 2, 2022
@orpheuslummis orpheuslummis mentioned this issue Nov 4, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/cli Related to the CLI binary bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Include version metadata in cross-building sourcenetwork/defradb
1 participant
@jsimnz