feat: Add GraphQL subscriptions #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredcarle
added
feature
Codecov Report
@@ Coverage Diff @@
## develop #934 +/- ##
===========================================
+ Coverage 60.05% 60.29% +0.23%
===========================================
Files 159 164 +5
Lines 17532 17700 +168
===========================================
+ Hits 10529 10672 +143
- Misses 6066 6081 +15
- Partials 937 947 +10
|
AndrewSisley
requested changes
Nov 11, 2022
AndrewSisley
approved these changes
Nov 11, 2022
| } | ||
|
|
||
| for _, def := range doc.Definitions { | ||
| switch node := def.(type) { | ||
| case *ast.OperationDefinition: | ||
| if node.Operation == "query" { | ||
| switch node.Operation { |
There was a problem hiding this comment.
praise: Thanks for making this a switch
There was a problem hiding this comment.
you're welcome :)
| @@ -66,6 +67,17 @@ var ( | |||
| mapStore bool | |||
| ) | |||
|
|
|||
| // Represents a query assigned to a particular transaction. | |||
| type SubscriptionQuery struct { | |||
There was a problem hiding this comment.
praise: I really like this test setup, thank you for finding a nice solution for this :)
shahzadlone
approved these changes
Nov 14, 2022
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
Relevant issue(s) Resolves sourcenetwork#724 Description This PR adds the functionalities related to GQL subscriptions. Subscriptions can happen through the HTTP API or using db.ExecQuery directly. It piggy backs on the previously implemented event system to listen to DB updates and then using a new Publisher, broadcasts the updates to the listening clients. The new Publisher is designed to allow the listener to close the channel hence why you'll notice many thread safety mechanics in the related methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #724
Description
This PR adds the functionalities related to GQL subscriptions. Subscriptions can happen through the HTTP API or using
db.ExecQuerydirectly.It piggy backs on the previously implemented event system to listen to DB updates and then using a new
Publisher, broadcasts the updates to the listening clients. The newPublisheris designed to allow the listener to close the channel hence why you'll notice many thread safety mechanics in the related methods.Tasks
How has this been tested?
unit and integration tests
Specify the platform(s) on which this was tested: