test: Add event tests #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
area/testing
AndrewSisley
force-pushed
the
sisley/test/I865-event-tests
branch
from
0429541
to
b799c3e
Compare
AndrewSisley
commented
Dec 13, 2022
| ) | ||
|
|
||
| // This test documents undesirable behaviour which should be corrected in | ||
| // https://github.com/sourcenetwork/defradb/issues/867 |
There was a problem hiding this comment.
The linked ticket has been commented on with a reference to this test
AndrewSisley
force-pushed
the
sisley/test/I865-event-tests
branch
3 times, most recently
from
bb1e82b
to
ad92fcd
Compare
fredcarle
requested changes
Dec 14, 2022
Comment on lines
+180
to
+184
| func assertIfExpected[T any](t *testing.T, expected immutable.Option[T], actual T) { | ||
| if expected.HasValue() { | ||
| assert.Equal(t, expected.Value(), actual) | ||
| } | ||
| } |
There was a problem hiding this comment.
praise: I like what the Option type brings to this kind of assertion.
There was a problem hiding this comment.
nice I'm glad, and thanks :)
AndrewSisley
force-pushed
the
sisley/test/I865-event-tests
branch
from
ad92fcd
to
9fb11e5
Compare
AndrewSisley
force-pushed
the
sisley/test/I865-event-tests
branch
from
8384266
to
57dc397
Compare
AndrewSisley
force-pushed
the
sisley/test/I865-event-tests
branch
from
57dc397
to
4391750
Compare
fredcarle
approved these changes
Dec 14, 2022
😁 Thanks for requsting them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #865
Description
Adds integration tests for the public-external Events channel.