Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update badger version #966

Merged
merged 1 commit into from
Dec 13, 2022
Merged

fix: Update badger version #966

merged 1 commit into from
Dec 13, 2022

Conversation

AndrewSisley
Copy link
Contributor

Relevant issue(s)

Resolves #950

Description

Updates the badger db version, which should solve a issue experienced running defra in a docker container (fix untested by me).

@AndrewSisley AndrewSisley added bug Something isn't working action/no-benchmark Skips the action that runs the benchmark. labels Dec 13, 2022
@AndrewSisley AndrewSisley added this to the DefraDB v0.4 milestone Dec 13, 2022
@AndrewSisley AndrewSisley requested a review from a team December 13, 2022 22:18
@AndrewSisley AndrewSisley self-assigned this Dec 13, 2022
shahzadlone
shahzadlone approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good however haven't tested if the docker issue was fixed.

@AndrewSisley
Copy link
Contributor Author

Looks good however haven't tested if the docker issue was fixed.

I'm very 50-50 if we should much much effort into testing that before it becomes part of our CI. New version is the latest.

@AndrewSisley AndrewSisley merged commit 9d01ecf into develop Dec 13, 2022
@AndrewSisley AndrewSisley deleted the sisley/fix/I950-update-badger-version branch December 13, 2022 23:03
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@AndrewSisley
chore: Update badger version (sourcenetwork#966)
11e02df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzadlone shahzadlone shahzadlone approved these changes

Assignees

@AndrewSisley AndrewSisley

Labels
action/no-benchmark Skips the action that runs the benchmark. bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update badger version to prevent mremap size error.
2 participants
@AndrewSisley @shahzadlone